From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00F32C54E41 for ; Fri, 8 Mar 2024 21:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LbLniHF0mo4/cUR7qULlY1YQtn5GBmNL37dwiAt/vDo=; b=az/8WToVL2JfZH IJOGAAPhgJnrDswuRuCv6om9UzLzME+qJC8GY0Ha4Hr4LUVn5vpZZEgmTXuirIxjPOVfTwG7Z1P8M 85qfQiBjeLMWJH+xqwlL9ttz8pUN6U1zNvPGj3PaH64cmmjt235HmYO0kUmpkeA4+sV3YAYDYGCFj dQDKXDKltaLemnMQR1MgEymRBP0DiqXBovK8XDwKnmnmbgJkZ0/hlIOcE+cL6+0azgimcag7236bh sbTcaxunD8SWzEcS+qjx83im6oJpSms6GHJuPBpPWaMFS4shSby6rTXbX3kN6Kunk0Ga20OvNDJvY edVEQkQAQhWP2iTgSlXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rihWo-0000000BKoJ-24j5; Fri, 08 Mar 2024 21:13:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rihWl-0000000BKnO-3Guh for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 21:13:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0625760CFA; Fri, 8 Mar 2024 21:13:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65B78C433C7; Fri, 8 Mar 2024 21:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709932392; bh=Cl/9Sp/NINGtvBYYiSrwF+QPSh3NMkkxwESwsbvSXak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W3k/WFpg5OC+DFozK8WwA9u1toMKDEt7mS4BOsCZBggUwISOFws3qP2Zo3W4At62A M01+5T1KwTrBO2Wbv6ps0axa0muQKblUlWQimJzXUKeDGi29jp2GhnA+o2mlZsvvN4 9xDY3a9v11lws7MbmYh88KwtZbkAMC5AEuMEYpolYE303RIg3Nx/UDdRdHaclwfJ1Q kajW1QH04Tt/NfBcG0qC7uWe05M+/M7PV5vyK7rdHl8N4L/4XPclPpRpEixKMfDinD vpLHwROOhhG8fYdOTkR38MZMhanKrDQjtE8LFVsuqTsoibumL46BbxDu068MiATv/O 3o4uX44uvKFIQ== Date: Fri, 8 Mar 2024 15:13:10 -0600 From: Rob Herring To: Frank Li Cc: Conor Dooley , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shengjiu Wang , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v6 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Message-ID: <20240308211310.GA1291632-robh@kernel.org> References: <20240308-asrc_8qxp-v6-0-e08f6d030e09@nxp.com> <20240308-asrc_8qxp-v6-3-e08f6d030e09@nxp.com> <20240308-croon-goofball-797d091e981a@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_131315_974855_4F050D86 X-CRM114-Status: GOOD ( 25.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 08, 2024 at 03:21:14PM -0500, Frank Li wrote: > On Fri, Mar 08, 2024 at 02:06:08PM -0500, Frank Li wrote: > > On Fri, Mar 08, 2024 at 04:58:16PM +0000, Conor Dooley wrote: > > > On Fri, Mar 08, 2024 at 10:30:52AM -0500, Frank Li wrote: > > > > Some sai only connect one direction dma (rx/tx) in SOC. For example: > > > > imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx" > > > > for dma-names. > > > > > > > > Remove description under dmas because no user use index to get dma channel. > > > > All user use 'dma-names' to get correct dma channel. dma-names already in > > > > 'required' list. > > > > > > > > Acked-by: Conor Dooley > > > > Signed-off-by: Frank Li > > > > > > Please drop my ack from this, this isn't the patch I acked originally > > > and we were having a conversation as recently as yesterday on v4 about > > > this patch because Rob didn't like this approach. His suggestion is > > > better than the one I gave on v4 that you have used here. > > I paste your comments here > > "What I suggested is different, it is more permissive than what you have > or what Rob suggested. Your original one allows > "rx", "tx" OR "rx" OR "tx" > Rob's allows the same but with a nicer syntax. What that stm binding I > mentioned allows is > "rx", "tx" OR "tx", "rx" OR "rx" OR "tx" > " > > Actually: > > "rx", "tx" OR "tx", "rx" OR "rx" OR "tx" is exactly what we want. No, it is not. > "rx", "tx" OR "rx" OR "tx" is only feasible, but not perfect. Why need > limited "rx" and "tx" order? First, that's exactly what the binding already had. Why loosen it? Second, defined order is just the DT way. There is less reason to support both ways. It is simpler for a client to read properties if it knows the position of entries. > It just bring us some noise and no actual > value to do that. > > Frank > > > > > > Why do you think Rob don't like this approach? He just said this is 3rd > > method. And it is simple enough and match all restriction. I don't like the approach. Clear enough? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel