From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E271C54791 for ; Sat, 9 Mar 2024 18:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q6ZLn8tZUQo2VTt7+ER2fL7+eDShXn58UcBtdHnpK9E=; b=ffHoO/RMpx7pmv ejZDKI70gds3LURvySELAfgdpG5hoeUO8buEVVYQ5haU+bFie97VpK3c4elEwFq53IIZHxmcSBkVh GQX1F6UYCM4UdrzGvzqVskGZ/la1dIc+JWR4I7bSO1mQR5nQz2ykbVaEfqLCEH65LA0yFhlY2GaWO +B/WmoWwJV8XvUXG+t1lpPjZ3sR0FnvtoOMAIkgMEYMhNqksUDIRWH7mmtBjw16nWS9rKk/xChhB8 uc+jr47GzwU0Wdz61TU0aIktUojGc6u7jSpW+OJR/Zlw7KWiE8DRh6CcsaSY8QdJv28vjqi3vOueV cdrgVwaXP+Jo0m76Eb+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rj1WC-0000000E04F-2wqr; Sat, 09 Mar 2024 18:34:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rj1W9-0000000E02g-3Foa for linux-arm-kernel@lists.infradead.org; Sat, 09 Mar 2024 18:33:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6493F60202; Sat, 9 Mar 2024 18:33:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCC3DC433C7; Sat, 9 Mar 2024 18:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710009236; bh=V4BVn+p29jgKIEBrnrJ3faIeVM+yxyyl+7AFMGtnH0Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GMmGgB5ZGTU0byoloLB3ufSybDONQ/KEUnQHiWLD5fCXkYiMa6L+mSgxdKo5EtfBK cI9K9DFxV+tv9JFybeSCZwCyPFPqbcbY8UOS5JPHveV3N7gRJzG6WMMdY62vD25L+2 R1j0iCmrCsnte5JNnawVZkqwhzMHJTgh/g8abZT7vUg074sosXG50YmWXbS16/5nTH mjLBYnFpBj5UNsEDzctHruT9XCzNR4CRLkelIwuRoTCXxvt/hK5exeys9TJ+iN4CyG h0FC344So3IiUKdBwQw2Hlnw3mTb77GKMhYWtAIIDTPAaV2Y+At/aI4PmVF3D50qoj M4xMOdWiaUFaQ== Date: Sat, 9 Mar 2024 18:33:42 +0000 From: Jonathan Cameron To: Javier Carrasco Cc: Arnd Bergmann , Greg Kroah-Hartman , Michal Simek , Lars-Peter Clausen , Lorenzo Bianconi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 0/4] Drop casting to void in dev_set_drvdata Message-ID: <20240309183342.578161e7@jic23-huawei> In-Reply-To: <20240303-void_in_dev_set_drvdata-v1-0-ae39027d740b@gmail.com> References: <20240303-void_in_dev_set_drvdata-v1-0-ae39027d740b@gmail.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240309_103357_903513_38698E8C X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 03 Mar 2024 23:34:38 +0100 Javier Carrasco wrote: > The C standard specifies that there is no need to cast from a pointer to > void [1]. > > The vast majority of the users of dev_set_drvdata do not cast their > pointers to void, and the few that do so should be fixed before it > spreads by following bad examples (which I was about to do here [2]). > > The very specific cases where the cast avoids warnings (e.g. droping > const) have been kept as they are. > > [1] C Standard Committee: https://c0x.shape-of-code.com/6.3.2.3.html > [2] https://lore.kernel.org/linux-iio/20240226-hdc3020-pm-v2-0-cec6766086e8@gmail.com/T/#t > > Signed-off-by: Javier Carrasco > --- > Javier Carrasco (4): > char: xilinx_hwicap: drop casting to void in dev_set_drvdata > io: light: st_uvis25: drop casting to void in dev_set_drvdata > iio: humidity: hts211: drop casting to void in dev_set_drvdata > iio: imu: st_lsm6dsx: drop casting to void in dev_set_drvdata > > drivers/char/xilinx_hwicap/xilinx_hwicap.c | 2 +- > drivers/iio/humidity/hts221_core.c | 2 +- > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +- > drivers/iio/light/st_uvis25_core.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > --- > base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72 > change-id: 20240303-void_in_dev_set_drvdata-2d8cae908e49 > > Best regards, Thanks for tidying these up. Applied to the togreg-normal branch of iio.git. This will get rebase on rc1 once available and become togreg. Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel