From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB921C54E58 for ; Mon, 11 Mar 2024 05:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8iACLV5x7usTRB12GH4Myo98zcJJh7tJPynX1N8aReA=; b=KlPot0/muoTMDT v9ih5GtuYIPCNo7EZ8++jFe0vZiDXbWbfIqD6s6C258nBnTpvlQiwG5CYKycQjR7j4zyniN6dfWKh Wo6/5i3q4Oii6mRGa1KvJpBc1C91cH6ISnvwaC64Nz5I5UvD6yzVp6PW+6BOShBlE3IjDNEK4a3NJ 1Oml5rWyqVbUd7GV0CUhUodWQRVCE9qkV4iQbPwQa06AeshOZHId8g371rk0Nk+b1PHEg2F3y0fRv 5WK33TkL5amc6c/7jIARo6R8O4UqvKOgCfkcBge/bBhnTrYtyC5QJ3afXa+qik5gDuwx2uGfOsLI1 qcF/xmOCsZqk2hN3yXiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjYC2-00000000FJf-3hb2; Mon, 11 Mar 2024 05:27:22 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjYBy-00000000FJ5-2jIm for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2024 05:27:20 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 42B5QrOV119765; Mon, 11 Mar 2024 00:26:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1710134813; bh=/QS4flGaV72pHQT1zN8FWRnbbRvdTfxPqlBeYm8/pq8=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=FUjoOWE7KLA08lIzNTyvuuNwKDC8S1x6U2Er8yPUg9q0msDJ2kkm6uzsXA5uJKBsq 2k8gKKf0LWcu2WyhHfNGOhbntjoNmrelrfIRW+6mygkpnSqhUG6HY8EDZVNgPb+UH1 BxVVjoBKjDgjcV9pu9XpCI1dlesUADx6O1W67a58= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 42B5QrZn108507 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 11 Mar 2024 00:26:53 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 11 Mar 2024 00:26:52 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 11 Mar 2024 00:26:52 -0500 Received: from localhost (dhruva.dhcp.ti.com [172.24.227.68]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 42B5QpPg086960; Mon, 11 Mar 2024 00:26:52 -0500 Date: Mon, 11 Mar 2024 10:56:51 +0530 From: Dhruva Gole To: Viresh Kumar CC: Sibi Sankar , , , , , , , , , , , Subject: Re: [PATCH V2] cpufreq: Fix per-policy boost behavior on SoCs using cpufreq_boost_set_sw Message-ID: <20240311052651.uedxt2wvywqlrsac@dhruva> References: <20240308103630.383371-1-quic_sibis@quicinc.com> <20240311045044.7vvzbsx5nqs5a2lr@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240311045044.7vvzbsx5nqs5a2lr@vireshk-i7> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240310_222718_757492_E5C6067E X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mar 11, 2024 at 10:20:44 +0530, Viresh Kumar wrote: > On 08-03-24, 16:06, Sibi Sankar wrote: > > + /* Let the per-policy boost flag mirror the cpufreq_driver boost during init */ > > + if (cpufreq_driver->boost_enabled) > > + policy->boost_enabled = policy_has_boost_freq(policy) ? true : false; > > Can be written as: > > policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy); I would like to recommend the same. > > Reviewed-by: Viresh Kumar Rest looks fine, Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel