public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Dhruva Gole <d-gole@ti.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: <sudeep.holla@arm.com>, <cristian.marussi@arm.com>,
	<rafael@kernel.org>, <viresh.kumar@linaro.org>,
	<morten.rasmussen@arm.com>, <dietmar.eggemann@arm.com>,
	<lukasz.luba@arm.com>, <sboyd@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_mdtipton@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	<nm@ti.com>
Subject: Re: [PATCH V4 1/2] firmware: arm_scmi: Add support for marking certain frequencies as turbo
Date: Tue, 12 Mar 2024 17:39:53 +0530	[thread overview]
Message-ID: <20240312120953.u6lfmgw33rcosjwl@dhruva> (raw)
In-Reply-To: <20240312094726.3438322-2-quic_sibis@quicinc.com>

On Mar 12, 2024 at 15:17:25 +0530, Sibi Sankar wrote:
> All opps above the sustained frequency are treated as turbo, so mark them
> accordingly.
> 
> Suggested-by: Sudeep Holla <sudeep.holla@arm.com>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
> 
> v4:
> * Pickup Rbs
> * Use turbo and simplify setting turbo. [Dhruva/Viresh]
> 
>  drivers/firmware/arm_scmi/perf.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> index 8e832d1ad825..345fff167b52 100644
> --- a/drivers/firmware/arm_scmi/perf.c
> +++ b/drivers/firmware/arm_scmi/perf.c
> @@ -871,6 +871,9 @@ static int scmi_dvfs_device_opps_add(const struct scmi_protocol_handle *ph,
>  		else
>  			freq = dom->opp[idx].indicative_freq * dom->mult_factor;
>  
> +		/* All OPPs above the sustained frequency are treated as turbo */
> +		data.turbo = freq > dom->sustained_freq_khz * 1000;
> +

Reviewed-by: Dhruva Gole <d-gole@ti.com>

>  		data.level = dom->opp[idx].perf;
>  		data.freq = freq;
>  
> -- 
> 2.34.1
> 

-- 
Best regards,
Dhruva Gole <d-gole@ti.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-03-12 12:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  9:47 [PATCH V4 0/2] cpufreq: scmi: Add boost frequency support Sibi Sankar
2024-03-12  9:47 ` [PATCH V4 1/2] firmware: arm_scmi: Add support for marking certain frequencies as turbo Sibi Sankar
2024-03-12 12:09   ` Dhruva Gole [this message]
2024-03-12  9:47 ` [PATCH V4 2/2] cpufreq: scmi: Enable boost support Sibi Sankar
2024-03-12 12:09   ` Dhruva Gole
2024-03-15  5:50 ` [PATCH V4 0/2] cpufreq: scmi: Add boost frequency support Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240312120953.u6lfmgw33rcosjwl@dhruva \
    --to=d-gole@ti.com \
    --cc=cristian.marussi@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=morten.rasmussen@arm.com \
    --cc=nm@ti.com \
    --cc=quic_mdtipton@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox