From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A29D6C54E5D for ; Tue, 12 Mar 2024 14:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/3ONn5kyKxYPm3HRIzEPUX8Bwejj0xJOnAHxQz74oog=; b=MpwJHQt4zq/Kbn mf+l2hpplgwFN/G86eLROFipn48uEtQa2piV5bpnTxqqbglWQ/LsYf/JHpEh70oNDKNd4aps9vw4N l3pW4gltTdnCxsYKOEJzSXmI1NsgnJzk2IHZ95MiLGZGyZR1HjOshx+DtLBHaScliBx2/ZETr+iku /xaAzXywj6U1N+3+/ifaEUrl8T2pnfj72NPnidZaL0zfEkcxi+BZUN1QpNgXOp424jWAkfhpPvtgv DWfFk6iLgRtwAbjHu4hVNXOMxOKFFM4ym+35SdVJ4cItZh2e39HPnCe9kZMcYVdfupMsCxI2MXP+A bL2Znp3m/oN2zKd/W4KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk3Sn-00000006EIW-062Y; Tue, 12 Mar 2024 14:50:45 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk3Si-00000006EEM-1bD7 for linux-arm-kernel@lists.infradead.org; Tue, 12 Mar 2024 14:50:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4B147CE17F0; Tue, 12 Mar 2024 14:50:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AD9DC43394; Tue, 12 Mar 2024 14:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710255037; bh=weQH3/gYArkWG361nWx6QB+7+ypFbZg4bPxLz+L6YaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ch/HFhvZSluXRP17dbhV2T8wcG4TrWNoidrLt5OgAwb5ee6GUl58rKrFLKeA9HZSI GGuBtiLqrNsl91nynLWcXj9/uuafLbUew/Qw2K/gxiOWC5T2WzfIwbh07asP7JP8dN wjNdOxeoFkPzuEf4xXVcD10MvH8e/zVggavxjoaGVe9P6Kq2Pi//ilHivKW/Ymr3uG ZD0vmyPh/Q/J/H6lQGyMETa2s5/JYsmhSNG2Bo7BQOq3mX7R5X1vLqVW0zmHrbFctc UfiayyZNXre9mfAjhjEOWiqe+dL2fkw6bxJWxQCLdnOpVyP9DMfgUeeivS4vEj4v70 EXxy27b5ukYgw== Date: Tue, 12 Mar 2024 08:50:35 -0600 From: Rob Herring To: Xu Yang Cc: gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, peter.chen@kernel.org, jun.li@nxp.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 05/10] dt-bindings: usb: ci-hdrc-usb2-imx: add restrictions for reg, interrupts, clock and clock-names properties Message-ID: <20240312145035.GA2204647-robh@kernel.org> References: <20240312091703.1220649-1-xu.yang_2@nxp.com> <20240312091703.1220649-5-xu.yang_2@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240312091703.1220649-5-xu.yang_2@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240312_075040_909951_0FD3CA73 X-CRM114-Status: GOOD ( 17.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 12, 2024 at 05:16:58PM +0800, Xu Yang wrote: > Add restrictions for reg, interrupts, clock and clock-names properties > for imx Socs. > > Signed-off-by: Xu Yang > > --- > Changes in v4: > - new patch since v3's discussion > - split the reg, interrupts, clock and clock-names properties into > common part and device-specific > Changes in v5: > - keep common property unchanged > - make if-then more readable > - remove non imx part > Changes in v6: > - new patch based on ci-hdrc-usb2-imx.yaml > Changes in v7: > - no changes > Changes in v8: > - remove if:else:if:else:if:else block > --- > .../bindings/usb/chipidea,usb2-imx.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml > index cdbb224e9f68..fb1c378dfe88 100644 > --- a/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml > +++ b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml > @@ -49,6 +49,12 @@ properties: > - const: fsl,imx6ul-usb > - const: fsl,imx27-usb > > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > clocks: > minItems: 1 > maxItems: 3 > @@ -144,6 +150,80 @@ allOf: > - const: idle > - const: active > > + # imx27 Soc needs three clocks > + - if: > + properties: > + compatible: > + const: fsl,imx27-usb > + then: > + properties: > + clocks: > + minItems: 3 > + maxItems: 3 The max is already 3, so drop maxItems. > + clock-names: > + items: > + - const: ipg > + - const: ahb > + - const: per > + > + # imx25 and imx35 Soc need three clocks > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx25-usb > + - fsl,imx35-usb > + then: > + properties: > + clocks: > + minItems: 3 > + maxItems: 3 Same here. > + clock-names: > + items: > + - const: ipg > + - const: ahb > + - const: per > + > + # imx7d Soc need one clock > + - if: > + properties: > + compatible: > + items: > + - const: fsl,imx7d-usb > + - const: fsl,imx27-usb > + then: > + properties: > + clocks: > + maxItems: 1 > + clock-names: > + maxItems: 1 What's the name? > + > + # other Soc need one clock > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx23-usb > + - fsl,imx28-usb > + - fsl,imx50-usb > + - fsl,imx51-usb > + - fsl,imx53-usb > + - fsl,imx6q-usb > + - fsl,imx6sl-usb > + - fsl,imx6sx-usb > + - fsl,imx6ul-usb > + - fsl,imx8mm-usb > + - fsl,imx8mn-usb > + - fsl,vf610-usb > + then: > + properties: > + clocks: > + maxItems: 1 > + clock-names: > + maxItems: 1 > + > unevaluatedProperties: false > > examples: > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel