From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C636C54791 for ; Wed, 13 Mar 2024 16:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=BzN+n3/4Nf/WVuVltyMf5kNcuKMrNOdRt5defqa844U=; b=gsAKyCtiMnEj/W fefjW6GEqtnDzTS8wOn0cbFm6KRQKEfnjnB2/foG91/teyNKj4m0cihhEZ8Q5FmysnoGe4uJfz5oe DKBOG+ilOtYEf6HIkIIE2TMIIMvZHmx4wwe+q5/Xwe7k1RZQBsVb0pMBltAWjwd7MI1oZ+87wXIC0 X1uRO/TioapDP0xaoKiv6mcNx/9pSH7MzD/Qqtupp0OS+tHAcT+ELQ4HsFbnuydz7TSOy/lBfsLpL W1ULsAvcC1sGnvBBszwB3rcC4h4Q2NnhOcVvmjH2PgnP+6U3fO9l29srEdhr1Vz13YrOP6icna6Nd f6qs+G12n/AHKypPgAww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkRbZ-0000000Anmo-2AAz; Wed, 13 Mar 2024 16:37:25 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkRbW-0000000AnlT-03ht; Wed, 13 Mar 2024 16:37:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 814B5614BD; Wed, 13 Mar 2024 16:37:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80E82C43394; Wed, 13 Mar 2024 16:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710347841; bh=KQvW4QLqr7rEMfi/hFQOWFcSE+Lk/YdZwM/sAdZU8Ec=; h=From:To:Cc:Subject:Date:From; b=QcFccfP0iWyuyg7dmYSxeMED1MJH9zJ5I13qdTMpm9k+gBLWKyBb+9/mOB2KcfRh1 dGhjb9W/4N+EdKcUS06eR55r9U0S8mzyfKb8b0WFux1jA6YamOwOIkVSc08H5Y0+ei 5zYu2a2uLnMexXRWo1UTiwAn+gXmGL2KIdz73bUcJQ2fX61d8N7a9/by2Y7lSR4pHO QwFUlknS67JXAADwfnpFFhUX50hQhSq2q/rKT/TU++YuNB2FW18cOVde+ClYZbs2kW n40Y9/7SY5DtcSfsTJqg1PwTYbbfI0pqSU9J1AUR/mgG90A5sqpl8eknByDXrK8ooo UP3iMh+Rryv+w== From: Arnd Bergmann To: Florian Fainelli , Greg Kroah-Hartman Cc: Arnd Bergmann , Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: vc04_services: changen strncpy() to strscpy_pad() Date: Wed, 13 Mar 2024 17:36:56 +0100 Message-Id: <20240313163712.224585-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_093722_300057_1D273EC7 X-CRM114-Status: GOOD ( 10.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann gcc-14 warns about this strncpy() that results in a non-terminated string for an overflow: In file included from include/linux/string.h:369, from drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:20: In function 'strncpy', inlined from 'create_component' at drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:940:2: include/linux/fortify-string.h:108:33: error: '__builtin_strncpy' specified bound 128 equals destination size [-Werror=stringop-truncation] Change it to strscpy_pad(), which produces a properly terminated and zero-padded string. Signed-off-by: Arnd Bergmann --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index 258aa0e37f55..6ca5797aeae5 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -937,8 +937,8 @@ static int create_component(struct vchiq_mmal_instance *instance, /* build component create message */ m.h.type = MMAL_MSG_TYPE_COMPONENT_CREATE; m.u.component_create.client_component = component->client_component; - strncpy(m.u.component_create.name, name, - sizeof(m.u.component_create.name)); + strscpy_pad(m.u.component_create.name, name, + sizeof(m.u.component_create.name)); ret = send_synchronous_mmal_msg(instance, &m, sizeof(m.u.component_create), -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel