From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECC25C54E60 for ; Thu, 14 Mar 2024 15:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F4mPQ8KdEFIO18erL8Nb6/0AtAdSmWQ3BG004vAIGbU=; b=IwVb1N2RRPH98O+/aJhjiAcepO oKYYce7xx7gydha8meVOzS8/Yu8p1f3AHJeWPF4ykihn5RX4YooDaQVAcAFWCoxajx/wGxDCCWFqN w/45I/JrNeJadwKvXvGOZYXRKveeB4qS9Tt8DO5ZZvrS67ZEpWKtgEOuQIjZ5MGdTKuv7i/iP01KB YqqBMr9RWAIpr+B8yw96EnafzlyuFeF/w4IbE85M2LLu8672yxgBxhB87duq0+/FMwVxGtuBXjpTo oD3VZ+qIBsuPD545NPFwlErN2aB6WgHVCkzcH4+r1XXugXKJ3YSA/Vyu30kOMNmszcMGv+fvkQvp6 KhnxPrAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkmdK-0000000Ekk3-1HnU; Thu, 14 Mar 2024 15:04:38 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkmdH-0000000EkjV-06Q2 for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2024 15:04:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 11CC5CE0E49; Thu, 14 Mar 2024 15:04:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE71EC43390; Thu, 14 Mar 2024 15:04:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710428672; bh=6P2LfVI5ti9AMF7ok98eGXZ4p8eeBn7+IOGZj+oGtQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CW3gfuAuCwxjr9HzOCCsYaD4IGJFlf+7m3r5gtdj73datUqZH5K4bZBIlzoHEp4EG s7b+oApWzWyv4SHNmiaRZPpLN9IE6ZASCQY8YpSbpCwuuQuJqir+CbpE0/DvaPl+No hHoGYga0Cow/amTVofqHKl2rhr8c2yfyjskaRYFZWysBegJCkyBMkZZF4Etdk6q/U8 ioB3t+kvr34JNxjQPUGBRVpen66UVVAzXCuutuaHTTSKaEY2wsTSiQyc+DjoOYdlND 19ABvjYS5nYdBnBRbP3g79ZIY12W006rpoU7xqqyQcEournDhY3rIKvfp1YUnGibD8 PT8IYkHIv4iKg== Date: Thu, 14 Mar 2024 16:04:29 +0100 From: Maxime Ripard To: Geert Uytterhoeven Cc: David Laight , Arnd Bergmann , Naresh Kamboju , open list , Linux ARM , "linux-sunxi@lists.linux.dev" , "dri-devel@lists.freedesktop.org" , "lkft-triage@lists.linaro.org" , Dave Airlie , Dan Carpenter , Ard Biesheuvel Subject: Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined! Message-ID: <20240314-thundering-steadfast-goat-a685cc@houat> References: <338c89bb-a70b-4f35-b71b-f974e90e3383@app.fastmail.com> <20240304-brawny-goshawk-of-sorcery-860cef@houat> <85b807289ff2400ea5887ced63655862@AcuMS.aculab.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240314_080435_617221_358D2E7C X-CRM114-Status: GOOD ( 22.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7745167744846533464==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7745167744846533464== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="myyknztutswewlxd" Content-Disposition: inline --myyknztutswewlxd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 14, 2024 at 10:27:23AM +0100, Geert Uytterhoeven wrote: > On Sat, Mar 9, 2024 at 3:34=E2=80=AFPM David Laight wrote: > > From: Maxime Ripard > > > Sent: 04 March 2024 11:46 > > > > > > On Mon, Mar 04, 2024 at 12:11:36PM +0100, Arnd Bergmann wrote: > > > > On Mon, Mar 4, 2024, at 09:07, Naresh Kamboju wrote: > > > > > The arm defconfig builds failed on today's Linux next tag next-20= 240304. > > > > > > > > > > Build log: > > > > > --------- > > > > > ERROR: modpost: "__aeabi_uldivmod" > > > > > [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined! > > > > > > > > > > > > > Apparently caused by the 64-bit division in 358e76fd613a > > > > ("drm/sun4i: hdmi: Consolidate atomic_check and mode_valid"): > > > > > > > > > > > > +static enum drm_mode_status > > > > +sun4i_hdmi_connector_clock_valid(const struct drm_connector *conne= ctor, > > > > + const struct drm_display_mode *mod= e, > > > > + unsigned long long clock) > > > > { > > > > - struct sun4i_hdmi *hdmi =3D drm_encoder_to_sun4i_hdmi(encod= er); > > > > - unsigned long rate =3D mode->clock * 1000; > > > > - unsigned long diff =3D rate / 200; /* +-0.5% allowed by HDM= I spec */ > > > > + const struct sun4i_hdmi *hdmi =3D drm_connector_to_sun4i_hd= mi(connector); > > > > + unsigned long diff =3D clock / 200; /* +-0.5% allowed by HD= MI spec */ > > > > long rounded_rate; > > > > > > > > This used to be a 32-bit division. If the rate is never more than > > > > 4.2GHz, clock could be turned back into 'unsigned long' to avoid > > > > the expensive div_u64(). > > > > > > I sent a fix for it this morning: > > > https://lore.kernel.org/r/20240304091225.366325-1-mripard@kernel.org > > > > > > The framework will pass an unsigned long long because HDMI character > > > rates can go up to 5.9GHz. > > > > You could do: > > /* The max clock is 5.9GHz, split the divide */ > > u32 diff =3D (u32)(clock / 8) / (200/8); >=20 > +1, as the issue is still present in current next, as per the recent > nagging from the build bots. A patch to fix it has been merged today and will show up tomorrow in next. Maxime --myyknztutswewlxd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZfMR/QAKCRDj7w1vZxhR xeThAP9hu9uZyhsosg4xaXjQSqrklVzWAccxuvVo+wD/BvBe5AD7BfMoiWAkmZWD we529wvyNXrp/62iho4i01acFGaHUgA= =x+QF -----END PGP SIGNATURE----- --myyknztutswewlxd-- --===============7745167744846533464== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7745167744846533464==--