From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1A72C54E67 for ; Sun, 17 Mar 2024 18:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zSFSmiHZDNl7yl/WFs3WKkMytutf4ZGnJB6s7Y69YzM=; b=AJlCAJfQjbq12C rfqWT9O+15Duqa3ya/s7jVNIyF0GtCowExGHAmGNplG1p7VSK3YIXCrlVv9giKzHekc93Jr5MNh/X HuC6wHcxTzXzRfJP0JGJP5cCvKtG9w0PLotOfobFxUuIHnfBGNZEU3U/7LnybxySOTjV8yUtHjvDf azE21rgZCqNStX5O5IHHc/T7lj24wTrlEFMpKCD6uvluJhOkKYz6v0gZWKYxTr67CzIGMCzpr5hjv lstsV1XijXxCRB6M9+CH5vVvT9fQvf0WRqFD6pEjeOQ1mPrd7/oOxLNQYyqQCqdiQbcC8grWSszCE 4QzxEYO/ZYtHA+yaJY+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlvhN-0000000671M-2HWG; Sun, 17 Mar 2024 18:57:33 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlvhJ-000000066zq-3aiL for linux-arm-kernel@lists.infradead.org; Sun, 17 Mar 2024 18:57:31 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6BFA863C; Sun, 17 Mar 2024 19:56:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710701819; bh=cDYCiCx7FpAXGD2XWaONu3BTMkgg0DGFlVS5Q73yTf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ILifDoXkFbj96Ka3bjtwYHUxepfxzzvP8G8KYWsl67+qlCtqNAg6fbFCJTNCd4gRx wIc/Yv1LF8cSJuceZVPCNF7R37xLCDAKXI+6Ti61c/Ewut+uOKwVz1j4XR9v8CCDBv wl+fZH8kUMx0nJ1Ntr7+8WpOghlKlu9ZFK2GQQYI= Date: Sun, 17 Mar 2024 20:57:22 +0200 From: Laurent Pinchart To: Andrew Lunn Cc: linux-arm-kernel@lists.infradead.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , imx@lists.linux.dev, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/5] arm64: dts: freescale: Add device tree for Compulab UCM-iMX8M-Plus Message-ID: <20240317185722.GA24220@pendragon.ideasonboard.com> References: <20240317164850.32708-1-laurent.pinchart@ideasonboard.com> <20240317164850.32708-3-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240317_115730_058498_F2D0DAE7 X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 17, 2024 at 06:17:17PM +0100, Andrew Lunn wrote: > > +&eqos { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_eqos>; > > + phy-mode = "rgmii-id"; > > + phy-handle = <ðphy0>; > > + > > + mdio { > > + compatible = "snps,dwmac-mdio"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* Atheros AR8033 on v1.0, Realtek RTL8211E on v1.1 */ > > + ethphy0: ethernet-phy@0 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0>; > > + eee-broken-1000t; > > + }; > > Hi Laurent > > Do you happen to know what is broken with respect to EEE? It seems > like a lot of IMX boards have this, so i suspect it is the MAC. Maybe > we should be keying off the MAC compatible and disabling this in the > ethernet driver rather than have every .dts file needing it? I wonder if this could be cargo-cult. To be honest, I've copied it from the BSP and haven't investigated it. I've tried dropping that and haven't noticed any difference, but I'm not sure how I should test it properly. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel