From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9F21C54E5D for ; Mon, 18 Mar 2024 14:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Aa2Xve0IngeQRDF2PXhWk4pirN7JmD1MKL+8MU9lKE=; b=i3yZMl2adj+48z hLQMyFiBWJgOvEbPywqAkLnHhhV24+FCMyHX8IJHMAwZch/6rrgdz7zb+huSFfoTImpTueMt2baee /HIhkojjthhB7YEx3U2aj1i0wIIc81sozTTyVAr75jLGDy0RtcfFM6iEA8a3OXBHuhgvEWfkPVat1 vQ4dBkUqRYp1BsENeZ2mTpdmDJtXtC5r3hLkTkY1xk7apbld9+BQH+tVfUSpzboGuI8n8IzHKzBSf Ml0NqZmM/Y+CZxMzYJC0ubJzDF8VXoF0qQyzmSFvr4vo9f9oH0x94blOlmdaY19XN6E1x+eReFB6n Zg+lPcCUkgmxnl9VFKKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmDu5-00000008nOi-327o; Mon, 18 Mar 2024 14:23:53 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmDto-00000008nHe-3T7W for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 14:23:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 182BBCE0A56; Mon, 18 Mar 2024 14:23:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1790EC433C7; Mon, 18 Mar 2024 14:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710771807; bh=1S454b/v1LRtIQfIbFgwbzDLfDonxj8EstN2d0gsixY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FRjjCllkJF/Wv2VJFeMOgua0k3foxFu1rAkgxNaiK6duS2rfNjSyJUbX91BjB8LK8 0GTeTUvJ6cz1xoLFcOdlvPwsod0NODf4luGzWPqpXmUqcjY3BKD63wCo46YvJE2STX oY660GJb3ciqp/61rk43/Eq2Fhj9baNgTaI9SRWp1JcGZxmDCREkw71DrnqGjIk3ux FyBNFSAK/o/ZzXP4PakhaBgsEGbOMae71xiHBl8A1nb7XDc46CG6IYhob0UrjNGTVS DiRx/kVj+cD4tQ+EJEQXQ7hV2zGxfiMs3oAnb0WBNolL+4UGEvPN/0vNdS/OpauY0p sN5eqGv1qiEHQ== Date: Mon, 18 Mar 2024 09:23:24 -0500 From: Rob Herring To: Animesh Agarwal Cc: Vladimir Zapolskiy , Andi Shyti , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: nxp,i2c-pnx: Convert to dtschema Message-ID: <20240318142324.GA3960676-robh@kernel.org> References: <20240318091911.13426-1-animeshagarwal28@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240318091911.13426-1-animeshagarwal28@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_072348_978095_0E6CCFD2 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 18, 2024 at 02:49:05PM +0530, Animesh Agarwal wrote: > Convert the NXP PNX I2C Controller bindings to DT schema. > Keep only one example in DT schema to remove redundancy. > > Signed-off-by: Animesh Agarwal > --- > .../devicetree/bindings/i2c/i2c-pnx.txt | 34 ------------ > .../devicetree/bindings/i2c/nxp,i2c-pnx.yaml | 52 +++++++++++++++++++ > 2 files changed, 52 insertions(+), 34 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-pnx.txt > create mode 100644 Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml > diff --git a/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml b/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml > new file mode 100644 > index 000000000000..b44e4f995b73 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml Doesn't quite match the compatible string. > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/nxp,i2c-pnx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP PNX I2C Controller > + > +maintainers: > + - Animesh Agarwal > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: nxp,pnx-i2c > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 These 2 are defined in i2c-controller.yaml, so drop. > + > + clock-frequency: > + default: 100000 > + > +required: > + - compatible > + - reg > + - interrupts > + - "#address-cells" > + - "#size-cells" > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c1: i2c@400a0000 { Drop unused labels. > + compatible = "nxp,pnx-i2c"; > + reg = <0x400a0000 0x100>; > + interrupt-parent = <&mic>; > + interrupts = <51 0>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > -- > 2.44.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel