* [PATCH] dt-bindings: nxp,i2c-pnx: Convert to dtschema
@ 2024-03-18 9:19 Animesh Agarwal
2024-03-18 14:23 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Animesh Agarwal @ 2024-03-18 9:19 UTC (permalink / raw)
Cc: animeshagarwal28, Vladimir Zapolskiy, Andi Shyti, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, linux-i2c,
devicetree, linux-kernel
Convert the NXP PNX I2C Controller bindings to DT schema.
Keep only one example in DT schema to remove redundancy.
Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
---
.../devicetree/bindings/i2c/i2c-pnx.txt | 34 ------------
.../devicetree/bindings/i2c/nxp,i2c-pnx.yaml | 52 +++++++++++++++++++
2 files changed, 52 insertions(+), 34 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-pnx.txt
create mode 100644 Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml
diff --git a/Documentation/devicetree/bindings/i2c/i2c-pnx.txt b/Documentation/devicetree/bindings/i2c/i2c-pnx.txt
deleted file mode 100644
index 2a59006cf79e..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-pnx.txt
+++ /dev/null
@@ -1,34 +0,0 @@
-* NXP PNX I2C Controller
-
-Required properties:
-
- - reg: Offset and length of the register set for the device
- - compatible: should be "nxp,pnx-i2c"
- - interrupts: configure one interrupt line
- - #address-cells: always 1 (for i2c addresses)
- - #size-cells: always 0
-
-Optional properties:
-
- - clock-frequency: desired I2C bus clock frequency in Hz, Default: 100000 Hz
-
-Examples:
-
- i2c1: i2c@400a0000 {
- compatible = "nxp,pnx-i2c";
- reg = <0x400a0000 0x100>;
- interrupt-parent = <&mic>;
- interrupts = <51 0>;
- #address-cells = <1>;
- #size-cells = <0>;
- };
-
- i2c2: i2c@400a8000 {
- compatible = "nxp,pnx-i2c";
- reg = <0x400a8000 0x100>;
- interrupt-parent = <&mic>;
- interrupts = <50 0>;
- #address-cells = <1>;
- #size-cells = <0>;
- clock-frequency = <100000>;
- };
diff --git a/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml b/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml
new file mode 100644
index 000000000000..b44e4f995b73
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/nxp,i2c-pnx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP PNX I2C Controller
+
+maintainers:
+ - Animesh Agarwal<animeshagarwal28@gmail.com>
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ compatible:
+ const: nxp,pnx-i2c
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ clock-frequency:
+ default: 100000
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - "#address-cells"
+ - "#size-cells"
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ i2c1: i2c@400a0000 {
+ compatible = "nxp,pnx-i2c";
+ reg = <0x400a0000 0x100>;
+ interrupt-parent = <&mic>;
+ interrupts = <51 0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
--
2.44.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: nxp,i2c-pnx: Convert to dtschema
2024-03-18 9:19 [PATCH] dt-bindings: nxp,i2c-pnx: Convert to dtschema Animesh Agarwal
@ 2024-03-18 14:23 ` Rob Herring
2024-03-18 15:09 ` Animesh Agarwal
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2024-03-18 14:23 UTC (permalink / raw)
To: Animesh Agarwal
Cc: Vladimir Zapolskiy, Andi Shyti, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, linux-i2c, devicetree, linux-kernel
On Mon, Mar 18, 2024 at 02:49:05PM +0530, Animesh Agarwal wrote:
> Convert the NXP PNX I2C Controller bindings to DT schema.
> Keep only one example in DT schema to remove redundancy.
>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> ---
> .../devicetree/bindings/i2c/i2c-pnx.txt | 34 ------------
> .../devicetree/bindings/i2c/nxp,i2c-pnx.yaml | 52 +++++++++++++++++++
> 2 files changed, 52 insertions(+), 34 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-pnx.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml
> diff --git a/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml b/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml
> new file mode 100644
> index 000000000000..b44e4f995b73
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml
Doesn't quite match the compatible string.
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/nxp,i2c-pnx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PNX I2C Controller
> +
> +maintainers:
> + - Animesh Agarwal<animeshagarwal28@gmail.com>
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + compatible:
> + const: nxp,pnx-i2c
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
These 2 are defined in i2c-controller.yaml, so drop.
> +
> + clock-frequency:
> + default: 100000
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#address-cells"
> + - "#size-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c1: i2c@400a0000 {
Drop unused labels.
> + compatible = "nxp,pnx-i2c";
> + reg = <0x400a0000 0x100>;
> + interrupt-parent = <&mic>;
> + interrupts = <51 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> --
> 2.44.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: nxp,i2c-pnx: Convert to dtschema
2024-03-18 14:23 ` Rob Herring
@ 2024-03-18 15:09 ` Animesh Agarwal
0 siblings, 0 replies; 3+ messages in thread
From: Animesh Agarwal @ 2024-03-18 15:09 UTC (permalink / raw)
To: Rob Herring
Cc: Vladimir Zapolskiy, Andi Shyti, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, linux-i2c, devicetree, linux-kernel
On Mon, Mar 18, 2024 at 7:53 PM Rob Herring <robh@kernel.org> wrote:
> Doesn't quite match the compatible string.
Will change the file name to nxp,pnx-i2c.yaml
> These 2 are defined in i2c-controller.yaml, so drop.
> Drop unused labels.
Making these fixes in v2.
Thanks,
Animesh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-18 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-18 9:19 [PATCH] dt-bindings: nxp,i2c-pnx: Convert to dtschema Animesh Agarwal
2024-03-18 14:23 ` Rob Herring
2024-03-18 15:09 ` Animesh Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).