From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FC7FC54E5D for ; Mon, 18 Mar 2024 17:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OVO8ZICWXp5CfqSQvgjq4vtjZcULM1soBzsb41m7EJM=; b=vnR6N6dK25zTEZ 2IYqLsHO4s2ROqWFiwo6LevNymO3gLEXEEB2aAF5rX9iIo4KOZY31C0W32qs39YYSd1I/ckfMwPqi uJtNDuSSUm8uabWYBDfNTMVvgAAVq0cLKcBUZKtSSJO1d7A7bBRicXxJrg/AyEL820x7CMJ8v0AbD LVyV0EGlij/iLqxPVSfm3vF5JmleRr4Gp4C6kPR9QXUl8EMyYtKIeIMkmRFHSzc2Y17s9y/gQj+ZV R5ubhe0m1oDIz498L4XU6LSUR/5wJajep1QwAKqJnOYn2pW5CDjJiHmsYCwyhRI/222KY6VztsuZe ofnfdonXYhTh4m+FntMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmH8B-00000009X9c-3lYb; Mon, 18 Mar 2024 17:50:39 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmH88-00000009X8h-0ilf for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 17:50:37 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 94D937E9; Mon, 18 Mar 2024 18:50:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710784208; bh=pQUEXLiwsG9pj5PVCtfU0JO6LrCsUmWuFBjSmI5msyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XlZWs+Jf10VPkSIZExabneHvJ8lPq37tytooEGy4gXnTQOUn+SBX64FjyPPL5IiiN 92deGuT2P4WZHtLhdkYdvo6BzTg7FIN57y0JL/vEG/n61IUsahuTfD9wmQLYjST/81 pETs6/R8TlJ4l5MEDjO7d2427SLRIfRFb4Q1I0X4= Date: Mon, 18 Mar 2024 19:50:32 +0200 From: Laurent Pinchart To: Sean Anderson Cc: kernel test robot , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, oe-kbuild-all@lists.linux.dev, David Airlie , linux-kernel@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org, Daniel Vetter Subject: Re: [PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing Message-ID: <20240318175032.GM13682@pendragon.ideasonboard.com> References: <20240315230916.1759060-7-sean.anderson@linux.dev> <202403161704.ACHJdSJG-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_105036_505465_E23A1ED8 X-CRM114-Status: GOOD ( 21.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 18, 2024 at 11:06:40AM -0400, Sean Anderson wrote: > On 3/16/24 06:14, kernel test robot wrote: > > Hi Sean, > > > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on v6.8] > > [cannot apply to drm-misc/drm-misc-next linus/master next-20240315] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/drm-zynqmp_dp-Downgrade-log-level-for-aux-retries-message/20240316-071208 > > base: v6.8 > > patch link: https://lore.kernel.org/r/20240315230916.1759060-7-sean.anderson%40linux.dev > > patch subject: [PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing > > config: microblaze-allmodconfig (https://download.01.org/0day-ci/archive/20240316/202403161704.ACHJdSJG-lkp@intel.com/config) > > compiler: microblaze-linux-gcc (GCC) 13.2.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240316/202403161704.ACHJdSJG-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202403161704.ACHJdSJG-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > drivers/gpu/drm/xlnx/zynqmp_dp.c: In function 'zynqmp_dp_bridge_debugfs_init': > >>> drivers/gpu/drm/xlnx/zynqmp_dp.c:2168:31: warning: 'sprintf' may write a terminating nul past the end of the destination [-Wformat-overflow=] > > 2168 | sprintf(name, fmt, i); > > | ^~~ > > drivers/gpu/drm/xlnx/zynqmp_dp.c:2168:17: note: 'sprintf' output between 18 and 20 bytes into a destination of size 19 > > 2168 | sprintf(name, fmt, i); > > | ^~~~~~~~~~~~~~~~~~~~~ > > Not a bug, as i will be at most 4, which uses 1 digit. The compiler can't know that. Please fix this, there's a zero warning policy. > > vim +/sprintf +2168 drivers/gpu/drm/xlnx/zynqmp_dp.c > > > > 2136 > > 2137 DEFINE_DEBUGFS_ATTRIBUTE(fops_zynqmp_dp_rate, zynqmp_dp_rate_get, > > 2138 zynqmp_dp_rate_set, "%llu\n"); > > 2139 > > 2140 static void zynqmp_dp_bridge_debugfs_init(struct drm_bridge *bridge, > > 2141 struct dentry *root) > > 2142 { > > 2143 struct zynqmp_dp *dp = bridge_to_dp(bridge); > > 2144 struct dentry *test; > > 2145 int i; > > 2146 > > 2147 dp->test.bw_code = DP_LINK_BW_5_4; > > 2148 dp->test.link_cnt = dp->num_lanes; > > 2149 > > 2150 test = debugfs_create_dir("test", root); > > 2151 #define CREATE_FILE(name) \ > > 2152 debugfs_create_file(#name, 0600, test, dp, &fops_zynqmp_dp_##name) > > 2153 CREATE_FILE(pattern); > > 2154 CREATE_FILE(enhanced); > > 2155 CREATE_FILE(downspread); > > 2156 CREATE_FILE(active); > > 2157 CREATE_FILE(custom); > > 2158 CREATE_FILE(rate); > > 2159 CREATE_FILE(lanes); > > 2160 > > 2161 for (i = 0; i < dp->num_lanes; i++) { > > 2162 static const char fmt[] = "lane%d_preemphasis"; > > 2163 char name[sizeof(fmt)]; > > 2164 > > 2165 dp->debugfs_train_set[i].dp = dp; > > 2166 dp->debugfs_train_set[i].lane = i; > > 2167 > >> 2168 sprintf(name, fmt, i); > > 2169 debugfs_create_file(name, 0600, test, > > 2170 &dp->debugfs_train_set[i], > > 2171 &fops_zynqmp_dp_preemphasis); > > 2172 > > 2173 sprintf(name, "lane%d_swing", i); > > 2174 debugfs_create_file(name, 0600, test, > > 2175 &dp->debugfs_train_set[i], > > 2176 &fops_zynqmp_dp_swing); > > 2177 } > > 2178 } > > 2179 -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel