From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47321C54E5D for ; Tue, 19 Mar 2024 07:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SL/wqubakZwKpXLpltcOjs0pmbnrjPvgl34r7HFiytM=; b=y/LYhAtYYUeDHy c5Z0gYm+4zjpce470SP7uqz36qpTlWQiwo4SnzBLTRrKDfErOppTFhiQiDUh/iz5SqX6+HPMgxLg1 t4tcY8Zs9qi5WKSWUs506tCN7JjQRT8OsXI1ilWLPpR4aLuFksFmlHGR/Oc/aYj2+Bnpn/FyqIwBZ nDSVOumEGAAYExavbpABestXaKuWGCp6/Hl/Zn0tRf2g/MvGKGyRblj2xk5YIDzWlkyS4xg31w1MI A3O17K10RA0n1RkoWWCuz+/DmHPHXanEzM1Ctw3trw+KMful+NgaABVI/uLgHM5j65M63kZT6HkBq aUvL2yzjMfG5ilZUMtFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmTb9-0000000BenD-1xpJ; Tue, 19 Mar 2024 07:09:23 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmTb5-0000000Bemj-47YD for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2024 07:09:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710832158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zT5XIluDKuwZj5aovG/lKBNWrNVrDtTPfyq+y1mF4wM=; b=LW/BJfBhTvM+ZuMejUADQhdh2QyTItIxabGDJbCDeI34sNOXB5IZ6Mv7k9aa5823qzNCFz a5SQQMHcByJaILWE6Taj764g45ATOQzATNDh3hIkrwnXs/7agtqOWOIhsuAD1Rh5UrDxp2 OjuIfwfQ8t+x7+yO3esdYL74BOpqNyA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-RTD_mSGcOq2sgc2uMIL5hA-1; Tue, 19 Mar 2024 03:09:17 -0400 X-MC-Unique: RTD_mSGcOq2sgc2uMIL5hA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40e53200380so24833995e9.3 for ; Tue, 19 Mar 2024 00:09:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710832156; x=1711436956; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zT5XIluDKuwZj5aovG/lKBNWrNVrDtTPfyq+y1mF4wM=; b=vL7dFExZWbK05okzmmdFC4VvPlvPIuo7RShekCMG1K+aj38ApIgP+x7Z/2wHzCQHSx qD6G5gWIb0HEcbjv4SrVWpfniwETzjDAqBVpLdX3BpMkayci4ISbt/mH9gjjZLBXGN0S 6Wy68NcGGHbUpwuDNOSXL3N/XqhWLaygzYYcFIHH36K3tE14ydp8ZZrZV+YEtGrIAKFG ca/w0TugAYwPUpW98Ggb9njNNMjAZNmFx0M7ErDiFerm60JtXEhsRMMlBz46wANqg7Qd 1AHqCMKd0f5UrfzsCKsj+bg0b2xlRCiEHnZtr7le8sOIoQVPmLdyrO2a79n5kbs+lznz BIzg== X-Forwarded-Encrypted: i=1; AJvYcCUiDHrF64jpfkjB7cIF6iF0O0+L/9NjXJkg6ilU2qSPMbdN1ZsdbK4Kx/0//viR9ssjQa6gAl45cgkY7flpcksaQmHUq9T3zNGYQ2z+SvgMDHPzGT8= X-Gm-Message-State: AOJu0YwbQtc1maEvjEXuIEtwr8qwv4X3LWFmlQLjfBmrMEsh954qL87W 3UMxyO/hRVPuGFuV7Gce1TsTRwkBYhRsAWwwGyCaqbgEMR6+BQgF4S6ZOIvTeO94qBcFvzBQY5b HFjOTrFh7UnIFB5Fv9P8sYYVlBps1M/beZPZKw0uz4xjcckLZQbSWI39gLTmjkvLIWUi4Kondd9 pcIvKh X-Received: by 2002:a05:600c:1992:b0:414:c48:a90 with SMTP id t18-20020a05600c199200b004140c480a90mr4724907wmq.24.1710832155705; Tue, 19 Mar 2024 00:09:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHDd1e5i+6nIXQVJmoCwZObgsVI5MrcBSNZUIgRWA3ZiIW85NGxpS9xlncJTrr6vt2SlbA4w== X-Received: by 2002:a05:600c:1992:b0:414:c48:a90 with SMTP id t18-20020a05600c199200b004140c480a90mr4724883wmq.24.1710832155128; Tue, 19 Mar 2024 00:09:15 -0700 (PDT) Received: from redhat.com ([2.52.6.254]) by smtp.gmail.com with ESMTPSA id n20-20020a05600c501400b00414112a6159sm5165943wmr.44.2024.03.19.00.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 00:09:14 -0700 (PDT) Date: Tue, 19 Mar 2024 03:09:11 -0400 From: "Michael S. Tsirkin" To: Gavin Shan Cc: Will Deacon , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, yihyu@redhat.com, shan.gavin@gmail.com, linux-arm-kernel@lists.infradead.org, Catalin Marinas , mochs@nvidia.com Subject: Re: [PATCH] virtio_ring: Fix the stale index in available ring Message-ID: <20240319030505-mutt-send-email-mst@kernel.org> References: <20240314074923.426688-1-gshan@redhat.com> <20240318165924.GA1824@willie-the-truck> <35a6bcef-27cf-4626-a41d-9ec0a338fe28@redhat.com> <20240319020905-mutt-send-email-mst@kernel.org> <9b3030d1-cb2c-4ce0-8b24-1074b616fc84@redhat.com> <20240319024025-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_000920_194168_B89B7A0B X-CRM114-Status: GOOD ( 41.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 19, 2024 at 04:49:50PM +1000, Gavin Shan wrote: > > On 3/19/24 16:43, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2024 at 04:38:49PM +1000, Gavin Shan wrote: > > > On 3/19/24 16:09, Michael S. Tsirkin wrote: > > > > > > > > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > > > > > > > index 49299b1f9ec7..7d852811c912 100644 > > > > > > > --- a/drivers/virtio/virtio_ring.c > > > > > > > +++ b/drivers/virtio/virtio_ring.c > > > > > > > @@ -687,9 +687,15 @@ static inline int virtqueue_add_split(struct virtqueue *_vq, > > > > > > > avail = vq->split.avail_idx_shadow & (vq->split.vring.num - 1); > > > > > > > vq->split.vring.avail->ring[avail] = cpu_to_virtio16(_vq->vdev, head); > > > > > > > - /* Descriptors and available array need to be set before we expose the > > > > > > > - * new available array entries. */ > > > > > > > - virtio_wmb(vq->weak_barriers); > > > > > > > + /* > > > > > > > + * Descriptors and available array need to be set before we expose > > > > > > > + * the new available array entries. virtio_wmb() should be enough > > > > > > > + * to ensuere the order theoretically. However, a stronger barrier > > > > > > > + * is needed by ARM64. Otherwise, the stale data can be observed > > > > > > > + * by the host (vhost). A stronger barrier should work for other > > > > > > > + * architectures, but performance loss is expected. > > > > > > > + */ > > > > > > > + virtio_mb(false); > > > > > > > vq->split.avail_idx_shadow++; > > > > > > > vq->split.vring.avail->idx = cpu_to_virtio16(_vq->vdev, > > > > > > > vq->split.avail_idx_shadow); > > > > > > > > > > > > Replacing a DMB with a DSB is _very_ unlikely to be the correct solution > > > > > > here, especially when ordering accesses to coherent memory. > > > > > > > > > > > > In practice, either the larger timing different from the DSB or the fact > > > > > > that you're going from a Store->Store barrier to a full barrier is what > > > > > > makes things "work" for you. Have you tried, for example, a DMB SY > > > > > > (e.g. via __smb_mb()). > > > > > > > > > > > > We definitely shouldn't take changes like this without a proper > > > > > > explanation of what is going on. > > > > > > > > > > > > > > > > Thanks for your comments, Will. > > > > > > > > > > Yes, DMB should work for us. However, it seems this instruction has issues on > > > > > NVidia's grace-hopper. It's hard for me to understand how DMB and DSB works > > > > > from hardware level. I agree it's not the solution to replace DMB with DSB > > > > > before we fully understand the root cause. > > > > > > > > > > I tried the possible replacement like below. __smp_mb() can avoid the issue like > > > > > __mb() does. __ndelay(10) can avoid the issue, but __ndelay(9) doesn't. > > > > > > > > > > static inline int virtqueue_add_split(struct virtqueue *_vq, ...) > > > > > { > > > > > : > > > > > /* Put entry in available array (but don't update avail->idx until they > > > > > * do sync). */ > > > > > avail = vq->split.avail_idx_shadow & (vq->split.vring.num - 1); > > > > > vq->split.vring.avail->ring[avail] = cpu_to_virtio16(_vq->vdev, head); > > > > > > > > > > /* Descriptors and available array need to be set before we expose the > > > > > * new available array entries. */ > > > > > // Broken: virtio_wmb(vq->weak_barriers); > > > > > // Broken: __dma_mb(); > > > > > // Work: __mb(); > > > > > // Work: __smp_mb(); > > > > > // Work: __ndelay(100); > > > > > // Work: __ndelay(10); > > > > > // Broken: __ndelay(9); > > > > > > > > > > vq->split.avail_idx_shadow++; > > > > > vq->split.vring.avail->idx = cpu_to_virtio16(_vq->vdev, > > > > > vq->split.avail_idx_shadow); > > > > > > > > What if you stick __ndelay here? > > > > > > > > > > /* Put entry in available array (but don't update avail->idx until they > > > * do sync). */ > > > avail = vq->split.avail_idx_shadow & (vq->split.vring.num - 1); > > > vq->split.vring.avail->ring[avail] = cpu_to_virtio16(_vq->vdev, head); > > > > > > /* Descriptors and available array need to be set before we expose the > > > * new available array entries. */ > > > virtio_wmb(vq->weak_barriers); > > > vq->split.avail_idx_shadow++; > > > vq->split.vring.avail->idx = cpu_to_virtio16(_vq->vdev, > > > vq->split.avail_idx_shadow); > > > /* Try __ndelay(x) here as Michael suggested > > > * > > > * Work: __ndelay(200); possiblly make it hard to reproduce > > > * Broken: __ndelay(100); > > > * Broken: __ndelay(20); > > > * Broken: __ndelay(10); > > > */ > > > __ndelay(200); > > > > So we see that just changing the timing masks the race. > > What are you using on the host side? vhost or qemu? > > > > __ndelay(200) may make the issue harder to be reproduce as I understand. > More delays here will give vhost relief, reducing the race. > > The issue is only reproducible when vhost is turned on. Otherwise, we > aren't able to hit the issue. > > -netdev tap,id=vnet0,vhost=true,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown \ > -device virtio-net-pci,bus=pcie.8,netdev=vnet0,mac=52:54:00:f1:26:b0 Given it's vhost, it's also possible that the issue is host side. I wonder what happens if we stick a delay or a stronger barrier in vhost.c - either here: /* Make sure buffer is written before we update index. */ smp_wmb(); or here: /* Only get avail ring entries after they have been * exposed by guest. */ smp_rmb(); ? > > > > > > > > > > > > vq->num_added++; > > > > > > > > > > pr_debug("Added buffer head %i to %p\n", head, vq); > > > > > END_USE(vq); > > > > > : > > > > > } > > > > > > > > > > I also tried to measure the consumed time for various barrier-relative instructions using > > > > > ktime_get_ns() which should have consumed most of the time. __smb_mb() is slower than > > > > > __smp_wmb() but faster than __mb() > > > > > > > > > > Instruction Range of used time in ns > > > > > ---------------------------------------------- > > > > > __smp_wmb() [32 1128032] > > > > > __smp_mb() [32 1160096] > > > > > __mb() [32 1162496] > > > > > > > Thanks, > Gavin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel