From: Will Deacon <will@kernel.org>
To: Conor Dooley <conor@kernel.org>, catalin.marinas@arm.com
Cc: linux-riscv@lists.infradead.org,
Conor Dooley <conor.dooley@microchip.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Mark Rutland <mark.rutland@arm.com>,
Ji Sheng Teoh <jisheng.teoh@starfivetech.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf: starfive: fix 64-bit only COMPILE_TEST condition
Date: Tue, 19 Mar 2024 15:56:16 +0000 [thread overview]
Message-ID: <20240319155616.GC2901@willie-the-truck> (raw)
In-Reply-To: <20240318-emphatic-rally-f177a4fe1bdc@spud>
On Mon, Mar 18, 2024 at 03:35:04PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> ARCH_STARFIVE is not restricted to 64-bit platforms, so while Will's
> addition of a 64-bit only condition satisfied the build robots doing
> COMPILE_TEST builds, Palmer ran into the same problems with writeq()
> being undefined during regular rv32 builds.
>
> Promote the dependency on 64-bit to its own `depends on` so that the
> driver can never be included in 32-bit builds.
>
> Reported-by: Palmer Dabbelt <palmer@rivosinc.com>
> Fixes: c2b24812f7bc ("perf: starfive: Add StarLink PMU support")
> Fixes: f0dbc6d0de38 ("perf: starfive: Only allow COMPILE_TEST for 64-bit architectures")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> CC: Will Deacon <will@kernel.org>
> CC: Mark Rutland <mark.rutland@arm.com>
> CC: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> CC: linux-arm-kernel@lists.infradead.org
> CC: linux-kernel@vger.kernel.org
> ---
> drivers/perf/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
> index 5060e1f1ea10..7526a9e714fa 100644
> --- a/drivers/perf/Kconfig
> +++ b/drivers/perf/Kconfig
> @@ -87,7 +87,8 @@ config RISCV_PMU_SBI
> filtering, counter configuration.
>
> config STARFIVE_STARLINK_PMU
> - depends on ARCH_STARFIVE || (COMPILE_TEST && 64BIT)
> + depends on ARCH_STARFIVE || COMPILE_TEST
> + depends on 64BIT
> bool "StarFive StarLink PMU"
> help
> Provide support for StarLink Performance Monitor Unit.
> --
> 2.43.0
Thanks guys, I don't know what a starfive is so sorry for not spotting
this when I noticed the build failure on arm64.
Acked-by: Will Deacon <will@kernel.org>
Catalin -- please can you pick this into the arm64 fixes branch for -rc1?
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-19 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 15:35 [PATCH v1] perf: starfive: fix 64-bit only COMPILE_TEST condition Conor Dooley
2024-03-18 16:15 ` Palmer Dabbelt
2024-03-18 16:25 ` JiSheng Teoh
2024-03-18 17:12 ` Emil Renner Berthing
2024-03-19 15:56 ` Will Deacon [this message]
2024-03-19 16:12 ` Conor Dooley
2024-03-19 19:04 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240319155616.GC2901@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=jisheng.teoh@starfivetech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).