From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5A38C54E58 for ; Wed, 20 Mar 2024 10:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HrMYLWgC3PuCvJRplqLAdUpVxgNpX9qe/Uewg2SMHsk=; b=uMxmd9byPRpP15 nq6ffb6sVpnQvW0ZPKKL+tGbzhr7IcFfCxpNhKi3F/SQM5SKuM7nUG62enIz7MY5b7CdRn7dqS7Z/ g9KeTdnfV/543MwC3wq9xW6NUfbkOHD4GHIIV9C4E2mcznVZ49Rb2qolb9yiO+NoBPrm0X4GkGYWx eLqkVJ1XclmjSbSboYQO9wDHkH42LBbmmhvZI5+l5Dy8Kkxqxmhg+6BI8/YL8w8HhNEscPt+nxNsZ hB9R7U+eW/rf1dRMfqXgLeh9wYYAWbxjGE32CVD4844yccdaICSlmkaAjmQYtJkoGlZ34Yi2QelZe IrzMf6RL2guxfl7kSmYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmt11-0000000Gh5V-0fjA; Wed, 20 Mar 2024 10:17:47 +0000 Received: from [14.140.155.42] (helo=esa2.ltts.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmt0x-0000000Gh30-40W2 for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2024 10:17:45 +0000 IronPort-SDR: ExPPrGOtUKQdIoi8dq2mAWYU3xj1nV/gUZGFU94t9Yr6WLUA5BsTy+hmvaQFLzmnIzvomqXykr U4g0qZbSdOEg== Received: from unknown (HELO localhost.localdomain) ([192.168.34.55]) by esa2.ltts.com with ESMTP; 20 Mar 2024 15:47:39 +0530 From: Bhargav Raviprakash To: dan.carpenter@linaro.org Cc: arnd@arndb.de, bhargav.r@ltts.com, broonie@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, eblanc@baylibre.com, gregkh@linuxfoundation.org, jpanis@baylibre.com, kristo@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lgirdwood@gmail.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com, nm@ti.com, robh+dt@kernel.org, vigneshr@ti.com Subject: Re: [PATCH v3 09/11] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators Date: Wed, 20 Mar 2024 15:47:25 +0530 Message-Id: <20240320101725.464327-1-bhargav.r@ltts.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <4aee8c9a-43eb-45b4-bc23-e58aede18e54@moroto.mountain> References: <4aee8c9a-43eb-45b4-bc23-e58aede18e54@moroto.mountain> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240320_031744_541126_09245563 X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Thu, 14 Mar 2024 16:30:09 +0300, Dan Carpenter wrote: > On Fri, Mar 08, 2024 at 04:04:53PM +0530, Bhargav Raviprakash wrote: > > @@ -374,11 +518,17 @@ static int tps6594_request_reg_irqs(struct platform_device *pdev, > > { > > struct tps6594_regulator_irq_type *irq_type; > > struct tps6594 *tps = dev_get_drvdata(pdev->dev.parent); > > - int j; > > + size_t j; > > int irq; > > int error; > > + size_t interrupt_cnt; > > + > > + if (tps->chip_id == TPS6594) > > + interrupt_cnt = ARRAY_SIZE(tps6594_buck1_irq_types); > > + else > > + interrupt_cnt = ARRAY_SIZE(tps65224_buck1_irq_types); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > > - for (j = 0; j < REGS_INT_NB; j++) { > > + for (j = 0; j < interrupt_cnt; j++) { > > irq_type = &tps6594_regs_irq_types[j]; > ^^^^^^^^^^^^^^^^^^^^^^ > > irq = platform_get_irq_byname(pdev, irq_type->irq_name); > > if (irq < 0) > > The tps6594_regs_irq_types pointer needs to be renamed or people won't > know it's holding tps65224_ data. Probably the function should be > renamed too. > > regards, > dan carpenter Thanks for the feedback! The name will be changed in the next version. Regards, Bhargav _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel