From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 615CEC6FD1F for ; Wed, 20 Mar 2024 15:23:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pgAK7FhUjoFxjW7cfrcJhBHwiXI1ujOL/7ErHIl6hGQ=; b=3tgC3xTb92G5YV pwlFAw2D5coHyn35c1GbtBDkEXaPZvaDWvK5rs/GS2yO+jj10S5F9p7CEtHXt/mjb/g3xAbIoahvn 9RA7RLEcZmBsPIWEaiS9blQsXuuwP8Q6PumOqEwxPepn3pD7e8vgGJnxzTLf0WgJraNfpOHI90QtJ AUpGABtWb+VCju+ppmY3qnPaeVJSGXEZWgGJjtvS2kjhI0CdFaxXVeO8WfxMdXu0O083FMzktEOBD 2igSL+2Ip/VePRvJbefu3oYsVHj0IsrPYtqYjHRvswZaJo4C8vcrhtTQm9cDGwWmPGKDPSBr+XCvH ck2Klztxpw8IOqxIweDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmxmK-000000003XB-3Jxy; Wed, 20 Mar 2024 15:22:56 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmxmH-000000003Ua-2GWn for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2024 15:22:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6647561027; Wed, 20 Mar 2024 15:22:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD0F8C433C7; Wed, 20 Mar 2024 15:22:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710948172; bh=TR0ElOCWlrACmeqJex852AV/Z/HsxEc3rXJRmzD19No=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NLoO2ZkSapH4wny76mCgRSWlVx3wBIzFZktsCZKFQzpOaAbIksSEyQa5wykCmHfg1 NUmYfH/wVqlBtmig2kLAaHjWCtUEXlkDcE+6bL8O0T2kL2ZJPtC5iIYasSzL9KUlKr BphAU/MVKoRKfI6cwq+BEkjk46HBIstlmX23wcIUqdjKlNw8o4xGWdPVf3yEx2rRhk gHRBEdIPuYN9FHSln22Fpbl90TIno1SnHA5bAnDBCptVno212SUPTpqlbVmGZr34m7 LNKzaIU80NImSbgF36KILGQ+UaRCAdy73Kcx1wPBuxcVxVEjiLpf1hIsycJ22OMxFn EVdznuK7ZWOBw== Date: Wed, 20 Mar 2024 15:22:46 +0000 From: Simon Horman To: Claus Hansen Ries Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "michal.simek@amd.com" , "wei.fang@nxp.com" , "yangyingliang@huawei.com" , "robh@kernel.org" , "harini.katakam@amd.com" , "dan.carpenter@linaro.org" , "u.kleine-koenig@pengutronix.de" , "wanghai38@huawei.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net v2] net: ll_temac: platform_get_resource replaced by wrong function Message-ID: <20240320152246.GU185808@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240320_082253_677478_FB07EC79 X-CRM114-Status: GOOD ( 14.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2024 at 02:19:15PM +0000, Claus Hansen Ries wrote: > From: Claus Hansen Ries > > Hope I am resubmitting this correctly, I've fixed the issues in > the original submission. For future reference, the text above probably belongs below the scissors ("---"). But I don't think there is a need to resubmit just because of that. > > platform_get_resource was replaced with devm_platform_ioremap_resource_byname > and is called using 0 as name. This eventually ends up in platform_get_resource_byname > in the call stack, where it causes a null pointer in strcmp. > > if (type == resource_type(r) && !strcmp(r->name, name)) > > It should have been replaced with devm_platform_ioremap_resource. > > Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()") > Signed-off-by: Claus Hansen Ries > Cc: stable@vger.kernel.org > --- > v2: > - fix accidently converting tabs to spaces and wording in commit message > v1: https://marc.info/?l=linux-netdev&m=171087828129633&w=2 Thanks, Reviewed-by: Simon Horman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel