From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ECFFC6FD1F for ; Wed, 20 Mar 2024 15:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wf3CrGWKGVQFcu9H8heufH2/V0NPLxw/iZKUM72Lmso=; b=oqNHM9lKV6dBd4 gUbbPjPiHdQYgB1upJQn4mNHjF+UXZeE5UOoDxglKAbwk5xhLoD16UN0BmN7o8SLSr+cNHr3U9YO/ 33Y5D6OnoXUoj4m+1Y0taNvhmlb2XFrJ8WYMXJ+YVwcsevLNXdPyXTow7ksSEKvR+OHqPSeREdlC/ j9NZIh6kN+lMJSw20ziPsplFf35bFaW/f35ltXPJk3wplr+boUo2I1HZJigCAb4cyDNhCXdXLE8Dg Ty8FiwkD/M5xS0JF7t7TI8hSr9Abio47P9cg+m7Y/hRDIJiCdM4UfnGJ5FUvm2f53ey/OwqO9ol6h wfVEJsJSem3mJnB5kvig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmy0b-0000000071Q-3kiS; Wed, 20 Mar 2024 15:37:41 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmy0Z-000000006zh-1sux for linux-arm-kernel@bombadil.infradead.org; Wed, 20 Mar 2024 15:37:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VFjrh1i3osg1ikMoa3lZzex2NZH1K4DKCsdJ69CPn8E=; b=g6YWi5gp+/2vRtWvhRIiKhm3PJ bJZzN1zTSn94SZH9hMY8ofM2qBGX1NzYbWb+9CLnkgNGlJl1k7pW7+Rsexj/mI6udaSP/XWM/42PV InjEmYcv8pUedo2IgGvorNNAJ+hbqcxwzX0Pd1TXutGZ1C7gE0DSEzyBTMvfUglMgGSoCvv3Ml6Zz oqHi/FcQrWqwHMS/VJtjdLalkKapDYgBSw97j+0SvqrQjt6M2UC4mpBoi4wROk6qthlmV1nvmiLyo IXsU6oFYm+WBGkdaefbXmcvagN/qR9jZqwwsuSQlQ+9AJcOGpjIB1m47CZZh1sQl9/1R3gBLbzzFB xwfJZU7Q==; Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmy0U-0000000Dn2z-3K9S for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2024 15:37:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3A5296100C; Wed, 20 Mar 2024 15:37:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2401C433C7; Wed, 20 Mar 2024 15:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710949047; bh=fmLM09aW3YMSQUrUIHkdieapEFOUqgns1Zezwr2fW5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=abSMw8WCvv/cRC1zXjoJEzMk+LxTZ7NCQqlpkGarPVeeMTqrG30+9LUHHk5+M4lqK Qgj2QSrZLK23wcbpLpb1A1T3vEBy08/EAgtQYDrAxLdigXL1dmZXfgr7NoZ2u3mUBy T6Mei1P5bZrRO8uk8K+ZMJ7jRnF6+o5mR6gkhyIUxcSCsBrKRGGRTiAWxJqidiLdo0 NQA/YDRHd9ccTWHBy4dLgp0LFWn/A3aA+BirQ0Oun8nL0vYn9nwL9JzAq1emPemesx AnTJd2KX/aZd5N2+dzNOmFd7EeRzhd/n1F3Qo8+JUjUT9/bP845TrqCFmJ1/vJTThR +5/QHr5JEJ1wQ== Date: Wed, 20 Mar 2024 10:37:25 -0500 From: Rob Herring To: Tomi Valkeinen Cc: Lars-Peter Clausen , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Conor Dooley , Michal Simek , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vishal Sagar , Anatoliy Klymenko , =?iso-8859-1?Q?P=E9ter?= Ujfalusi Subject: Re: [PATCH v2 2/4] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs Message-ID: <20240320153725.GA1771730-robh@kernel.org> References: <20240319-xilinx-dp-audio-v2-0-92d6d3a7ca7e@ideasonboard.com> <20240319-xilinx-dp-audio-v2-2-92d6d3a7ca7e@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240319-xilinx-dp-audio-v2-2-92d6d3a7ca7e@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240320_153735_200712_8ECD74E4 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 19, 2024 at 10:22:37AM +0200, Tomi Valkeinen wrote: > The DP subsystem for ZynqMP support audio via two channels, and the DP > DMA has dma-engines for those channels. For some reason the DT binding > has not specified those channels, even if the picture included in > xlnx,zynqmp-dpsub.yaml shows "2 x aud" DMAs. New required entries is an ABI change. This message kind of indicates it was a mistake, but should be a lot more explicit. Are things broken without the entries? Need 'Fixes'? > > Add the two audio DMAs to the binding. > > Signed-off-by: Tomi Valkeinen > --- > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml > index 554f9d5809d4..6b754d4f260e 100644 > --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml > +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml > @@ -100,12 +100,16 @@ properties: > - description: Video layer, plane 1 (U/V or U) > - description: Video layer, plane 2 (V) > - description: Graphics layer > + - description: Audio channel 0 > + - description: Audio channel 1 > dma-names: > items: > - const: vid0 > - const: vid1 > - const: vid2 > - const: gfx0 > + - const: aud0 > + - const: aud1 > > phys: > description: PHYs for the DP data lanes > @@ -194,11 +198,13 @@ examples: > power-domains = <&pd_dp>; > resets = <&reset ZYNQMP_RESET_DP>; > > - dma-names = "vid0", "vid1", "vid2", "gfx0"; > + dma-names = "vid0", "vid1", "vid2", "gfx0", "aud0", "aud1"; > dmas = <&xlnx_dpdma 0>, > <&xlnx_dpdma 1>, > <&xlnx_dpdma 2>, > - <&xlnx_dpdma 3>; > + <&xlnx_dpdma 3>, > + <&xlnx_dpdma 4>, > + <&xlnx_dpdma 5>; > > phys = <&psgtr 1 PHY_TYPE_DP 0 3>, > <&psgtr 0 PHY_TYPE_DP 1 3>; > > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel