From: Rob Herring <robh@kernel.org>
To: Manojkiran Eda <manojkiran.eda@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com,
ryan_chen@aspeedtech.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, conor+dt@kernel.org,
vigneshr@ti.com, richard@nod.at, openbmc@lists.ozlabs.org,
joel@jms.id.au, krzysztof.kozlowski+dt@linaro.org,
miquel.raynal@bootlin.com, jk@codeconstruct.com.au
Subject: Re: [PATCH v2 4/4] dt-bindings: aspeed: Add eSPI controller
Date: Wed, 20 Mar 2024 10:40:48 -0500 [thread overview]
Message-ID: <20240320154048.GA1777957-robh@kernel.org> (raw)
In-Reply-To: <a9faa9b4-9bf6-49b6-b7eb-f642e2d261c3@gmail.com>
On Wed, Mar 20, 2024 at 03:29:15PM +0530, Manojkiran Eda wrote:
> On 19/03/24 3:26 pm, Krzysztof Kozlowski wrote:
>
> On 19/03/2024 10:34, Manojkiran Eda wrote:
>
> This commit adds the device tree bindings for aspeed eSPI
> controller.
>
> Although aspeed eSPI hardware supports 4 different channels,
> this commit only adds the support for flash channel, the
> bindings for other channels could be upstreamed when the driver
> support for those are added.
>
> Signed-off-by: Manojkiran Eda [1]<manojkiran.eda@gmail.com>
> ---
> .../bindings/soc/aspeed/aspeed,espi.yaml | 94 +++++++++++++++++++
> 1 file changed, 94 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yam
> l
>
> diff --git a/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml b/Doc
> umentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml
> new file mode 100644
> index 000000000000..3d3ad528e3b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml
>
> Why Rob's comments got ignored?
>
> This is not a soc component.
>
> I did not mean to ignore, i have few reasons listed below that provides
> information on why i felt this belongs into soc.
Fix you email program to not send multi-part (txt plus html) emails.
Plain text only on maillists.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-03-20 15:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 9:34 [PATCH v2 0/4] Add eSPI device driver (flash channel) Manojkiran Eda
2024-03-19 9:34 ` [PATCH v2 1/4] " Manojkiran Eda
2024-03-19 9:49 ` Krzysztof Kozlowski
2024-03-19 9:34 ` [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall Manojkiran Eda
2024-03-19 9:51 ` Krzysztof Kozlowski
2024-03-19 9:53 ` Miquel Raynal
2024-03-19 9:34 ` [PATCH v2 3/4] ARM: dts: aspeed: Add eSPI node Manojkiran Eda
2024-03-19 9:50 ` Krzysztof Kozlowski
2024-03-19 9:34 ` [PATCH v2 4/4] dt-bindings: aspeed: Add eSPI controller Manojkiran Eda
2024-03-19 9:56 ` Krzysztof Kozlowski
[not found] ` <a9faa9b4-9bf6-49b6-b7eb-f642e2d261c3@gmail.com>
2024-03-20 14:44 ` Krzysztof Kozlowski
2024-03-28 11:33 ` Manojkiran Eda
2024-03-30 18:36 ` Krzysztof Kozlowski
2024-03-20 15:40 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320154048.GA1777957-robh@kernel.org \
--to=robh@kernel.org \
--cc=chiawei_wang@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manojkiran.eda@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick.rudolph@9elements.com \
--cc=richard@nod.at \
--cc=ryan_chen@aspeedtech.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).