From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 939D5C54E71 for ; Fri, 22 Mar 2024 09:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=By+fpvEm2vLwv3HqkXm+yxR8huXrLQqDHOHKk9Kpf4E=; b=ucPMTZp/koN+G4 YekFtCH+7rMVbFItrusbO0TYJOYkRs+uzjnjAcgIyFebIlZjz9HC+MuqXQ+c/cYjYEkkNPLyd20lr yBb8rlQrkN3p+g1KZnIQEXVupSvqsAHRdxDgXLh8K2/Ne7kOd7f1qDoyiPhKLdt3JHoqZGx2QggJQ 7HQS0sAE7CAES/3a/+AkTpxdok4Rbexffyfy749vdM0Umt3BLjWKVzC8VGKI/IzP6/jbkliF97NNb fzMUfet2KwMGGPFVKZnexqTt7bEnia3wOvGBgTfSw/9gXMa49Vk0MXjMviCCDZrP38Q38Rn7pcuG+ RrSGtQHDeCyp3AoPrwkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnbSx-00000006eYi-1dy9; Fri, 22 Mar 2024 09:45:35 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnbSu-00000006eXA-2Mh9 for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 09:45:33 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-56b8e4f38a2so2458114a12.3 for ; Fri, 22 Mar 2024 02:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711100730; x=1711705530; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=AlmUZX1oKnCqPJXsSuCW5CozYj1wJFSEFEeiu59yIp4=; b=MiNRv01zH/hOgt5ZPTD4QKhkxFVzi4tXZ3WREJs3VQBUJfy6JgaO7grlf7SKBvl3mF 1zCIMneHC6TFZO0fpbquovZ8vgKohE/l3v8ojJ+o1VeE10aU2SqWvLZ9IdRllqtxJsZb X0vXRfpGqXp9QmhZ021JksFU8Y3pUU0i0FZfhidNugY95g6ugwxi4gJuUzlKOGDXABhD /IPJsaqaxF6wIEEFSsCv9QchXdtRK14i0h2YLdKssYQ6fwDFduShxgv+bHZHJtIDqFbD 7Pebljiu0ctGRJ7hkAbX+ydJef685P2zH5G3mHyq87/167CouotGonC4rfhiSH0KufR2 oiEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711100730; x=1711705530; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AlmUZX1oKnCqPJXsSuCW5CozYj1wJFSEFEeiu59yIp4=; b=EekPx2t9lwVhaJJK5fHW3Weki29wOozwTefwlQYiJIpPhvrZbMRDf8HK/M2D2NbP4B tVjobsGlHD/rd93enIky+gCViHadgbiQosb4YiT+cMggymFoVvtNS6tA5jOGGzNlpQlg jotdIe0t7Arps5miHFXhLO7KRq7QlEJuTTh2ZVDz6SqBMWS867bd2YDv0bpEP9IitEFu HT+Kw8tEOGguxBxGbVQXETvBgeHE3WJ6nfY1ehijQkQY/IsFE6u2I8cQ7MMcWBbPfkc+ lp0zOcOkcU3sa3Lf1HGEBrnP/00lW8E7Ud4A8o77c0xpgvOnO6Y+rh+81o3cWQUhw+Bs MVXg== X-Forwarded-Encrypted: i=1; AJvYcCXLsD0jgvk2PsiL0544mfOyrRIJzgDj76lutbiK3MeYyZJMLNxvWiekiEYPIHI0j+8mTum8EmYH5wZwchSyl5cMi2HAnLC/ceY/hs0bNQjuy4bLDE0= X-Gm-Message-State: AOJu0YxbZWN8h4Bauz4X2TPbVwPsq/cyLF9briapCyR1NVj9c+RyTH9D 1Fpki/dXD3RXF++CFIvTp2A2lMZdHpTMQPIG7LIwgTh5l0vfrDpE X-Google-Smtp-Source: AGHT+IEMdPwXdULfmQN6UAn3oOA+aJ6y8GiAsPYU2u8TIUMJ7NjPC6DuAt/2jKqSVu/RE4c3YGQRhQ== X-Received: by 2002:a50:cd1c:0:b0:56b:6ec6:af2f with SMTP id z28-20020a50cd1c000000b0056b6ec6af2fmr1179534edi.6.1711100729462; Fri, 22 Mar 2024 02:45:29 -0700 (PDT) Received: from bhlegrsu.conti.de ([2a02:908:2525:6ea0::11c2]) by smtp.gmail.com with ESMTPSA id b9-20020aa7d489000000b00568ba57983csm839426edr.0.2024.03.22.02.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 02:45:29 -0700 (PDT) From: Wadim Mueller X-Google-Original-From: Wadim Mueller Date: Fri, 22 Mar 2024 10:45:26 +0100 To: Krzysztof Kozlowski Cc: Wadim Mueller , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Greg Kroah-Hartman , Jiri Slaby , Chester Lin , Andreas =?iso-8859-1?Q?F=E4rber?= , Matthias Brugger , NXP S32 Linux Team , Tim Harvey , Marco Felsch , Gregor Herburger , Marek Vasut , Joao Paulo Goncalves , Markus Niebel , Matthias Schiffer , Stefan Wahren , Bjorn Helgaas , Philippe Schenker , Yannic Moog , Li Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v3 3/4] dt-bindings: mmc: fsl-imx-esdhc: add NXP S32G3 support Message-ID: <20240322094526.GA7097@bhlegrsu.conti.de> References: <20240321154108.146223-1-wafgo01@gmail.com> <20240321154108.146223-4-wafgo01@gmail.com> <00174dc3-65a7-4a2e-b48d-a974336a3f18@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <00174dc3-65a7-4a2e-b48d-a974336a3f18@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_024532_629122_53AE986A X-CRM114-Status: GOOD ( 24.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 21, 2024 at 06:53:34PM +0100, Krzysztof Kozlowski wrote: > On 21/03/2024 16:41, Wadim Mueller wrote: > > Add a compatible string for the SDHC binding of NXP S32G3 platforms. Here > > we use "nxp,s32g2-usdhc" as fallback since the s32g2-usdhc > > driver works also on S32G3 platforms. > > > > Signed-off-by: Wadim Mueller > > --- > > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > index 82eb7a24c857..b42b4368fa4e 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > @@ -35,6 +35,7 @@ properties: > > - fsl,imx8mm-usdhc > > - fsl,imxrt1050-usdhc > > - nxp,s32g2-usdhc > > + - nxp,s32g3-usdhc > > - items: > > - const: fsl,imx50-esdhc > > - const: fsl,imx53-esdhc > > @@ -90,6 +91,9 @@ properties: > > - enum: > > - fsl,imxrt1170-usdhc > > - const: fsl,imxrt1050-usdhc > > + - items: > > + - const: nxp,s32g3-usdhc > > + - const: nxp,s32g2-usdhc > > No, that's just wrong. G3 is not and is compatible with G2? There is no > dualism here. Either it is or it is not. Not both. > I am trying to understand your statement but I am not sure whether I get it right. Let me try to explain what I understand is wrong with this patch. Having nxp,s32g2-usdhc and nxp,s32g2-usdhc in one enum > > - nxp,s32g2-usdhc > > + - nxp,s32g3-usdhc would mean that those are __not__ compatible with each other, whereas the anouther item > > + - items: > > + - const: nxp,s32g3-usdhc > > + - const: nxp,s32g2-usdhc > where both const entries are side by side means that those are compatible. Which is paradox. Is this undersanding correct? So if I want to have the follwing im my DTS for the mmc node usdhc0: mmc@402f0000 { compatible = "nxp,s32g3-usdhc", "nxp,s32g2-usdhc"; ... } The schema update should contain just this part? i@@ -90,6 +90,9 @@ properties: - enum: - fsl,imxrt1170-usdhc - const: fsl,imxrt1050-usdhc + - items: + - const: nxp,s32g3-usdhc + - const: nxp,s32g2-usdhc reg: maxItems: 1 Is this correct? With this patch in place I dont see any issues with an "make CHECK_DTBS=y freescale/s32g399a-rdb3.dtb" as well as "make dt_binding_check dtbs_check" seems to be OK with this. Thanks for your guidence so far, much appreciated! Best Regard Wadim > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel