From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADD5EC54E71 for ; Fri, 22 Mar 2024 13:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2dj5lqtrZcxhuQpHyO6wBHp5TVarSepOGBnll+sET9w=; b=vDRFQ/akfPWjLH vccyQLHhxGqYjXQDeTBM7IyUDXeu4eBTidQKEKAyaJ0rgoqbyW4ayELm5Ct0wkApkHElvkUR3yqTP oIzIP49sxbKB5s3P3N+n5i61YfxhSg6YqglDpIeUtKOrmJZ49yQ1ZgSpkIda8T5ehWf5vv5QfAMa2 1KIKuXsxAANru75NWIq+Fyw5kCCO5XIRRmUnEL4ahZSt4KUkbI9pRZkRSWpcbM1Ew0lT2GLJs9pYN 8xIywkWyPMi5tA463GWSPjinLzSP/D52ZWuZpF5fB6hqqVxnTXXaB3gw2nClpReEvn0cI0VuU/kh7 xh8MfSv0Hms5SjdJqcNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnept-00000007Gpv-3Jpm; Fri, 22 Mar 2024 13:21:29 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnepq-00000007Gou-2r0u; Fri, 22 Mar 2024 13:21:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 83333CE1802; Fri, 22 Mar 2024 13:21:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38A03C433A6; Fri, 22 Mar 2024 13:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711113683; bh=jvyFcumM0Kgc3cvxmljqPEI3TA1ssaHzM5qXST5wFWU=; h=From:To:Cc:Subject:Date:From; b=SDIyjHHYzIzkM1ZxDVfDOZHT6vMxkUjSs4aE6DL1byMVyt+l9ZVvb56So8nucENaA PCTY15jtxyqPU6g5mgcvJGodAaiN+2fOjHh323i4WnkcJkBsEV7ZC+KNr/G5+U6gr5 c/FOW+tZPpXXMPrqOUxDHc3ybQ5pLQ5aGCdcdy0dvN5QZ6nRoofp06wb1IYr6jiipF GujyavHdDLOPUjAzrNCI02AHdLyLHyWi1QCxjRwFk+JlV+HksHB8XD4P3jGVvbyfyh ST7nvBUKQx3qFnH9hi60KK2k9/3JqR9RGfdsP246vhWM45efhlJ97d+YyR9QN50rBo naQOrMhliewpQ== From: Arnd Bergmann To: Vinod Koul , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Manivannan Sadhasivam , Nathan Chancellor Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Randy Dunlap , Rob Herring , Zhang Jianhua , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH] dmaengine: owl: fix register access functions Date: Fri, 22 Mar 2024 14:21:07 +0100 Message-Id: <20240322132116.906475-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_062127_158724_99E2D52A X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann When building with 'make W=1', clang notices that the computed register values are never actually written back but instead the wrong variable is set: drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] 244 | u32 regval; | ^ drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] 268 | u32 regval; | ^ Change these to what was most likely intended. Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver") Signed-off-by: Arnd Bergmann --- drivers/dma/owl-dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c index 4e76c4ec2d39..e001f4f7aa64 100644 --- a/drivers/dma/owl-dma.c +++ b/drivers/dma/owl-dma.c @@ -250,7 +250,7 @@ static void pchan_update(struct owl_dma_pchan *pchan, u32 reg, else regval &= ~val; - writel(val, pchan->base + reg); + writel(regval, pchan->base + reg); } static void pchan_writel(struct owl_dma_pchan *pchan, u32 reg, u32 data) @@ -274,7 +274,7 @@ static void dma_update(struct owl_dma *od, u32 reg, u32 val, bool state) else regval &= ~val; - writel(val, od->base + reg); + writel(regval, od->base + reg); } static void dma_writel(struct owl_dma *od, u32 reg, u32 data) -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel