From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA5D3C54E58 for ; Mon, 25 Mar 2024 14:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GC4npDo9DJutMAUyHcZ+1mgGCBC8wA6165tiYcFb7A4=; b=yRJ8tU0HmwCCip obeNwPwPooy8BRUCnNtSDm9T1sYklPJyDS6TPDtlqucJpgTJRCd2LQ0eYBkT6twRknyS2jYXQyZmf CEZYTf2Q1A4SFl42DQcwQPc1St1b5T+AeS/0UAgkNd/Rzq9xH8AJ9/00p5B5CFia/KVMydNpjVytm QS/F7tA737lfw9gr62nFZDst/KCQUsSX+LTnr8Rp0ZEmHUnwZ70RCmvCbkUJ4D1kTpOmRMJJJmGgE /nstjACuVjd2ChGnRNRc8/aBb1BBpgfWxq6F61n2kJvpv9DRGGtZeDUE/fGp2uLPS9ZnFP9GwoYNF H/G3XBhKOwC0pmUwAdMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rolC5-00000000Bqf-283a; Mon, 25 Mar 2024 14:20:57 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rolBu-00000000BnW-0khG for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2024 14:20:47 +0000 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-788598094c4so214465885a.0 for ; Mon, 25 Mar 2024 07:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1711376441; x=1711981241; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o4khMi8YsL4x6qQRj8U1+7HQEKktCZ8TqyaiPDmkbrE=; b=CS0Q8TeG1pQAs46ZkzkP1qTRAqJGmsz5OYRexSMJm/sI1pGwex3wsOsuo/Z9XeVusP Gwd/yEFYkVpPRORmkFJWP0Ryw4TKgbbcyv2zfMSYwF02DhHP/Z3xS+X9OzjPojXBO/8Z KfdJPh1lsO/srRrU62VvODTZwVomFGN2eqoauvcb2dD6FC0fTFIzw7YLQMqrSQB2Q3ez U1RtMvVtdxU/nPgrRaivhll5zvi8NBz96QIacgq7NeKXHaZtqZNJP4K///P/f9E/pfja w5tyPq7tGDx6axyJ4ba28yq82MgRKFiPawyY7jze8CvAI7ocOiosGKY+q3SGD7ov8FND srPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711376441; x=1711981241; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o4khMi8YsL4x6qQRj8U1+7HQEKktCZ8TqyaiPDmkbrE=; b=vL0vAfyR1uJHyy19p5IIjUb5OaxEdb5RGERU/qqa9IkSHnQhRhte0hpXLoNVrIkJeG GBPen2okbnlwWfhDZkx7iqa2dIwYPpoHhTEkQSw8RDhqpyYMlmBX5qCockwHDR0NrRtH B80tB/ZYNPe1+aEfdZ0joT5xCI4dIR6MxGDRxL+1YxuJ+12ovFE968FLyrbCc5Afbaiw 1MljfCz9zSdlxyVmqymEh94RhXfY1UCSZXK+v8hdvjydgzzyvvf3LeNvMC8Smok72WUD +7SX1+3VqYWrLVg2y8Ptj8jKiSPZzMvnhkQ1kFuOrII3MZln11I99aZ5Vc67XQcmo+UR h4Lw== X-Forwarded-Encrypted: i=1; AJvYcCWmsBcYxGgEjDHPF9ekAQiEvyGfP2YqRSPNozmotTgHjeEg1oBp72lsma7fKdmiWX2Cl6aBASc6NNSIlzrZ4/XywyXe9JiQgnfsFfdW3o2kTq8l0Kc= X-Gm-Message-State: AOJu0YyxeAixZsH1MjnFzLp8tW/CM78SVJLbkxVgEQX5Ye+JLKsG+fyy FMviWsFNhF9/0Ihv6XDqpjJfZRG6R2mp762kpoyVyiHtrxk1C9wCSdE33HWaApRvwfIlaKYQAsG + X-Google-Smtp-Source: AGHT+IEIDvH4aJX0QxV4yhRacQicWFP/ioH96fdSaZc4HTl73ipKGoKLrbARimpUoqXo7Z7Mj3Cjjg== X-Received: by 2002:ae9:e64a:0:b0:789:e917:ac8d with SMTP id x10-20020ae9e64a000000b00789e917ac8dmr12632qkl.71.1711376440895; Mon, 25 Mar 2024 07:20:40 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id ou8-20020a05620a620800b007882e204d45sm2170804qkn.37.2024.03.25.07.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 07:20:40 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1rokgy-000ME6-0a; Mon, 25 Mar 2024 10:48:48 -0300 Date: Mon, 25 Mar 2024 10:48:48 -0300 From: Jason Gunthorpe To: "Peng Fan (OSS)" Cc: Will Deacon , Robin Murphy , Joerg Roedel , Thomas Gleixner , Marc Zyngier , Bixuan Cui , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 3/3] iommu/arm-smmu-v3: support suspend/resume Message-ID: <20240325134848.GA8419@ziepe.ca> References: <20240324-smmu-v3-v1-0-11bc96e156a5@nxp.com> <20240324-smmu-v3-v1-3-11bc96e156a5@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240324-smmu-v3-v1-3-11bc96e156a5@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_072046_408712_2E36D54D X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 24, 2024 at 08:29:00PM +0800, Peng Fan (OSS) wrote: > +static void arm_smmu_resume_unique_irqs(struct arm_smmu_device *smmu) > +{ > + struct device *dev = smmu->dev; > + struct msi_desc *desc; > + struct msi_msg msg; > + > + if (!dev->msi.domain) > + return; > + > + desc = irq_get_msi_desc(smmu->evtq.q.irq); > + if (desc) { > + get_cached_msi_msg(smmu->evtq.q.irq, &msg); > + arm_smmu_write_msi_msg(desc, &msg); > + } > + > + desc = irq_get_msi_desc(smmu->gerr_irq); > + if (desc) { > + get_cached_msi_msg(smmu->gerr_irq, &msg); > + arm_smmu_write_msi_msg(desc, &msg); > + } > + > + if (smmu->features & ARM_SMMU_FEAT_PRI) { > + desc = irq_get_msi_desc(smmu->priq.q.irq); > + if (desc) { > + get_cached_msi_msg(smmu->priq.q.irq, &msg); > + arm_smmu_write_msi_msg(desc, &msg); > + } > + } > +} I wonder if this should be done instead by converting the driver away from platform MSI to the new MSI mechanism? Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel