From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDC1BC54E58 for ; Mon, 25 Mar 2024 16:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bpcZdLlWGf+eVhT/E9iPykyDrrlsCSTgL6uz0nYrTJg=; b=p2e9CWJ+YHuJfC ulKL+kAUgTpeuA77NuPFRiEdzhMI7sUMaqM8xk/fhU4d7Iyb8o7aUAOzCgbARKYE94+Dg+gb+oFbR ev79e3H7tMUZePWC0Dbc1Xku9BYIcxk7/VPHFP6G8ZDs2k+47cex+Zu/OUIaYpJ7ZuuAynzAMGgnh xcAUPo6O0UiKRlcsUsSAXExawIagSL1FR4GzZrWRsYJl8BUaC/7sNDUG0nl9+zQt2qtT/0STvI8d4 PDGP2I8TT4ByFAFYpJwSiTdGBcUvEi0f4id2pI896Yfu+LY+fU+zUjCqhQMheZHv5DDvmP1m3VnTL wPAisxDpgSLcSntw6d8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rommT-00000000e6k-47oS; Mon, 25 Mar 2024 16:02:38 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rommR-00000000e5n-0WX5 for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2024 16:02:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6075461138; Mon, 25 Mar 2024 16:02:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC5EFC433C7; Mon, 25 Mar 2024 16:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711382554; bh=JJbCkZzEeycIyoj0urV1Upiq1UUSkSdddBASm4fPN0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZTvTGA1E9BKCJpr3ZAlylSmsQXO03Fx0lP70d90iIXHmNw0NaNlJfaf+U1o/ATU5Q 66xMybd1UghWaAftZYlXsGWehYRqWNsV5pcHmv7YgUvhgxH5U492A4CH4fXpYGEHC9 fsLRL3Vdxv+LVpD3W+oKpLBTYKAdB/yrxpkWDpqi+3JUHVgw0zTKRqE6cDBwgRzYKc ARHP7Gq40d1KFtR35r/PVGg4OmPAgIAwB8A55OY9bYbWz9E2xl8OxJEvX/FdA6JrTe iKKNwU8LNkQhBgKpDy3hL8E50ii6DsoyFijxFx6vHhVCwJHIx5hWe5XoADfw3h/cK+ CVxNKg6qquCLw== Date: Mon, 25 Mar 2024 11:02:31 -0500 From: Rob Herring To: Javier Carrasco Cc: Alexandre Belloni , Krzysztof Kozlowski , Conor Dooley , Baruch Siach , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert to dtschema Message-ID: <20240325160231.GB4035876-robh@kernel.org> References: <20240323-rtc-yaml-v1-0-0c5d12b1b89d@gmail.com> <20240323-rtc-yaml-v1-1-0c5d12b1b89d@gmail.com> <20240323233742bfb9ba4a@mail.local> <6e68e0ca-2f3e-41a7-bb96-00fbdadc4436@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6e68e0ca-2f3e-41a7-bb96-00fbdadc4436@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_090235_234800_D3713C41 X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 24, 2024 at 01:02:31AM +0100, Javier Carrasco wrote: > On 3/24/24 00:37, Alexandre Belloni wrote: > > On 23/03/2024 23:46:13+0100, Javier Carrasco wrote: > >> Convert existing binding to dtschema to support validation. > >> > >> +required: > >> + - compatible > >> + - reg > >> + - reg-names > >> + - interrupts > >> + > >> +additionalProperties: false > > > > This is not correct because at least start-year is supported. Please > > check for all your other submissions too. > > > > allOf: > - $ref: rtc.yaml# > > is missing, and then > > unvealuatedProperties: false > > to account for that. > > "start-year" is read in the RTC base class, so I wonder why so many RTC > bindings add a reference to rtc.yaml, but then use > > additionalProperties: false They may have pre-dated support for 'unevaluatedProperties', or you can list out which properties are used from a referenced schema which disallows unlisted properties. There's no hard rule here. Either way is fine. Other than this and my 1 other comment, this series looks fine to me. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel