From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6263C6FD1F for ; Tue, 26 Mar 2024 17:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=goiOVPmOICvsgPrIHATG0YUF0YrYBdG6527ZCLvVTTo=; b=XVwDDZUK3unNYD d0zMoSGzlQG72G1N1Nxpo9RIYlZGDPGq+6c75Uz7xe0mmSvhx+G7xJs7cL+k/xqe3CYRB+cNyrRnq JOoKS+x43nRhsrDuKVxV2ab1Z25VFU62yZ73CaslhBfV/5DxUxesuVZ4IBoA4QqJq2bzg9jFjRQNV 3GWo+Szf/iGXBe8BktjGW5Xrk7qp73EaAlZEHnVaKPCJsXUZALr45MogOKbcLvNVkyQ+T9q6NZJq0 Fo4VVsNzBKb+xSmON+54WPrFiqPGjfSJ8Kwj4JAe4PfNwiyG+qCw7G4OjSvZDFX4MrPS+CMn8Msd9 N9pbXhF0z0/zY2vOIRhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpAbG-00000005jF4-0xmf; Tue, 26 Mar 2024 17:28:39 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpAb0-00000005j51-2WCz; Tue, 26 Mar 2024 17:28:26 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7031863B; Tue, 26 Mar 2024 18:27:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1711474069; bh=ng7QZtf1ABTqWg4hcmsUuvCxVtSHM+IA9YtVMluYCg4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g/iGNIkwk72HVci7+FUjHRrHzGnWwelu4POV8SHwuuyrtZsCzWg2DjAkewB/CO06O L/xAgyXrL5KfxEM/KjIj2SyZGuwEFrANTSKCT5Rx2duwidk5IGTEYuC8GdI9wOtu4w ARypB+6VaNc8IoqJrvIFeSkytk/mpCb9jyxYN7to= Date: Tue, 26 Mar 2024 19:28:12 +0200 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Linus Walleij , Bartosz Golaszewski , Eric Anholt , Stefan Wahren Subject: Re: [PATCH 2/2] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Add gpio child node Message-ID: <20240326172812.GC28895@pendragon.ideasonboard.com> References: <20240326004902.17054-1-laurent.pinchart@ideasonboard.com> <20240326004902.17054-3-laurent.pinchart@ideasonboard.com> <8f4ef49a-74a1-4e05-a2fa-f6bc29e80c5c@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8f4ef49a-74a1-4e05-a2fa-f6bc29e80c5c@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_102823_181914_C6518EAD X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 08:09:46AM +0100, Krzysztof Kozlowski wrote: > On 26/03/2024 01:49, Laurent Pinchart wrote: > > Unlike the other child nodes of the raspberrypi,bcm2835-firmware device, > > the gpio child is documented in a legacy text-based binding in > > gpio/raspberrypi,firmware-gpio.txt. This causes DT validation failures: > > > + type: object > > + additionalProperties: false > > + > > + properties: > > + compatible: > > + const: raspberrypi,firmware-gpio > > + > > + gpio-controller: true > > + > > + "#gpio-cells": > > + const: 2 > > + description: > > + The first cell is the pin number, and the second cell is used to > > + specify the gpio polarity (GPIO_ACTIVE_HIGH or GPIO_ACTIVE_LOW). > > + > > + gpio-line-names: true > > You could provide here maxItems, if this is known, but it's fine as is > as well. The number of items seems to be always 8, so I'll use that value. > Reviewed-by: Krzysztof Kozlowski -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel