Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

Krzysztof Kozlowski
2024-03-26T12:01:44Z

On 26/03/2024 10:11, Laurent Pinchart wrote:
> Hi Krzysztof,
>
> On Tue, Mar 26, 2024 at 08:12:45AM +0100, Krzysztof Kozlowski wrote:
>> On 25/03/2024 21:32, Laurent Pinchart wrote:
>>> The Maivin board is an AI vision starter kit sold by Au-Zone
>>> Technologies, developed in collaboration with Toradex and Vision
>>> Components. It is based on a Toradex Verdin i.MX8MP SoM.
>>>
>>> Add a device tree that covers the base set the peripherals found on the
>>> board:
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching.
>> And drop redundant parts.
>> arm64: dts: imx8mp-maivin: Add Au-Zone Maivin Starter Kit board
>
> Including in the command line the name of the dts that is being added
> doesn't seem to be a very common practice. See for instance
>
> 6d382d51d979 arm64: dts: freescale: Add SKOV IMX8MP CPU revB board
>
> I can use
>
> arm64: dts: freescale Add Au-Zone Maivin Starter Kit
>
> if you prefer.

It's also fine (plus missing : after freescale).

Best regards,
Krzysztof