Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

Laurent Pinchart
2024-04-03T07:35:55Z

On Wed, Apr 03, 2024 at 09:06:51AM +0200, Francesco Dolcini wrote:
> Hello Laurent,
>
> On Wed, Apr 03, 2024 at 08:30:11AM +0800, Shawn Guo wrote:
> > On Mon, Mar 25, 2024 at 10:32:45PM +0200, Laurent Pinchart wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> > > new file mode 100644
> > > index 000000000000..2d1c8e782465
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> > > @@ -0,0 +1,236 @@
>
> [...]
>
> > > +/* Verdin I2C_2_DSI */
> > > +&i2c2 {
> > > + status = "okay";
> > > +
> > > + clock-frequency = <400000>;
> > > + scl-gpios = <&gpio5 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> > > + sda-gpios = <&gpio5 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> >
> > We usually end property list with 'status'.
>
> This is now a written and explicit guideline, no longer tribal knowledge,
> see https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node

Thanks.

Any chance to teach checkpatch.pl (and/or the DT checker) about that ? :-)

--
Regards,

Laurent Pinchart