Re: [PATCH 2/5] iio: dac: ti-dac5571: Add DAC081C081 support

Sean Nyekjaer
2024-03-26T09:01:37Z

> On 25 Mar 2024, at 21.32, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>
> The DAC081C081 is a TI DAC whose software interface is compatible with
> the DAC5571. It is the 8-bit version of the DAC121C081, already
> supported by the DAC5571 driver. Extends the driver to support this
> chip.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sean Nyekjaer <sean@geanix.com <mailto:sean@geanix.com>>
> ---
> drivers/iio/dac/ti-dac5571.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
> index efb1269a77c1..c5162b72951a 100644
> --- a/drivers/iio/dac/ti-dac5571.c
> +++ b/drivers/iio/dac/ti-dac5571.c
> @@ -13,6 +13,7 @@
> * https://www.ti.com/lit/ds/symlink/dac5573.pdf
> * https://www.ti.com/lit/ds/symlink/dac6573.pdf
> * https://www.ti.com/lit/ds/symlink/dac7573.pdf
> + * https://www.ti.com/lit/ds/symlink/dac081c081.pdf
> * https://www.ti.com/lit/ds/symlink/dac121c081.pdf
> */
>
> @@ -386,6 +387,7 @@ static void dac5571_remove(struct i2c_client *i2c)
> }
>
> static const struct of_device_id dac5571_of_id[] = {
> + {.compatible = "ti,dac081c081", .data = &dac5571_spec[single_8bit] },
> {.compatible = "ti,dac121c081", .data = &dac5571_spec[single_12bit] },
> {.compatible = "ti,dac5571", .data = &dac5571_spec[single_8bit] },
> {.compatible = "ti,dac6571", .data = &dac5571_spec[single_10bit] },
> @@ -401,6 +403,7 @@ static const struct of_device_id dac5571_of_id[] = {
> MODULE_DEVICE_TABLE(of, dac5571_of_id);
>
> static const struct i2c_device_id dac5571_id[] = {
> + {"dac081c081", (kernel_ulong_t)&dac5571_spec[single_8bit] },
> {"dac121c081", (kernel_ulong_t)&dac5571_spec[single_12bit] },
> {"dac5571", (kernel_ulong_t)&dac5571_spec[single_8bit] },
> {"dac6571", (kernel_ulong_t)&dac5571_spec[single_10bit] },
> --
> Regards,
>
> Laurent Pinchart