From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B0ABC6FD1F for ; Tue, 26 Mar 2024 20:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R5AXgrn/CBH6VfGvXyOFCbwfQkMu9xSE0uMvVj6zMnM=; b=fXbU+jBqTqvQUl Lu5cAolQc1jZLzPZx+sbFAk/FpmHRriKuoQ12E3h7DM0Dui7oDZATO9mM2S1tR9f5qQUHXbOyvznV KouMBt3jgvdfv3ygiUrIBuzynIjWii6gmEs6nxFkWZH6Ilv+wakhYibwopVpdhCaC9uuxl1V8xM4y qU5tqe3UTNLPkpl8fu2Nh1oBETMN0u9ElkWdOMlKBXsydgzotwZXvR1CGsZ7C1gXg1Tl4+BbgeMm3 YiwwGZGUcLnZH/DmM+d63flBz7qhWMljy0n5r60XuT3SXBSp4Is9+HkOpeM59w7PRz9x0J/oZbAtF HLjmvHXiLFZw/CSUIBFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpDIR-00000006JLM-14SD; Tue, 26 Mar 2024 20:21:23 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpDIP-00000006JLD-11Ip for linux-arm-kernel@bombadil.infradead.org; Tue, 26 Mar 2024 20:21:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FdHAjC/7les37YnkMTaQnJcFGPt0pYqC/e6SnuxXsSE=; b=BCwHXqZgd7cSaLTRPjNhUQv+4w P50syzJ6eiG8tdbE1hEbnuaN1gp5CSeYOelISJv/jQaDyZMplW3NtYw7m/GEXY9eB0ruxq+eEav+P rVyLlwkwX+nsJ9qmQxqoOoKD30jchEo0ShAPUreqilEhlRPvkiB8yr8C7qiPu+4eMaYxN0Bni1GN0 zY446kNEKlh3RZuFGZXVSU+f2Wa+c9y5R1LSpyHGXdvWzJYTz9RZKlpcmmkbEoPPMryuzc/6sA9Qf 0Y8Lt5jvcTl0av9seV6VVhPRjxbSYhPGpN1Fu9tYcVK3xtxB1zttYHqdRtmiEScNdNTVysFhUh+q6 Et2k/OSA==; Received: from lelv0142.ext.ti.com ([198.47.23.249]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpDIK-0000000HPfC-3zuZ for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 20:21:19 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 42QKL5ix059927; Tue, 26 Mar 2024 15:21:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1711484465; bh=FdHAjC/7les37YnkMTaQnJcFGPt0pYqC/e6SnuxXsSE=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=QR9hfHKMbQNi1QYVrr44ZP6S87lmhGk/WN1dCoWOrpsdhU/3QY6XS7XSR1L06jq0H n6CIAPr3yfUGSiy1S6Uooi4brB21tyD0+wQENKZ7y+kX4mRfoFwXInSWATKRcM6abn xCi6+9kUDCH+W3GHtnQwtzRtCJ7NF7tPpG+mxqfU= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 42QKL5HV057504 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 Mar 2024 15:21:05 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 26 Mar 2024 15:21:05 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 26 Mar 2024 15:21:05 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 42QKL5cf002062; Tue, 26 Mar 2024 15:21:05 -0500 Date: Tue, 26 Mar 2024 15:21:05 -0500 From: Nishanth Menon To: Andrew Davis CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , Subject: Re: [PATCH 1/6] arm64: dts: ti: k3-am65: Remove UART baud rate selection Message-ID: <20240326202105.duim7cooxk4dwlz2@makeshift> References: <20240326185441.29656-1-afd@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240326185441.29656-1-afd@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_202117_751202_B65FC764 X-CRM114-Status: GOOD ( 24.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13:54-20240326, Andrew Davis wrote: > As described in the binding document for the "current-speed" property: > > "This should only be present in case a driver has no chance to know the > baud rate of the slave device." > > This is not the case for the UART used in K3 devices, the current > baud-rate can be calculated from the registers. Having this property I do not understand the explanation above -> how does one do this? If you are talking of the 8250 divider registers, someone has to program those - how do you compute the baud rate from registers that aren't programmed? Note: I am not commenting on the rationale of removing the property, just trying to understand the assertion above. > has the effect of actually skipping the baud-rate setup in some drivers > as it assumes it will already be set to this rate, which may not always > be the case. > > It seems this property's purpose was mistaken as selecting the desired > baud-rate, which it does not. It would have been wrong to select that > here anyway as DT is not the place for configuration, especially when > there are already more standard ways to set serial baud-rates. > > Signed-off-by: Andrew Davis > --- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 - > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 1 - > arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index ff857117d7193..670557c89f756 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -89,7 +89,6 @@ main_uart0: serial@2800000 { > reg = <0x00 0x02800000 0x00 0x100>; > interrupts = ; > clock-frequency = <48000000>; > - current-speed = <115200>; > power-domains = <&k3_pds 146 TI_SCI_PD_EXCLUSIVE>; > status = "disabled"; > }; > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > index 6ff3ccc39fb44..4f808e5089755 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > @@ -43,7 +43,6 @@ mcu_uart0: serial@40a00000 { > reg = <0x00 0x40a00000 0x00 0x100>; > interrupts = ; > clock-frequency = <96000000>; > - current-speed = <115200>; > power-domains = <&k3_pds 149 TI_SCI_PD_EXCLUSIVE>; > status = "disabled"; > }; > diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi > index 37527890ddeaf..eee072e44a42f 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi > @@ -59,7 +59,6 @@ wkup_uart0: serial@42300000 { > reg = <0x42300000 0x100>; > interrupts = ; > clock-frequency = <48000000>; > - current-speed = <115200>; > power-domains = <&k3_pds 150 TI_SCI_PD_EXCLUSIVE>; > status = "disabled"; > }; > -- > 2.39.2 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel