From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA469CD11DF for ; Tue, 26 Mar 2024 23:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=YMx21+3TCTllVuz8zkObmVbFg3/lNJHlOn2Sx9iZVZ8=; b=z6bewCAS5MbTIY 5bq35i/+ltinPTNW9HKhVOjXYyI7M0qABqzUMh6OeC4qBRLQk1II20KxZD0M3N1zv8l1aCqXx81EU dM8n73m/Rg+6E0yT23h10J2JUGc1rQLL1cbtipZnyPbWzsr8cNAiFcMqQwkKI++QGMVwLJS7yocFE NQ+ESICwnktWYZnYLBV1IFQEjW9lxvmszfpPYg/QHOT1lF0rKl3U0C4Q+ahahTasDdujFsV8MqL1g zeRd7kzMn2vSpbiIA2DowwRGDml131zgR13Djyd+Fy9ZKKyr7RFMWkq3xK2LnrrWXJvlaGy2uptk7 XVE5u32KWzz7TWl2WRDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpG9K-00000006rGa-2cqX; Tue, 26 Mar 2024 23:24:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpG9H-00000006rFo-37rB for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 23:24:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1F009612EC; Tue, 26 Mar 2024 23:24:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BC29C433F1; Tue, 26 Mar 2024 23:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711495445; bh=GfgyZrV79xoa84Cgd+HTjsbRJ75ZS8ByhFEX2qPLfk4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=XfbA6njiMzYq8iAN1Mgu+0B23d79KPXLQzGCVdXjI1PveafCTUxoAUOTJhtSAP9Sn uEQpq755ssawAlDuwSCwvAFE88XmZ2d3ZPOaYMrmi+6fu36PMFSPMVvI5sbcSDJW+w dWt5pBPwG1DzwPTX+/USomfTjSqJ3SGYID74cxHNBNXndrDq+qZWPehPCby/dXjrgl /Kjf3BOdZRZyKNZHVqOPzEip9SFSNzFh69L3eqOjg61Hg3w0RQZCcBfyeSD0dh02aZ hsY2k3iw7K1xwysm+CWP/jN1xWnxV5peX6uIqWddYeqm3dJrChQJNoqL8ZYSBwHNMd z1gKpfRp/xBfA== Date: Tue, 26 Mar 2024 18:24:03 -0500 From: Bjorn Helgaas To: Siddharth Vadapalli Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, manivannan.sadhasivam@linaro.org, fancer.lancer@gmail.com, u.kleine-koenig@pengutronix.de, cassel@kernel.org, dlemoal@kernel.org, yoshihiro.shimoda.uh@renesas.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com Subject: Re: [PATCH v6] PCI: keystone: Fix pci_ops for AM654x SoC Message-ID: <20240326232403.GA1502764@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240326144258.2404433-1-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_162407_860364_E0185D2C X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 08:12:58PM +0530, Siddharth Vadapalli wrote: > In the process of converting .scan_bus() callbacks to .add_bus(), the > ks_pcie_v3_65_scan_bus() function was changed to ks_pcie_v3_65_add_bus(). > The .scan_bus() method belonged to ks_pcie_host_ops which was specific > to controller version 3.65a, while the .add_bus() method had been added > to ks_pcie_ops which is shared between the controller versions 3.65a and > 4.90a. Neither the older ks_pcie_v3_65_scan_bus() method, nor the newer > ks_pcie_v3_65_add_bus() method is applicable to the controller version > 4.90a which is present in AM654x SoCs. > > Thus, as a fix, move the contents of "ks_pcie_v3_65_add_bus()" to the > .msi_init callback "ks_pcie_msi_host_init()" which is specific to the > 3.65a controller. Also, move the definitions of ks_pcie_set_dbi_mode() > and ks_pcie_clear_dbi_mode() above ks_pcie_msi_host_init() in order to > avoid forward declaration. If it's possible to split this into two patches (one that strictly *moves* the code without otherwise changing it, and another that makes the actual fix), it would be easier to review the fix. It's a pain to have to compare the code in the old location with that in the new location. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel