From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11708CD11DD for ; Wed, 27 Mar 2024 00:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u0NNjaG6iIP7CvXXqCDx1RuwXeSosXk09MWkFpQmbcg=; b=DElmNBAhMx1+BH EQ3tdRenQyZuZIiESoi9DmqmT8pXMtM6j0S5rIzs7tM6rEqheW50ZDC+nfFr4j64ZeaeDLpZvDUnH GB7pBHaCeKr6dblEu5Wo42OCy8SADHz0V0oZsNMQkuimg65Xld6LUSLSPGaZKhuiQv/eM5oENxa6v NemnRF0TwTDn9pLBYNCIGtc9THpM9ttMjMYcgSzhNW8Ohw4GvwSuRF8R6OhW8ylXWIWQjgyWlPefZ f1nZQOglTfUUCj9f/8mjdCk0p8yFoJbSuPjJ9IE5K5UywVkt4rwmT/pkbQMB+vdpizqHk8bGqdmrG PsROqogG0bYhOn38NzYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpGk9-00000006voC-4AuY; Wed, 27 Mar 2024 00:02:14 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpGk5-00000006vm6-3UsX for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 00:02:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4296FCE249A; Wed, 27 Mar 2024 00:02:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58D00C433C7; Wed, 27 Mar 2024 00:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711497722; bh=h1ujNBBy/aBs5SW6I/JPn+LTBRALB6UclagN9KkHVDc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eqfqpiE/HKWvyIVb/EgbcC1g5iAtm+HLjwRUgFHbs9U8rp3c2WSUqHye2xfVRf0+B Uxy5b+pmom73QwIRXGHUJXlxr7nhOPrIynCmtY9qHHAhBT3CH2XXAqx1sw8vOW9qRJ FnxEyMBCI3smmROycLHUN1C9te9Jz+fidz1Z0Uxy/R6hDm+kXt4NXiZYcA5/QAx7oN 4Yj2UKDllfUz1IAMl7ChOAxv42I9cg+2rkWEmW2otQqwZuQdQiCS/suP+zGxjEml/Y uwEAOgEwHNqZNp3eXg5Lr9vMXJZLr3eDy3BRYEoxHXOZyTWAuY2rBicwz3rHvguSVg 17Xl6Xy699tGA== Date: Wed, 27 Mar 2024 09:01:55 +0900 From: Masami Hiramatsu (Google) To: Mark Rutland Cc: Jarkko Sakkinen , linux-kernel@vger.kernel.org, agordeev@linux.ibm.com, anil.s.keshavamurthy@intel.com, aou@eecs.berkeley.edu, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, davem@davemloft.net, gor@linux.ibm.com, hca@linux.ibm.com, jcalvinowens@gmail.com, linux-arm-kernel@lists.infradead.org, mhiramat@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, palmer@dabbelt.com, paul.walmsley@sifive.com, tglx@linutronix.de, will@kernel.org Subject: Re: [PATCH 4/4] kprobes: Remove core dependency on modules Message-Id: <20240327090155.873f1ed32700dbdb75f8eada@kernel.org> In-Reply-To: References: <20240326163624.3253157-1-mark.rutland@arm.com> <20240326163624.3253157-5-mark.rutland@arm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_170210_630570_A524C42A X-CRM114-Status: GOOD ( 20.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 26 Mar 2024 17:38:18 +0000 Mark Rutland wrote: > On Tue, Mar 26, 2024 at 07:13:51PM +0200, Jarkko Sakkinen wrote: > > On Tue Mar 26, 2024 at 6:36 PM EET, Mark Rutland wrote: > > > > +#ifdef CONFIG_MODULES > > > /* Check if 'p' is probing a module. */ > > > *probed_mod = __module_text_address((unsigned long) p->addr); > > > if (*probed_mod) { > > > @@ -1605,6 +1606,8 @@ static int check_kprobe_address_safe(struct kprobe *p, > > > ret = -ENOENT; > > > } > > > } > > > +#endif > > > > This can be scoped a bit more (see v7 of my patch set). > > > > +#ifdef CONFIG_MODULES > > > static nokprobe_inline bool trace_kprobe_module_exist(struct trace_kprobe *tk) > > > { > > > char *p; > > > @@ -129,6 +130,9 @@ static nokprobe_inline bool trace_kprobe_module_exist(struct trace_kprobe *tk) > > > > > > return ret; > > > } > > > +#else > > > +#define trace_kprobe_module_exist(tk) false /* aka a module never exists */ > > > +#endif /* CONFIG_MODULES */ > > > > > > static bool trace_kprobe_is_busy(struct dyn_event *ev) > > > { > > > @@ -670,6 +674,7 @@ static int register_trace_kprobe(struct trace_kprobe *tk) > > > return ret; > > > } > > > > > > +#ifdef CONFIG_MODULES > > > /* Module notifier call back, checking event on the module */ > > > static int trace_kprobe_module_callback(struct notifier_block *nb, > > > unsigned long val, void *data) > > > @@ -699,6 +704,9 @@ static int trace_kprobe_module_callback(struct notifier_block *nb, > > > > > > return NOTIFY_DONE; > > > } > > > +#else > > > +#define trace_kprobe_module_callback (NULL) > > > +#endif /* CONFIG_MODULES */ > > > > The last two CONFIG_MODULES sections could be combined. This was also in > > v7. > > > Other than lgtm. > > Great! I've folded your v7 changes in, and pushed that out to: > > https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=kprobes/without-modules > > I'll hold off sending that out to the list until other folk have had a chance > to comment. Yeah, the updated one looks good to me too. Thanks! > > Mark. -- Masami Hiramatsu (Google) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel