From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 802D3C54E67 for ; Wed, 27 Mar 2024 12:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vE49EFNhMuwNDWITOhmCTVnkFv0yUwauwPk7EXbZnU8=; b=MEj57kRQ11KbAG hJzcXWOsY91f6I29PNxDQ/JvmctO3wVpB9PEbgj6XQoQqd9qd1WN9/pAKgqAPqDngDduWPs/tzjbm NJBsymaw0kHyAkGY0SiRY2DimM7lrZJwPedDz1u4kMvh3DL1ziaPyu1vE6T6ihbl0/bBK0hSlvFfQ /yIZBrVZe1wbOODMARCZ9Cn1HtGzajJ1y3weglxrpzWNxs1esT1++LI5GZUItZbiNEbTIkfz9XLDz hSHUc8NnDSrTZdzXAai8x5todt1FfAwYxo0bWOaOOIL54MjL9EX9dGATacwv9+47eV/KxB2yF0FT4 MR2IkQzVs0nLP0/D+YBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpSf5-00000008yTI-3ozF; Wed, 27 Mar 2024 12:45:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpSf1-00000008yPv-15Vu for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 12:45:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DDD0860BA0; Wed, 27 Mar 2024 12:45:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 335FBC43394; Wed, 27 Mar 2024 12:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711543541; bh=UG+sWCgJdW5QMJRXuangEUOiQHJCcImOBJ7ALiw3A+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AjG1DV51cFLTNpfm3NxY8PrL9hGn+XQNXMMyZPfnyiBNfR9WvTZLb2pv8nrQq0sXQ BQbBzJLW3SB4C5elH0EG9mzbKEj+046NQ9Rfeh6jS4e9shDpJEGm5OuC6NEAy7XfHK aIh8+FPnvdsgth9RN4CobaidDaRMIQNESRT3iND/n9YbL80xdxpK2k5w7zNQPo2mZm uTG1VIZhXdqROHyoDTU134Tm14XPqawybdeRI3nviUwilHQYzowP9AuD5NlBmykaYs 41CDToMAKZTB1NELr8Ha0LBI3dZbzsGtHcik2URxmc8Vw9qnJISPDIFWok056cV0LR 7RpApRFItLzFw== Date: Wed, 27 Mar 2024 12:45:35 +0000 From: Will Deacon To: Ryan Roberts Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Gavin Shan , Marc Zyngier , Mostafa Saleh , Oliver Upton , Quentin Perret , Raghavendra Rao Ananta , Shaoqin Huang , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH 3/3] KVM: arm64: Use TLBI_TTL_UNKNOWN in __kvm_tlb_flush_vmid_range() Message-ID: <20240327124535.GA11031@willie-the-truck> References: <20240325185158.8565-1-will@kernel.org> <20240325185158.8565-4-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_054543_544865_A12A8F19 X-CRM114-Status: GOOD ( 14.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 01:48:46PM +0000, Ryan Roberts wrote: > On 25/03/2024 18:51, Will Deacon wrote: > > Commit c910f2b65518 ("arm64/mm: Update tlb invalidation routines for > > FEAT_LPA2") updated the __tlbi_level() macro to take the target level > > as an argument, with TLBI_TTL_UNKNOWN (rather than 0) indicating that > > the caller cannot provide level information. Unfortunately, the two > > implementations of __kvm_tlb_flush_vmid_range() were not updated and so > > now ask for an level 0 invalidation if FEAT_LPA2 is implemented. > > Ouch, sorry about this! I remember rebasing my change onto the KVM tlbi range > changes and having a few conflicts. Obviously I didn't do a good enough job of > reviewing the result and missed this new user. No problem, it's easily done. It's also not your fault, as we shouldn't have been using the reserved encoding of 0 to mean "no hint" in the first place! > > Cc: Ryan Roberts > > Cc: Catalin Marinas > > Cc: Oliver Upton > > Cc: Marc Zyngier > > Fixes: c910f2b65518 ("arm64/mm: Update tlb invalidation routines for FEAT_LPA2") > > Signed-off-by: Will Deacon > > Reviewed-by: Ryan Roberts Thanks. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel