From: git@luigi311.com
To: linux-media@vger.kernel.org
Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com,
mchehab@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
sakari.ailus@linux.intel.com, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 03/23] media: i2c: imx258: Disable digital cropping on binned modes
Date: Wed, 27 Mar 2024 17:16:49 -0600 [thread overview]
Message-ID: <20240327231710.53188-4-git@luigi311.com> (raw)
In-Reply-To: <20240327231710.53188-1-git@luigi311.com>
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
The binned modes set DIG_CROP_X_OFFSET and DIG_CROP_IMAGE_WIDTH
to less than the full image, even though the image being captured
is meant to be a scaled version of the full array size.
Reduce X_OFFSET to 0, and increase IMAGE_WIDTH to the full array.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/imx258.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index 4a7048d834c6..0ae4371940ca 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -340,11 +340,11 @@ static const struct imx258_reg mode_2104_1560_regs[] = {
{ 0x0404, 0x00 },
{ 0x0405, 0x20 },
{ 0x0408, 0x00 },
- { 0x0409, 0x02 },
+ { 0x0409, 0x00 },
{ 0x040A, 0x00 },
{ 0x040B, 0x00 },
{ 0x040C, 0x10 },
- { 0x040D, 0x6A },
+ { 0x040D, 0x70 },
{ 0x040E, 0x06 },
{ 0x040F, 0x18 },
{ 0x3038, 0x00 },
@@ -459,11 +459,11 @@ static const struct imx258_reg mode_1048_780_regs[] = {
{ 0x0404, 0x00 },
{ 0x0405, 0x40 },
{ 0x0408, 0x00 },
- { 0x0409, 0x06 },
+ { 0x0409, 0x00 },
{ 0x040A, 0x00 },
{ 0x040B, 0x00 },
{ 0x040C, 0x10 },
- { 0x040D, 0x64 },
+ { 0x040D, 0x70 },
{ 0x040E, 0x03 },
{ 0x040F, 0x0C },
{ 0x3038, 0x00 },
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-27 23:29 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 23:16 [PATCH 00/23] v2: imx258 improvement series git
2024-03-27 23:16 ` [PATCH 01/23] media: i2c: imx258: Remove unused defines git
2024-03-28 7:42 ` Krzysztof Kozlowski
2024-03-27 23:16 ` [PATCH 02/23] media: i2c: imx258: Make image geometry meet sensor requirements git
2024-03-27 23:16 ` git [this message]
2024-03-27 23:16 ` [PATCH 04/23] media: i2c: imx258: Remove redundant I2C writes git
2024-03-27 23:16 ` [PATCH 05/23] media: i2c: imx258: Add regulator control git
2024-03-27 23:16 ` [PATCH 06/23] media: i2c: imx258: Make V4L2_CID_VBLANK configurable git
2024-03-27 23:16 ` [PATCH 07/23] media: i2c: imx258: Split out common registers from the mode based ones git
2024-03-27 23:16 ` [PATCH 08/23] media: i2c: imx258: Add support for 24MHz clock git
2024-03-28 8:09 ` Sakari Ailus
2024-03-28 17:55 ` Luigi311
2024-03-28 23:03 ` Luigi311
2024-04-04 8:03 ` Sakari Ailus
2024-03-27 23:16 ` [PATCH 09/23] media: i2c: imx258: Add support for running on 2 CSI data lanes git
2024-03-28 8:19 ` Sakari Ailus
2024-03-28 23:42 ` Luigi311
2024-03-29 19:10 ` Luigi311
2024-03-27 23:16 ` [PATCH 10/23] media: i2c: imx258: Follow normal V4L2 behaviours for clipping exposure git
2024-03-27 23:16 ` [PATCH 11/23] media: i2c: imx258: Add get_selection for pixel array information git
2024-03-27 23:16 ` [PATCH 12/23] media: i2c: imx258: Allow configuration of clock lane behaviour git
2024-03-27 23:16 ` [PATCH 13/23] media: i2c: imx258: Correct max FRM_LENGTH_LINES value git
2024-03-27 23:17 ` [PATCH 14/23] media: i2c: imx258: Issue reset before starting streaming git
2024-03-27 23:17 ` [PATCH 15/23] media: i2c: imx258: Set pixel_rate range to the same as the value git
2024-03-27 23:17 ` [PATCH 16/23] media: i2c: imx258: Support faster pixel rate on binned modes git
2024-03-27 23:17 ` [PATCH 17/23] dt-bindings: media: imx258: Rename to include vendor prefix git
2024-03-27 23:47 ` Conor Dooley
2024-03-28 0:57 ` git
2024-03-28 8:52 ` Kieran Bingham
2024-03-28 10:15 ` Conor Dooley
2024-03-28 16:15 ` Luigi311
2024-03-27 23:17 ` [PATCH 18/23] dt-bindings: media: imx258: Add alternate compatible strings git
2024-03-28 0:44 ` Rob Herring
2024-03-28 7:47 ` Krzysztof Kozlowski
2024-03-28 17:05 ` Luigi311
2024-03-28 17:06 ` Krzysztof Kozlowski
2024-03-28 18:55 ` Rob Herring
2024-03-28 19:16 ` Luigi311
2024-03-28 20:46 ` Rob Herring
2024-03-28 21:02 ` Luigi311
2024-03-28 20:05 ` kernel test robot
2024-03-30 0:30 ` kernel test robot
2024-03-30 20:59 ` kernel test robot
2024-03-27 23:17 ` [PATCH 19/23] media: i2c: imx258: Change register settings for variants of the sensor git
2024-03-27 23:17 ` [PATCH 20/23] media: i2c: imx258: Make HFLIP and VFLIP controls writable git
2024-03-27 23:17 ` [PATCH 21/23] drivers: media: i2c: imx258: Use macros git
2024-03-27 23:17 ` [PATCH 22/23] drivers: media: i2c: imx258: Add support for powerdown gpio git
2024-03-28 20:48 ` Rob Herring
2024-03-28 21:11 ` Luigi311
2024-04-02 14:28 ` Dan Carpenter
2024-03-27 23:17 ` [PATCH 23/23] drivers: media: i2c: imx258: Add support for reset gpio git
2024-03-28 7:43 ` [PATCH 00/23] v2: imx258 improvement series Krzysztof Kozlowski
2024-03-30 3:51 ` Dang Huynh
2024-03-30 6:37 ` Luigi311
-- strict thread matches above, loose matches on Subject: below --
2024-03-27 22:20 git
2024-03-27 22:20 ` [PATCH 03/23] media: i2c: imx258: Disable digital cropping on binned modes git
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327231710.53188-4-git@luigi311.com \
--to=git@luigi311.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).