From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5969FCD11DF for ; Thu, 28 Mar 2024 18:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G8+MXJI6Jj8IK/Yckgh5P8F3qSg2wU1mmTn/oml59fM=; b=SXVJkWpujb00ac l7QLm5laax/dmEUpuZXywN7ocdjv2E9MJXTAGVh4niHIA4/8NEQUBn1+wLhlvNddGoyg9TdUIiZZI +fLQpGUaoMkDsCeuM5YpMos9cXQ+Zr/Mi5LIEqA7kFzS7NUj5elHMajE2fS8m5HHt/N+Sfu88pJZ6 1ljOC4NhF/7U3/0wEDUIFFOrhvkmlT+Af9d9VstpxmZ6FnxKmvysiz0DFwuUMNXypptnd2eqxdhAk TWqX+VN0l/Mf/OHnrnLdTIVp8BT1mkLzfwJXmUlkFOIPU9h5Qa/c3pg/pnylH9O4F3tJJ29ZX4RrW iaG7PuPC8RhUNTP6MK0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpuuW-0000000FGzi-0fPg; Thu, 28 Mar 2024 18:55:36 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpuuQ-0000000FGyF-3SXe for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 18:55:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 236B8CE2C8A; Thu, 28 Mar 2024 18:55:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 285F8C433F1; Thu, 28 Mar 2024 18:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711652128; bh=O6RUd0FiuATOUi3p2Fr6EOtVM8/VxTL6vhWICc/xTtE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rMVJ+HLghR8zyz+qCC2JJP7kQGIEGPxr5Ml98x4dA7YSvWIuBNBkAKz5BVNnt1cKC U4X26lSPrv66WvoaSs7HO7Wjv4vJagUioEMbZYr1bzr4fbuCXEYXLEBlrzMCUfI9oK 7Q8cOeQUyi5lfFD2idby9yZOvPuqWB7rhehfUD0c5e1jbcPeMeCUWGyKB7TWceDNYH NiCdtRDgKp5SrrIGkWBPfkU55FKLpe/A0hGW9al8izHQTEQemTRp611vGqDyI+9lvW uC+e9g+wberfvYWj6IomFhK8s2kj1mbgF965VRhIRBkGAHahwkwi0j++Am1kna3fJ5 EFVYHhWqdN2Nw== Date: Thu, 28 Mar 2024 13:55:26 -0500 From: Rob Herring To: git@luigi311.com Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 18/23] dt-bindings: media: imx258: Add alternate compatible strings Message-ID: <20240328185526.GA88354-robh@kernel.org> References: <20240327231710.53188-1-git@luigi311.com> <20240327231710.53188-19-git@luigi311.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240327231710.53188-19-git@luigi311.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_115531_071859_07426826 X-CRM114-Status: GOOD ( 18.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2024 at 05:17:04PM -0600, git@luigi311.com wrote: > From: Dave Stevenson > > There are a number of variants of the imx258 modules that can not > be differentiated at runtime, so add compatible strings for them. But you are only adding 1 variant. > > Signed-off-by: Dave Stevenson > Signed-off-by: Luigi311 > --- > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > index bee61a443b23..c7856de15ba3 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > @@ -14,10 +14,14 @@ description: |- > type stacked image sensor with a square pixel array of size 4208 x 3120. It > is programmable through I2C interface. Image data is sent through MIPI > CSI-2. > + There are a number of variants of the sensor which cannot be detected at > + runtime, so multiple compatible strings are required to differentiate these. That's more reasoning/why for the patch than description of the h/w. > properties: > compatible: > - const: sony,imx258 > + - enum: > + - sony,imx258 > + - sony,imx258-pdaf How do I know which one to use? Please define what PDAF means somewhere as well as perhaps what the original/default variant is or isn't. > > assigned-clocks: true > assigned-clock-parents: true > -- > 2.42.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel