From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 163E4CD128A for ; Sun, 31 Mar 2024 20:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qKNgjiAe2XmqzMurKlMyXWC6Hz+VTLQX9RNHkfODBmk=; b=gkCUTQAdSjc6Cx KVKGbf68ucBf2r1fizA9+N8y1DSeGHFFlWnJs7zcNeOHbe3beYWwcGAkdNS3kdVTrSNjED3k1jJL9 M8Pip8j4i5UcYAjQzPi0o6D/H+6oSESySl1hnZcDifSqQ1+85+SfPwpmPuDUSC6oY45fHzzvh8dRn POglzghTzIjBB/N2Oz1GCb5Hpo97kPXmHH6DstGfQiZfpN/kLDXTw32HbX1mq47JdhwuunYefpC6/ X08eD4lMaTommCJdcCk33Y+pTlHAyb3bIZtKPbBARr3bVO757SWVNvs73Or0zFaRT3aGeY/s3wTFM tk/mgHXxzWjy0dBHE/8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr1vs-00000006Ha0-3zHF; Sun, 31 Mar 2024 20:37:36 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr1vo-00000006HZA-4AaM; Sun, 31 Mar 2024 20:37:34 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 907CA1FA4F; Sun, 31 Mar 2024 22:37:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1711917451; bh=4J4UxMw8vCu/e4YwDL2de2cwdYJiMGR5S+olW6/Wq0o=; h=From:To:Subject; b=oAZWgVnqbpNY/NnnmLvGf4jms0+WYBdOHuj6GVG2+twoiY2kvJ59PArKOwyHgrBFu /MGz/tkWe+HyJtFWVkp5epS7wje5jgCr+lMQ4ElORxQO6762OoDo81tvY6X4FwXtNa HtADJytvzwGNfGcbyBDGljlmMSyQ8Dy7odJIiQ1jHODmYQLfOU1g5/m4W/jjtva54a Q/u5I2zChQUKUzs781NCH5eFrqXybF+IgTiw37MCg7aj8nrUAtNk1lSZF159sZhKP8 C4OKL4DuR+tHGgQgT6myIyyFmHPMFt4OTBBONnZQayJGV06MpVBND6girIBxOdCYJr MPrpOIkJWhgrQ== Date: Sun, 31 Mar 2024 22:37:29 +0200 From: Francesco Dolcini To: Krzysztof Kozlowski Cc: Ulf Hansson , Marcel Holtmann , Luiz Augusto von Dentz , Matthias Brugger , AngeloGioacchino Del Regno , Kalle Valo , Jeff Johnson , Arend van Spriel , Brian Norris , =?iso-8859-1?B?Suly9G1l?= Pouiller , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH 1/7] mmc: sdio: store owner from modules with sdio_register_driver() Message-ID: <20240331203729.GC4116@francesco-nb> References: <20240329-module-owner-sdio-v1-0-e4010b11ccaa@linaro.org> <20240329-module-owner-sdio-v1-1-e4010b11ccaa@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240329-module-owner-sdio-v1-1-e4010b11ccaa@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240331_133733_222544_0B748A50 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Krzysztof, On Fri, Mar 29, 2024 at 06:24:31PM +0100, Krzysztof Kozlowski wrote: > Modules registering driver with sdio_register_driver() might > forget to set .owner field. The field is used by some of other kernel ^^ double space here > parts for reference counting (try_module_get()), so it is expected that > drivers will set it. > > Solve the problem by moving this task away from the drivers to the core > code, just like we did for platform_driver in > commit 9447057eaff8 ("platform_device: use a macro instead of > platform_driver_register"). > > Since many drivers forget to set the .owner, this effectively will fix > them. Examples of fixed drivers are: ath6kl, b43, btsdio.c, ks7010, ^^ and here > libertas, MediaTek WiFi drivers, Realtek WiFi drivers, rsi, siano, > wilc1000, wl1251 and more. > > Signed-off-by: Krzysztof Kozlowski My nit comments are irrelevant, but given you did the same twice I felt like letting you know. Reviewed-by: Francesco Dolcini _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel