From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EC2ACD128A for ; Mon, 1 Apr 2024 22:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=mjtmWHblKJXdtVV+gfFi/7w6I3dTkxAOe7lFZgaubNY=; b=wwcjQDM7crNjnWwQer/dZcUQlw nORv2DileR6KAtx3kpE9dNN67dkNF39e2ySTcROgmUydC8dsTOW1uOL4yJM0AN9nO2QHQAhT12+/6 b8Ob18+NMCy1vFZ1l9HLoLdXeSX+lKoPc3MZU/g3UKs+AX8kSmliMs/QRSR6lHnL5vjCa7Dl+Rph0 ktGt7XynPJ3vwBt+QdEND43yVQPYvod6nd/yNL93o90XPwLq1D0896If9UJC3H8odm0fCRwhpuZuY Xadl1SXTgIVlgZ6yzQVcDEE8h3pDbZ+AtkaCtmemi5TiDl7cO4OHWGZbTIq03FDaLHwpyZPubwf1R /G18Zylw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQ6b-00000008zsw-2UzG; Mon, 01 Apr 2024 22:26:17 +0000 Received: from mail-ve1eur01on2108.outbound.protection.outlook.com ([40.107.14.108] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQ6Y-00000008zqg-2rMt for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 22:26:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=khnd2/zGCiPNDa8VcDCnz7a2ToWFc9ucxi2CWYCnnhwoEgzs4woskilkyc2s7uQ1wS5C+90ZvePVi7Qi9kPvgn0uPnxIZrCyHOxd/Yddn08ZTGBZULNZd79/ZMTi1R+SUWZ8kdxwhVIOjuN7O+uqV8z4E9eSEKfNZZKYlBh8N2K0dAfvQCVt81dxEBSsIq/A1EpiqqO57wmiEFrO67EH5f4LOC0Ps5UpuVokHIH4mDSko/36RkoR9apOnjBWBDgshXmcYQbsaNC3oTvTmXwQVAVpPPcEeN4dPbZcpfv6slCQ2aV32PgdbpPBZD4ylU5i+WBpX2EXEd5eoiaGGbwMxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KbfiNiMfF5H3qFP3XuQFZABx3PHhYvzTsVrISPYMpMM=; b=AnYaNDXnx13oi7819Po3FXGIDRE5No/Afnc0JBeHN8/GjPGBLasxkHbxwBMWw2xWOjRfOldIEb15wVVuH+qWXMCTYyhQ38LgL4nk2+pa8Hs2wLTm3ceXEq9K6nS54TSmj3V2vKBdxJYxfo2/vvB991fjAo4hbd+AwCAlK6UCcgV7LDOqzf5imbV6we3lR0KQi3E3T8wLLlHN76q4piyDJhlZs/oTdq8thyi2AQmAzQ9GS6Wk3FUP+rNz63vn9E4FSTMhEfT8zHV04gDBVOZBCPtQss8cUEuJIlp/IiYkoT5O2QeAdwdXhhSmQXnYj1rJRFDcOM8blGbNqzLVdwLz+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KbfiNiMfF5H3qFP3XuQFZABx3PHhYvzTsVrISPYMpMM=; b=c91ltZ2LI01blfZVkZqNrlcH9COHXAR+oL0d7KGTf2JX0I4UsV2PCaqsyKYG5F+SDbuoRo+IDxpkT8D3EZQEGJgyMoJ1Y+ZI3hfjqZ8Kek7Qll0yX1gJIfDJ0KCgvywXKIkjLYFEMOL5bFDvzvnVeCdQhJr1gAeJ9lHwUfDDo/M= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:26:00 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:26:00 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:08 -0400 Subject: [PATCH 6/7] arm64: dts: imx8-ss-dma: fix can lpcg indices Message-Id: <20240401-dts_fix-v1-6-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=2525; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=eO6HQ4nQkUGETGGZsuLNurR+PbulGpVNdui39aXhUCA=; b=zq02e6hO7o7sOd+iifS90EBTE0PozjY776Qcwp0fDEJE0JG5wcKtl6yJHY6rfVcBwVJA2mQj2 xpAjUTUNd3mBDyCoLoZMMSUc1zK7SLTXxFvmK25fJQtC04PM9miL4bN X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dL9FGh+/dH6crvq1A5b/sxHvZFwQjNGqwsMJgtYM91jMV5oO6G024UHzE/WYm9RZ7tQHykH4Ig6N7xgEHUtidPoHlqtSr19JivppzcqzATD7cy4MxrPTC9q+F3OSO68HWsXHH0Q57S6Ryf+91mTxtDuL3aqJHD2WE22z2HmPWTuSoSWnWTUiQXoPSQdt1lBXTE7kRXYEEkRBfwYAt0xb6WfAgEeSpU1c63jRCyNqvVYkrokugVlmFV8z5QhOcoSTxp6ApeOkZN7r8tQh4y/9rAxY4+vne3tfbHwkNjZV5fT4RvI2DuB5GOyFI/qunx1EOGzuq+OsqQhOLseIJRKYAeaTarcOZVukAtkcaUhJnyzD5UvmUMKOJ7yZ9T4ktVvizgI4PBG+CHuBcGE7JYFWoXKUYJ/pi6aUPOzqNrSwmshU5+Vvic7cm/ASsXOPGzw6M9pg6ebHWZ/epsI1qz0fbZKRuvU5Su2rTfE9hThPP0czdWkaKJG/ChhtH6qYWj19mPlQeWkE7gu5VBG6tqU5XXror7cRelsqeMbCEWkvlv0XjFkIt7bZQkIT9cGLO96vRGKLHX6yJOVrJd/8dYh3hkLmNDJb3A4KXxvM5iM3Bv7x+Rhy20hmRuqoeDFh5Wno+C6E/XhN+E3f1T6H/jbHDmuJKcihT5B+BHao2+YUHBFKYXukUTJjnDkGnfR2RLgVM9VHWO4vPOdfd+4rlWAVN4lN6B5rXdHw5KQ0eJCDL3A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkZDL212TlM0S3EvTkpENkY4Tzh2S1pvb1p2Q0FNUGFSdzJaLzB1SDM1ek0r?= =?utf-8?B?Q0hLWU9QVkx5ODB6Y2dYaVp5UXc5UXFEVHMrU0lZbWZqdkwrMEoxUnh5Z2ZP?= =?utf-8?B?Vk5CVU9oc3RWNXZtY3diQjZKZkJVbWlyUFgwN1JmUjBDRTg0Q2RhaUxTc295?= =?utf-8?B?TlhMdXp6cjJ5TUcvdnhCbjVaVE80eVVBeTBrMWVYYzZ6QlRSV2xNVW5CQXhL?= =?utf-8?B?Z3JDbDVwK1g3WlpkMy9XS3BmRlNKdy9LdUZGbmdiSHR5c3dQblRvOTNTa1Vh?= =?utf-8?B?ak5YNkMyUlQrbFBMWjJBSThsRUNrR0hVUnBEVmJxMklsN1NqS1RrbUZxZHRy?= =?utf-8?B?WllmaFBqNnM0TGROTmFaakNnVEJCT3ZYRndkakFSSFZYQWFWUTErNFA5WDkr?= =?utf-8?B?NnZKeHV1VHNQRXFiZURuZzgvQTlpdzZOZVQ4aE1NYWJRQkIyYlpwYk5YeWFz?= =?utf-8?B?ZFVDczJLQjkzVER4OTM1U3hGaWFjZEladzVFM0dRWW5remg4UEVFNDVMZHFW?= =?utf-8?B?dmlhOU9iaEk3RnljNGxnMUdFZlYwbnhhTmpySmZ4b2lIamJBcEE0TnAvZkU2?= =?utf-8?B?ZnErQ1ZTN3U1T25WN25LZVZKY3E2ckV5bnRFRUQyaWlwUWRnR1BVem9YbmFl?= =?utf-8?B?UHY5YjlzalhaWmEyTk01VHhZT3NyYkNMNExXdDA0RFQ3WmhtejVPa3dUZ2hy?= =?utf-8?B?YjlMa1NVTWdsd0dha29EMEZIQVZSL1o1ODYwbXBCQXRDVUJFYWloeUs2NnZk?= =?utf-8?B?bVNhakw0d0JEVGJUZXdrckRXMkJkbGRZbGRsQk1JNDF2ck40WEw1Rzl3azlm?= =?utf-8?B?eHNuMGZtVjcxaEV3QVJvRnFicDRNUTNSQWV5Q0U4ZmZ1SmZEWmF4OUFhZEt1?= =?utf-8?B?TlN4L0M4ZFFLR04yQnhHN2pkMHNrc0JzbFJxeDhtQk5jczVLZER4MzlMblNO?= =?utf-8?B?ZXBzY3pLMnE3cDBqbDlQRVg0N1Z1bFpac0ZITlVWclNySlp0NXhubDJ6WlFB?= =?utf-8?B?bWJvU3crK1AvaUhMMnFFbWtYNEg4UGFxYUtSUVdVNDc2REpWSUpWbktNMGR0?= =?utf-8?B?R2N0dWorYzdXcFIwSi9LRlZHR2hDZUxGN1p2UjAxY2dMYUFrS04yaFplUXF3?= =?utf-8?B?WE1tb2VzRURJNGw3MDdTT0Vid0lHTWNUSGlLbW1rWEd5Y2JzMGN2REducHJ0?= =?utf-8?B?aTVTdXdPOEg5K3A2WmFkT2JjSG1RSUlFNVA5K05pNzRqOUpQR0YxUUZ2Qkdl?= =?utf-8?B?WXpBczgrS3p0YjdwRzVVTVprbXdtQ2pmbzUzK3lweWU1TW5nNHZmcWp4dHRk?= =?utf-8?B?VW5MZGdjK01SM2lLaWVwT3F6akFka29sanNQSEg0UkVqY0wraEU4OFVGM1I0?= =?utf-8?B?QUNKMzFuSkordlZhNVQvT0RWNzRlYjF6eitDdUJvNkVqU0NyRFRZY2Rlem5n?= =?utf-8?B?Z09kYnZWUGdsOHBNQlBuTXJkbUo1K2tTMEd2L1lneG92MWFjSnhRMGI4aUxl?= =?utf-8?B?UFo2WnNJRVRPR1IvUWFuQVVySWhOcXVsZ3ZFRkRLUXQ4czBaQUVTN25DR3VS?= =?utf-8?B?VlV2cHhuVTBpcGdINFdHNVl3U2FxTUN5d2Z5MTBRbGs2VHZFcDBCN0hhTFBx?= =?utf-8?B?OGRTRStkcCtyT2k3eDl5MHhFd3p3Qmw0bStSR0VDczBpZDB6YmZ6MlFzR0Rq?= =?utf-8?B?c3NXQTBYUzBRcGxOVTdQTnJFQzJNOHpuWmtNSWtueFRRWFpmTVM1b2s5REJh?= =?utf-8?B?cG9pQVUxSGYyRU9DMmJlNCtuN0N3VmUrNFd4Z0dDandKbld0RVlGSEtONzF4?= =?utf-8?B?eGJld09WeWh3QkEvUllTU09pVVZqb09ubktROEJ6NkZlaGxPWkkxSSthSFZp?= =?utf-8?B?K1Vwd0IrWEJNK25kWGJEeVdwZHBxTTdrcmlBRitHSFVJVkJMc3FWb2ZjUmN0?= =?utf-8?B?VFpQVmw4dHlHaTY4WW5LS3R4WkxueWxIL3VtTlRIa0tLaG01M0JDL1RVQnNo?= =?utf-8?B?N2JoTXRFbHVNNUw5eXdicWhqMWtWOG0vS080aVNxZXRtRkVQUHVJMXR6NGxR?= =?utf-8?B?allaVGpGOUo4T0tpZDRqSWJESS9XZU5Da2RKSXpaZFFRNmtrQ0dCQ0hubjV1?= =?utf-8?Q?wU1g=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e20618cd-2734-4a38-cd40-08dc529ab585 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:26:00.4359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YTCo1qOAsCofITJigvj+FC1Q5LGTcbLBcYqDG83GO5/8ZSPfDvQKMguB/lp7c/MLYah20aismRIShL+zxxdM4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_152614_792994_B99B3152 X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org can0_lpcg: clock-controller@5acd0000 { ... Col1 Col2 clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>, // 0 0 <&dma_ipg_clk>, // 1 4 <&dma_ipg_clk>; // 2 5 clock-indices = , , ; } Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. flexcan1: can@5a8d0000 { clocks = <&can0_lpcg 1>, <&can0_lpcg 0>; ^^ ^^ Should be: clocks = <&can0_lpcg IMX_LPCG_CLK_4>, <&can0_lpcg IMX_LPCG_CLK_0>; }; Arg0 is divided by 4 in lpcg driver. flexcan driver get IMX_SC_PM_CLK_PER by <&can0_lpcg 1> and <&can0_lpcg 0>. Although function can work, code logic is wrong. Fix it by using correct clock indices. Cc: stable@vger.kernel.org Fixes: 5e7d5b023e03 ("arm64: dts: imx8qxp: add flexcan in adma") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index 77ba2dd6847b4..67b3c7573233a 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -406,8 +406,8 @@ flexcan1: can@5a8d0000 { reg = <0x5a8d0000 0x10000>; interrupts = ; interrupt-parent = <&gic>; - clocks = <&can0_lpcg 1>, - <&can0_lpcg 0>; + clocks = <&can0_lpcg IMX_LPCG_CLK_4>, + <&can0_lpcg IMX_LPCG_CLK_0>; clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <40000000>; @@ -427,8 +427,8 @@ flexcan2: can@5a8e0000 { * CAN1 shares CAN0's clock and to enable CAN0's clock it * has to be powered on. */ - clocks = <&can0_lpcg 1>, - <&can0_lpcg 0>; + clocks = <&can0_lpcg IMX_LPCG_CLK_4>, + <&can0_lpcg IMX_LPCG_CLK_0>; clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <40000000>; @@ -448,8 +448,8 @@ flexcan3: can@5a8f0000 { * CAN2 shares CAN0's clock and to enable CAN0's clock it * has to be powered on. */ - clocks = <&can0_lpcg 1>, - <&can0_lpcg 0>; + clocks = <&can0_lpcg IMX_LPCG_CLK_4>, + <&can0_lpcg IMX_LPCG_CLK_0>; clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <40000000>; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel