* [PATCH 2/4] arm64: dts: uniphier: ld11-global: drop audio codec port unit address
2024-04-01 14:09 [PATCH 1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec Krzysztof Kozlowski
@ 2024-04-01 14:09 ` Krzysztof Kozlowski
2024-04-01 14:09 ` [PATCH 3/4] arm64: dts: uniphier: ld20-global: use generic node name for audio-codec Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-01 14:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kunihiko Hayashi,
Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
Audio codec port does not have "reg", thus it should not have unit
address, as reported by dtc W=1 warning:
uniphier-ld11-global.dts:127.10-132.5: Warning (unit_address_vs_reg): /soc@0/i2c@58780000/tas5707a@1d/port@0: node has a unit name, but no reg or ranges property
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts b/arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts
index 2f88e81b7ee3..a251c4343548 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts
@@ -124,7 +124,7 @@ audio-codec@1d {
PVDD_C-supply = <&_vcc_reg>;
PVDD_D-supply = <&_vcc_reg>;
- port@0 {
+ port {
tas_speaker: endpoint {
dai-format = "i2s";
remote-endpoint = <&i2s_hpcmout1>;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] arm64: dts: uniphier: ld20-global: use generic node name for audio-codec
2024-04-01 14:09 [PATCH 1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec Krzysztof Kozlowski
2024-04-01 14:09 ` [PATCH 2/4] arm64: dts: uniphier: ld11-global: drop audio codec port unit address Krzysztof Kozlowski
@ 2024-04-01 14:09 ` Krzysztof Kozlowski
2024-04-01 14:09 ` [PATCH 4/4] arm64: dts: uniphier: ld20-global: drop audio codec port unit address Krzysztof Kozlowski
2024-04-24 6:54 ` [PATCH 1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-01 14:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kunihiko Hayashi,
Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
Devicetree specification expects node names to be generic, representing
the class of devices.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
index a01579cb3b79..a4c86137f424 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
@@ -111,7 +111,7 @@ &comp_spdif_hiecout1 {
&i2c0 {
status = "okay";
- tas5707@1b {
+ audio-codec@1b {
compatible = "ti,tas5711";
reg = <0x1b>;
reset-gpios = <&gpio UNIPHIER_GPIO_PORT(0, 0) GPIO_ACTIVE_LOW>;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/4] arm64: dts: uniphier: ld20-global: drop audio codec port unit address
2024-04-01 14:09 [PATCH 1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec Krzysztof Kozlowski
2024-04-01 14:09 ` [PATCH 2/4] arm64: dts: uniphier: ld11-global: drop audio codec port unit address Krzysztof Kozlowski
2024-04-01 14:09 ` [PATCH 3/4] arm64: dts: uniphier: ld20-global: use generic node name for audio-codec Krzysztof Kozlowski
@ 2024-04-01 14:09 ` Krzysztof Kozlowski
2024-04-24 6:54 ` [PATCH 1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-01 14:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kunihiko Hayashi,
Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
Audio codec port does not have "reg", thus it should not have unit
address, as reported by dtc W=1 warning:
uniphier-ld20-global.dts:127.10-132.5: Warning (unit_address_vs_reg): /soc@0/i2c@58780000/tas5707@1b/port@0: node has a unit name, but no reg or ranges property
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
index a4c86137f424..79f6db2455c1 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
@@ -124,7 +124,7 @@ audio-codec@1b {
PVDD_C-supply = <&_vcc_reg>;
PVDD_D-supply = <&_vcc_reg>;
- port@0 {
+ port {
tas_speaker: endpoint {
dai-format = "i2s";
remote-endpoint = <&i2s_hpcmout1>;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec
2024-04-01 14:09 [PATCH 1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec Krzysztof Kozlowski
` (2 preceding siblings ...)
2024-04-01 14:09 ` [PATCH 4/4] arm64: dts: uniphier: ld20-global: drop audio codec port unit address Krzysztof Kozlowski
@ 2024-04-24 6:54 ` Krzysztof Kozlowski
2024-04-25 0:12 ` Kunihiko Hayashi
3 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-24 6:54 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kunihiko Hayashi,
Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Krzysztof Kozlowski
Cc: Krzysztof Kozlowski
On Mon, 01 Apr 2024 16:09:49 +0200, Krzysztof Kozlowski wrote:
> Devicetree specification expects node names to be generic, representing
> the class of devices.
>
>
Almost a month passed, no replies from maintainers about picking it up. Dunno,
looks abandoned, so let me grab this. If anyone else wants to pick it up, let
me know.
Applied, thanks!
[1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec
https://git.kernel.org/krzk/linux-dt/c/345531df1cf864bbdba8d5a31c0b5519296c39cc
[2/4] arm64: dts: uniphier: ld11-global: drop audio codec port unit address
https://git.kernel.org/krzk/linux-dt/c/2e2798377b8b086832512dc4826b1b4c6a59aa2b
[3/4] arm64: dts: uniphier: ld20-global: use generic node name for audio-codec
https://git.kernel.org/krzk/linux-dt/c/e505949abaa4f616b166430719767867ce26bdc6
[4/4] arm64: dts: uniphier: ld20-global: drop audio codec port unit address
https://git.kernel.org/krzk/linux-dt/c/63252893550f75389616d24731c0c6051bb16a77
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec
2024-04-24 6:54 ` [PATCH 1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec Krzysztof Kozlowski
@ 2024-04-25 0:12 ` Kunihiko Hayashi
0 siblings, 0 replies; 6+ messages in thread
From: Kunihiko Hayashi @ 2024-04-25 0:12 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Conor Dooley, Krzysztof Kozlowski, Masami Hiramatsu,
devicetree, linux-arm-kernel, linux-kernel, Krzysztof Kozlowski
Hi Krzysztof,
On 2024/04/24 15:54, Krzysztof Kozlowski wrote:
>
> On Mon, 01 Apr 2024 16:09:49 +0200, Krzysztof Kozlowski wrote:
>> Devicetree specification expects node names to be generic, representing
>> the class of devices.
>>
>>
>
> Almost a month passed, no replies from maintainers about picking it up.
> Dunno,
> looks abandoned, so let me grab this. If anyone else wants to pick it up,
> let
> me know.
Sorry, I couldn't reply your patches due to some problems.
They looks to me, so you can keep on picking them up.
Thank you,
---
Best Regards
Kunihiko Hayashi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread