From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04CCFCD128D for ; Mon, 1 Apr 2024 15:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PdcCSB0H9j9Qbu5PnN129eZwBjR6OAtU5zEWje89hW0=; b=tGXbTFUied4yY/ xqZcM5pDnBsMv58cxKWjBjB1VkaxZDvDx9Os4EYMb30MI24o79G97dl/2kXRMElJCLvkNmSQQXJJR dm70qMFOdFmH0W1TqDXdpamYcfaG3NEm0vE7CC7C8FAYuzCRQUo9QI8aZuGGkEz578rQ2Euq/nwt3 EJ4K7J969P7zwYkDDSwuXrNFy72AdHh7alv1vEJBALPXJkH+/NX4BvDO7kzOPrMJYSfchKnVO6m9/ W5HnVs6HXYNZdRVBPiaLEMzKBhLTyvTrvSHq6IoXx0BJ9jgyChegmpPW+8xIvNn0kejtsIj2o3cle gGiAAlySQOUyIkbfPSeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk8-00000008DFv-1b7B; Mon, 01 Apr 2024 15:38:40 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk5-00000008DCa-0wgi for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7F6CCCE12C8; Mon, 1 Apr 2024 15:38:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81A64C433F1; Mon, 1 Apr 2024 15:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985914; bh=JgLPnjcMi+cgOhiaoTMdhKoBzbHBbs/okfQQvGNTcdo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CjVuAT65buqs99kvAaD4vV94P1Z5W+QmUpw+nssp3dWlIHCTFraFjdqPWWxVQRGw3 m3lUXSpzMVIk6ozny/7UwF2viG+zgGQtd+fGPLA4vaqg1C+8iVV+7wt5MofHNXZwW4 CoL6sFuScW9fV+I+45WhBZ/yg3rRAjXCHJvyajrbeOtHlmFwdouhYy1fqGwDq8iTsW 7WBET5EkFWOoZujUtfi0s4NpRcp5vk93+WdHm443aqw0rK7OU1bS8fbman6M4eOc36 pp7Dp6yOI1+ieVWPUXOj4hAvphsLiK/zsHx34SDS2WWQNAE0WWu6EJk+ynNlsteIH1 jX7CX5Zq5WG6g== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFT 10/10] arm64: dts: microchip: sparx5_pcb135: drop duplicated NOR flash Date: Mon, 1 Apr 2024 17:37:40 +0200 Message-Id: <20240401153740.123978-10-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_083837_508116_47F5C360 X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since beginning the DTS extended the SPI0 in two places adding two SPI muxes, each with same SPI NOR flash. Both used exactly the same chip-selects, so this was clearly buggy code. Without checking in datasheet, assume device has only one SPI NOR flash, so code was duplicated. Fixes dtc W=1 warnings: sparx5_pcb135_board.dtsi:92.10-96.4: Warning (unique_unit_address_if_enabled): /axi@600000000/spi@600104000/flash@0: duplicate unit-address (also used in node /axi@600000000/spi@600104000/spi@0) Signed-off-by: Krzysztof Kozlowski --- Not tested on hardware --- .../boot/dts/microchip/sparx5_pcb135_board.dtsi | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi index 20016efb3656..d64e642e3873 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi @@ -96,22 +96,6 @@ flash@0 { }; }; -&spi0 { - status = "okay"; - spi@0 { - compatible = "spi-mux"; - mux-controls = <&mux>; - #address-cells = <1>; - #size-cells = <0>; - reg = <0>; /* CS0 */ - flash@9 { - compatible = "jedec,spi-nor"; - spi-max-frequency = <8000000>; - reg = <0x9>; /* SPI */ - }; - }; -}; - &sgpio1 { status = "okay"; microchip,sgpio-port-ranges = <24 31>; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel