From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB275C6FD1F for ; Tue, 2 Apr 2024 17:47:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FskUFjEuNslChVDb2FH7Pgsz2ZWTYvfh5UuJFbWMKeA=; b=2LqwO3qVQeTWArsspSPViTmqA7 eGo2F2UV6eSXJxLVi5vj3noQFCKx6q3TDDI0Hxj2K+BmeZYxsaa9xA29z3jlcqaM6iRk7enXoHRfN cIvlYCbJdKr2DuqJ6udTgFIcfvdSkZLEtOeRJKiS9zobpbV1egKKOI2BegMaBj0hMeMv+UqzMOJNO ZhBDruUVYScD2Lw9NNliKOBO/eDdf5y+Xl6aonGTbxMEmwTUKKlO4STqXggcd/m2pwCS2OQFt8hdt WIufOuNmrDDlW5QiuQVBp2R0HYzmPigEVKCT+RvpO0u0d5wGW7lRLWKnpMDDZgreGBx9bXxVe9lXs smR4ngWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rriE4-0000000CFda-07dh; Tue, 02 Apr 2024 17:47:12 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rriDx-0000000CFZX-193a for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 17:47:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4886ACE1CC9; Tue, 2 Apr 2024 17:47:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADB79C433C7; Tue, 2 Apr 2024 17:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712080022; bh=6qtbcXbgPT258MwDHIMMVnVJMOfvk/DPTeiD+9wwTxE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fi/8z9ryH9DA63j38wP2nPgPrAlEmUb4Q0Y0T69imsrnRqrdzITdr/fahb11gp21z KKN1E2imygXDCPznJnJs0qFcZ6u0GtXA5S4QR8pMQjPywi5vdYFThIjdkihZ4Lsee3 yosHVJqIi0WM4MlahhuZ4ol6ZR/30P3YjrPX9FK/AeU6gwD5HFkl3OmydvHeI1goQv g8Uk2J5t3NiwUkA6pkvWyVfvFmK/jV1c3LLFmv/WFdkREZ2hlVAC4ig/eWtW2+yT10 E9XBQNfNr3krf4eJ9C6bRHdXMqJA8OZNTKY3OUnnbAQJaRNEo6LYliSe0QHYwy8Wm0 6w2IpUAJiOfIg== Date: Tue, 2 Apr 2024 18:46:57 +0100 From: Conor Dooley To: Steen Hegelund Subject: Re: [PATCH RFT 01/10] arm64: dts: microchip: sparx5: fix mdio reg Message-ID: <20240402-drizzly-risotto-eac556bbe95b@spud> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_104705_704577_0890A6F2 X-CRM114-Status: GOOD ( 27.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Daniel Machon , Bjarni Jonasson , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Claudiu Beznea , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , UNGLinuxDriver@microchip.com, "David S. Miller" , Lars Povlsen Content-Type: multipart/mixed; boundary="===============7327002826045739904==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7327002826045739904== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RilKgIjVf/M7rXnH" Content-Disposition: inline --RilKgIjVf/M7rXnH Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, On Tue, Apr 02, 2024 at 04:00:32PM +0200, Steen Hegelund wrote: > On Mon, 2024-04-01 at 17:37 +0200, Krzysztof Kozlowski wrote: > > [Some people who received this message don't often get email from > > krzk@kernel.org. Learn why this is important at > > https://aka.ms/LearnAboutSenderIdentification=A0] > >=20 > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > >=20 > > Correct the reg address of mdio node to match unit address.=A0 Assume > > the > > reg is not correct and unit address was correct, because there is > > alerady node using the existing reg 0x110102d4. > >=20 > > =A0 sparx5.dtsi:443.25-451.5: Warning (simple_bus_reg): > > /axi@600000000/mdio@6110102f8: simple-bus unit address format error, > > expected "6110102d4" > >=20 > > Fixes: d0f482bb06f9 ("arm64: dts: sparx5: Add the Sparx5 switch > > node") > > Signed-off-by: Krzysztof Kozlowski > >=20 > > --- > >=20 > > Not tested on hardware > > --- > > =A0arch/arm64/boot/dts/microchip/sparx5.dtsi | 2 +- > > =A01 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > index 24075cd91420..5d820da8c69d 100644 > > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > @@ -447,7 +447,7 @@ mdio2: mdio@6110102f8 { > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 p= inctrl-names =3D "default"; > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 #= address-cells =3D <1>; > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 #= size-cells =3D <0>; > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 reg= =3D <0x6 0x110102d4 0x24>; > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 reg= =3D <0x6 0x110102f8 0x24>; > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 }; > >=20 > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 mdio3: mdio@61101031c { > > -- > > 2.34.1 > >=20 >=20 > I did a check of our current Sparx5 EVBs and none of them uses > controller 2 in any revision, so this is probably why it has not come > up before, so as it stands we have no platform to test this change on > currently. >=20 > Besides that the change looks good to me. >=20 > Best Regards > Steen >=20 > Reviewed-by: Steen Hegelund Are you okay with the rest of the series, or have you only looked at this one patch? --RilKgIjVf/M7rXnH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZgxEkQAKCRB4tDGHoIJi 0lSrAQCZbgAp+hHzEbAZUy5ZEACDMf4lJMuQXFA1tS+/Cwh2vgEA/UsYcqeBcYpx rn636eS2o+9iXzVq75hhahrnTAKyjAA= =1JM2 -----END PGP SIGNATURE----- --RilKgIjVf/M7rXnH-- --===============7327002826045739904== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7327002826045739904==--