From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51929CD1284 for ; Tue, 2 Apr 2024 16:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2T34MO7I4jNm6VZgJR/DtHW/PGoEUoxZ6TNJjyWG3zo=; b=2T5WFNQRsdReVQ +Wyoqy5t9+36qSufTLfKxXVVYcB+DlIjFpeeyAxEkFCShvpFecuevy66u75fm/yvZ7HfekqWUudB7 wCYxwzI1U7WlvDV0gZTUt8r2/+RPKDEFV7adMudBquyhsA+ZAVlI19Ms1t5FJpyrAfJ+/ysK+6iCe DjLLvScGZq9wldwFgte3pSSGbofTzC1KbgLBnOTx3R0/9aLTzJSwzYPWpvAm0WZ4RFUiMAMQ1QCVF WqJqnXaiG6mUggmiMPPyzHa5N7h8Km7hrzK55fTKOC/Cp565FlPOU5ZhJazXbMHmYAWEwzYSzB9jY FvtTRoElAbb4LeJShfOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrhT8-0000000C8KK-0uXb; Tue, 02 Apr 2024 16:58:42 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrhT5-0000000C8Iz-1EI2 for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 16:58:40 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 2C3601FE3C; Tue, 2 Apr 2024 18:58:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1712077108; bh=utzYA5Fyh93RENun8mB8vS2Q+ce6cCxI3nfBu0JZLuQ=; h=From:To:Subject; b=XZg5fpzWJVjLjWUgVBHzBN3Lf4Xij4d/DO/83txUtyC96G7UJ8KGQBnmKxhaWOtws N7NKacSxaMn44EQlJojNvJFu50IgdKTmi0Jug3rDfV20lClorRfJ11DR9DptVapvWl Fs3fh693ovE+QOiv87lOIhkwN4Lwr6UiTuzVR8n5U6QBfL7CAg6ZO4GIiaWVUWb065 7pr/oAJavB8cqnTIC0kFvln/KZk1/hpM9WK+5JyHl0LUXrSZPlSwSxy1jdf1vp+RC7 qbacOxptg7mgrUvbR8aYwu+8DXZEwewAIvfT3uGz3C0+7IQZmuC1fmep/UdazNNRpo /+LR6uq7BPkYg== Date: Tue, 2 Apr 2024 18:58:24 +0200 From: Francesco Dolcini To: Michael Walle Cc: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: ti: k3-j722s: Disable ethernet ports by default Message-ID: <20240402165824.GA32125@francesco-nb> References: <20240402151802.3803708-1-mwalle@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240402151802.3803708-1-mwalle@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_095839_499199_9D0DEEE8 X-CRM114-Status: GOOD ( 19.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Michael, On Tue, Apr 02, 2024 at 05:18:02PM +0200, Michael Walle wrote: > Device tree best practice is to disable any external interface in the > dtsi and just enable them if needed in the device tree. Thus, disable > both ethernet ports by default and just enable the one used by the EVM > in its device tree. > > There is no functional change. > > Signed-off-by: Michael Walle > --- > This should also be true for all the other SoCs. But I don't wanted to > touch all the (older) device trees. j722s is pretty new, so there we > should get it right. > --- > arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 5 +---- > arch/arm64/boot/dts/ti/k3-j722s.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > index d045dc7dde0c..afe7f68e6a4b 100644 > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > @@ -224,14 +224,11 @@ cpsw3g_phy0: ethernet-phy@0 { > }; > > &cpsw_port1 { > + status = "okay"; status should be the last property, according to the dts coding guidelines. > phy-mode = "rgmii-rxid"; > phy-handle = <&cpsw3g_phy0>; > }; Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel