From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9876CD128A for ; Wed, 3 Apr 2024 16:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xetNDEd2R2bHnQomAt10QmPLbhJqPMuy7dJyLXZpVNE=; b=tvo/MAuxMWW/kG1XwbWtMzjw5t oK96Jseo85gdqbgZL4OuWxqsNe9ksKG6zKBX+maUcyHUW9U6vaROcr9f3yhX8P+xoHgOaYdevpeZD rD8l2oDfre4pAjY4s49+0I2kSGp6wi/WXhWIF0iNye2P6OC9wytJdzpqQn/2q8SvaKAT+ejndbtpg OVXzvpffBZaYoBLCdW0mSuokLecUNFm7G6jMfxAqrT6fFXrnFbJ3XuzV+D61gecJi2Gr+2dG3wUGn 3wpGlxwb4X8XFZcOYi0OQgalhtslq7GZwjTAYDAeuh3vgB1h+fPnwlGE3u+0sN54ItjStxVF68oWu JD1/lFLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs3GO-0000000Gv65-1799; Wed, 03 Apr 2024 16:15:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs3GK-0000000Gv53-3zQu for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 16:14:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B95F2614A2; Wed, 3 Apr 2024 16:14:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B015DC433F1; Wed, 3 Apr 2024 16:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712160895; bh=Dw4TMcgMCYmhY8DkUmtF9XK+klTwM7RxE/GPJ5ycJF0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q+LnZsIa2JGGoV12cX3ZMFQhd29l75NesZeX4wzM5ZgtWKEXLDNztOOzWr/GFhev1 tE1H+SaIbAdpnugrYIgh6WzbcOp6E++9hG5TeVmT08B589T+ncsXxX68JxxZ80XJIT qAym+sr7rBOxZWGcWmPQPZXd1+F+lodeNob5iXBbn2aLh3XHAY/Mc6nLnnN9RSmFWD dSocGzn7mou1RMW/gV5GCp3DPFDxCi4EO5Y9QU50YdMEu4XHD4Lll9+xBJBA4jurGO ocpL8tD168CUWyUqz7acBtK5wIm2oe/mOcVoypANl6/J4V6Fk0Q6RJpl0wVl8HiSA+ fdh54vM0/5inA== Date: Wed, 3 Apr 2024 17:14:49 +0100 From: Conor Dooley To: git@luigi311.com Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org Subject: Re: [PATCH v3 18/25] dt-bindings: media: imx258: Add alternate compatible strings Message-ID: <20240403-vista-defendant-ebadbaa52059@spud> References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-19-git@luigi311.com> MIME-Version: 1.0 In-Reply-To: <20240403150355.189229-19-git@luigi311.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_091457_117413_A9782C3E X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2156433033655680668==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2156433033655680668== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dTboEyzG/5e2UTpE" Content-Disposition: inline --dTboEyzG/5e2UTpE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 03, 2024 at 09:03:47AM -0600, git@luigi311.com wrote: > From: Dave Stevenson >=20 > There are a number of variants of the imx258 modules that can not > be differentiated at runtime, so add compatible strings for the > PDAF variant. >=20 > Signed-off-by: Dave Stevenson > Signed-off-by: Luis Garcia > --- > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml= b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > index bee61a443b23..c978abc0cdb3 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > @@ -13,11 +13,16 @@ description: |- > IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active p= ixel > type stacked image sensor with a square pixel array of size 4208 x 312= 0. It > is programmable through I2C interface. Image data is sent through MIPI > - CSI-2. > + CSI-2. The sensor exists in two different models, a standard variant > + (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). > + The camera module does not expose the model through registers, so the > + exact model needs to be specified. > =20 > properties: > compatible: > - const: sony,imx258 > + enum: > + - sony,imx258 > + - sony,imx258-pdaf Does the pdaf variant support all of the features/is it register compatible with the regular variant? If it is, the regular variant should be a fallback compatible. Cheers, Conor. --dTboEyzG/5e2UTpE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZg2AeQAKCRB4tDGHoIJi 0g9GAP9MN2G2glo0Nhr4UByr3u4eG2VrUcxCMe2B4Uzd1ErwTQEA7j5t7hgUL0mU pr1/uez8k5GMNQNEpwMErPYIlusOjw8= =KKOZ -----END PGP SIGNATURE----- --dTboEyzG/5e2UTpE-- --===============2156433033655680668== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2156433033655680668==--