From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62E95C6FD1F for ; Wed, 3 Apr 2024 07:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+OztbSzj5/TeUt7Q1DG3hg17nxQ5uM5i9gpp611TKyw=; b=zhFzL7PZs9djz1 njyGo18L8WLA/GvWhppxCZqo0LgKT7Laad2sD5k5TDpIxrPVn9InzDjadbgIFagLNklExwVg6m/Pf ujxJfDhTJjO57N/9ejezKGluTd3ORj2VuFmYq0chWzhPb8vlc6V3TCPYAxkIHGN4lCY6L5f2Lhscv X7cW623ZFTudFbv/BE+BrbBlMUiwOFj8Vd5sM3dQM2T5caOyd3dj/DaTMOaKjjUWJ9I5U3p2I2/Qi 8yhyKchXx0ow+i6C72DhXIThP3x3AxYmlZMNbVNtjxfaJ41b+rY88lxzl3L91j+LXCi36MOpiiQxH M0BPNEUdVUyKP2SW1j6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrv9q-0000000EYIO-1cFw; Wed, 03 Apr 2024 07:35:42 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrv9n-0000000EYEc-0thc for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 07:35:40 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F19883A3; Wed, 3 Apr 2024 09:34:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712129699; bh=kUuJoXklxwcVwYwh1KHqc0nVIfvCjiFCTE9UekJ4cYM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iIF4Aq58HBl0RTO5peg/bN8ERJVlXfVrXuN8Uo81fvXk/u6uesH5p7gBoXk20+xsx S4VA4T+OYQWbQuwXcsXdMY7elsjdcIHNiLgVPh0wBbWoVLxAW7wj2SJ1+COkU5JcTj d9jFjOgb8tFAqtZ0/niXe+gje1Oa7CPjnrSDP3hU= Date: Wed, 3 Apr 2024 10:35:24 +0300 From: Laurent Pinchart To: Francesco Dolcini Cc: Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Trevor Zaharichuk , Greg Lytle , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit Message-ID: <20240403073524.GK16740@pendragon.ideasonboard.com> References: <20240325203245.31660-1-laurent.pinchart@ideasonboard.com> <20240325203245.31660-6-laurent.pinchart@ideasonboard.com> <20240403070651.GB5070@francesco-nb> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240403070651.GB5070@francesco-nb> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_003539_534950_59C7D08D X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 03, 2024 at 09:06:51AM +0200, Francesco Dolcini wrote: > Hello Laurent, > > On Wed, Apr 03, 2024 at 08:30:11AM +0800, Shawn Guo wrote: > > On Mon, Mar 25, 2024 at 10:32:45PM +0200, Laurent Pinchart wrote: > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts > > > new file mode 100644 > > > index 000000000000..2d1c8e782465 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts > > > @@ -0,0 +1,236 @@ > > [...] > > > > +/* Verdin I2C_2_DSI */ > > > +&i2c2 { > > > + status = "okay"; > > > + > > > + clock-frequency = <400000>; > > > + scl-gpios = <&gpio5 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > > > + sda-gpios = <&gpio5 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > > > > We usually end property list with 'status'. > > This is now a written and explicit guideline, no longer tribal knowledge, > see https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node Thanks. Any chance to teach checkpatch.pl (and/or the DT checker) about that ? :-) -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel