From: git@luigi311.com
To: linux-media@vger.kernel.org
Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com,
mchehab@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
sakari.ailus@linux.intel.com, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, pavel@ucw.cz,
phone-devel@vger.kernel.org, Luis Garcia <git@luigi311.com>,
Ondrej Jirman <megous@megous.com>
Subject: [PATCH v3 24/25] drivers: media: i2c: imx258: Add support for reset gpio
Date: Wed, 3 Apr 2024 09:03:53 -0600 [thread overview]
Message-ID: <20240403150355.189229-25-git@luigi311.com> (raw)
In-Reply-To: <20240403150355.189229-1-git@luigi311.com>
From: Luis Garcia <git@luigi311.com>
It was documented in DT, but not implemented.
Signed-off-by: Ondrej Jirman <megous@megous.com>
Signed-off-by: Luis Garcia <git@luigi311.com>
---
drivers/media/i2c/imx258.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index 163f04f6f954..4c117c4829f1 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -680,6 +680,7 @@ struct imx258 {
unsigned int csi2_flags;
struct gpio_desc *powerdown_gpio;
+ struct gpio_desc *reset_gpio;
/*
* Mutex for serialized access:
@@ -1232,7 +1233,11 @@ static int imx258_power_on(struct device *dev)
regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies);
}
- return ret;
+ gpiod_set_value_cansleep(imx258->reset_gpio, 0);
+
+ usleep_range(400, 500);
+
+ return 0;
}
static int imx258_power_off(struct device *dev)
@@ -1243,6 +1248,7 @@ static int imx258_power_off(struct device *dev)
clk_disable_unprepare(imx258->clk);
regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies);
+ gpiod_set_value_cansleep(imx258->reset_gpio, 1);
gpiod_set_value_cansleep(imx258->powerdown_gpio, 1);
return 0;
@@ -1554,6 +1560,12 @@ static int imx258_probe(struct i2c_client *client)
if (IS_ERR(imx258->powerdown_gpio))
return PTR_ERR(imx258->powerdown_gpio);
+ /* request optional reset pin */
+ imx258->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset",
+ GPIOD_OUT_HIGH);
+ if (IS_ERR(imx258->reset_gpio))
+ return PTR_ERR(imx258->reset_gpio);
+
/* Initialize subdev */
v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops);
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-03 15:28 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 15:03 [PATCH v3 00/25] imx258 improvement series git
2024-04-03 15:03 ` [PATCH v3 01/25] media: i2c: imx258: Remove unused defines git
2024-04-03 15:03 ` [PATCH v3 02/25] media: i2c: imx258: Make image geometry meet sensor requirements git
2024-04-03 15:03 ` [PATCH v3 03/25] media: i2c: imx258: Disable digital cropping on binned modes git
2024-04-03 15:03 ` [PATCH v3 04/25] media: i2c: imx258: Remove redundant I2C writes git
2024-04-03 15:03 ` [PATCH v3 05/25] media: i2c: imx258: Add regulator control git
2024-04-03 18:44 ` Pavel Machek
2024-04-06 5:23 ` Luis Garcia
2024-04-03 15:03 ` [PATCH v3 06/25] media: i2c: imx258: Make V4L2_CID_VBLANK configurable git
2024-04-03 15:03 ` [PATCH v3 07/25] media: i2c: imx258: Split out common registers from the mode based ones git
2024-04-03 15:03 ` [PATCH v3 08/25] media: i2c: imx258: Add support for 24MHz clock git
2024-04-03 15:03 ` [PATCH v3 09/25] media: i2c: imx258: Add support for running on 2 CSI data lanes git
2024-04-03 18:45 ` Pavel Machek
2024-04-06 5:25 ` Luis Garcia
2024-04-07 8:51 ` Kieran Bingham
2024-04-03 15:03 ` [PATCH v3 10/25] media: i2c: imx258: Follow normal V4L2 behaviours for clipping exposure git
2024-04-03 18:45 ` Pavel Machek
2024-04-03 19:14 ` Luigi311
2024-04-03 15:03 ` [PATCH v3 11/25] media: i2c: imx258: Add get_selection for pixel array information git
2024-04-03 18:46 ` Pavel Machek
2024-04-06 6:36 ` Luis Garcia
2024-04-09 5:23 ` Luis Garcia
2024-04-03 15:03 ` [PATCH v3 12/25] media: i2c: imx258: Allow configuration of clock lane behaviour git
2024-04-03 18:48 ` Pavel Machek
2024-04-04 22:29 ` Luigi311
2024-04-05 9:54 ` Pavel Machek
2024-04-03 15:03 ` [PATCH v3 13/25] media: i2c: imx258: Correct max FRM_LENGTH_LINES value git
2024-04-03 15:03 ` [PATCH v3 14/25] media: i2c: imx258: Issue reset before starting streaming git
2024-04-03 15:03 ` [PATCH v3 15/25] media: i2c: imx258: Set pixel_rate range to the same as the value git
2024-04-03 15:03 ` [PATCH v3 16/25] media: i2c: imx258: Support faster pixel rate on binned modes git
2024-04-03 15:03 ` [PATCH v3 17/25] dt-bindings: media: imx258: Rename to include vendor prefix git
2024-04-03 15:03 ` [PATCH v3 18/25] dt-bindings: media: imx258: Add alternate compatible strings git
2024-04-03 16:14 ` Conor Dooley
2024-04-05 10:25 ` Dave Stevenson
2024-04-05 16:24 ` Conor Dooley
2024-04-05 16:24 ` Conor Dooley
2024-04-09 14:12 ` Rob Herring
2024-04-03 15:03 ` [PATCH v3 19/25] media: i2c: imx258: Change register settings for variants of the sensor git
2024-04-03 16:18 ` Sakari Ailus
2024-04-04 22:44 ` Luigi311
2024-04-05 10:59 ` Sakari Ailus
2024-04-05 13:16 ` Dave Stevenson
2024-04-10 8:44 ` Sakari Ailus
2024-04-03 15:03 ` [PATCH v3 20/25] media: i2c: imx258: Make HFLIP and VFLIP controls writable git
2024-04-03 15:03 ` [PATCH v3 21/25] drivers: media: i2c: imx258: Use macros git
2024-04-03 16:23 ` Sakari Ailus
2024-04-03 19:17 ` Luigi311
2024-04-04 6:46 ` Sakari Ailus
2024-04-05 10:33 ` Luis Garcia
2024-04-05 14:11 ` Tommaso Merciai
2024-04-06 5:21 ` Luis Garcia
2024-04-03 15:03 ` [PATCH v3 22/25] dt-bindings: media: imx258: Add binding for powerdown-gpio git
2024-04-03 17:38 ` Krzysztof Kozlowski
2024-04-03 18:49 ` Pavel Machek
2024-04-03 19:26 ` Luigi311
2024-04-15 17:20 ` Luis Garcia
2024-04-04 6:47 ` Sakari Ailus
2024-04-03 15:03 ` [PATCH v3 23/25] drivers: media: i2c: imx258: Add support for powerdown gpio git
2024-04-03 16:25 ` Sakari Ailus
2024-04-03 16:57 ` Ondřej Jirman
2024-04-03 19:34 ` Luigi311
2024-04-04 14:12 ` Dave Stevenson
2024-04-04 23:18 ` Luis Garcia
2024-04-04 7:07 ` Sakari Ailus
2024-04-03 15:03 ` git [this message]
2024-04-03 16:28 ` [PATCH v3 24/25] drivers: media: i2c: imx258: Add support for reset gpio Sakari Ailus
2024-04-03 17:03 ` Ondřej Jirman
2024-04-03 19:48 ` Luigi311
2024-04-03 15:03 ` [PATCH v3 25/25] media:i2c: imx258: Use v4l2_link_freq_to_bitmap helper git
2024-04-03 18:50 ` [PATCH v3 00/25] imx258 improvement series Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403150355.189229-25-git@luigi311.com \
--to=git@luigi311.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=megous@megous.com \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).