From: Rob Herring <robh@kernel.org>
To: Hiago De Franco <hiagofranco@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Hiago De Franco <hiago.franco@toradex.com>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/4] dt-bindings: arm: fsl: remove reduntant toradex,colibri-imx8x
Date: Wed, 3 Apr 2024 11:57:21 -0500 [thread overview]
Message-ID: <20240403165721.GA3980362-robh@kernel.org> (raw)
In-Reply-To: <20240402193512.240417-3-hiagofranco@gmail.com>
On Tue, Apr 02, 2024 at 04:35:10PM -0300, Hiago De Franco wrote:
> From: Hiago De Franco <hiago.franco@toradex.com>
>
> 'toradex,colibri-imx8x' is already present as a constant value for
> 'i.MX8QP Board with Toradex Colibri iMX8X Modules', so there is no need
> to keep it twice as a enum value for 'i.MX8QXP based Boards'.
If the module can operate on its own, then it would be valid to have
just "toradex,colibri-imx8x". If not, then:
Acked-by: Rob Herring <robh@kernel.org>
>
> Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 0027201e19f8..6fdfa10af43c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1218,7 +1218,6 @@ properties:
> - enum:
> - einfochips,imx8qxp-ai_ml # i.MX8QXP AI_ML Board
> - fsl,imx8qxp-mek # i.MX8QXP MEK Board
> - - toradex,colibri-imx8x # Colibri iMX8X Modules
> - const: fsl,imx8qxp
>
> - description: i.MX8DXL based Boards
> --
> 2.39.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-03 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 19:35 [PATCH v1 0/4] arm64: dts: freescale: Add Toradex Colibri iMX8DX Hiago De Franco
2024-04-02 19:35 ` [PATCH v1 1/4] arm64: dts: freescale: Add i.MX8DX dtsi Hiago De Franco
2024-04-02 19:35 ` [PATCH v1 2/4] dt-bindings: arm: fsl: remove reduntant toradex,colibri-imx8x Hiago De Franco
2024-04-03 16:57 ` Rob Herring [this message]
2024-04-04 8:02 ` Francesco Dolcini
2024-04-02 19:35 ` [PATCH v1 3/4] dt-bindings: arm: fsl: Add Colibri iMX8DX Hiago De Franco
2024-04-03 16:58 ` Rob Herring
2024-04-02 19:35 ` [PATCH v1 4/4] arm64: dts: freescale: Add Toradex " Hiago De Franco
2024-04-03 14:15 ` [PATCH v1 0/4] " Rob Herring
2024-04-22 3:24 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403165721.GA3980362-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hiago.franco@toradex.com \
--cc=hiagofranco@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).