From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E27EACD128A for ; Wed, 3 Apr 2024 17:13:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xYAmCf8lC2QKUk/ArXBtKDtP/lWLU21XTtIhoFsLkoc=; b=jxMx/EeuAr2N0a GdxTvq4kbTUJE8OOALkToaRHjoSnP2ta3e06g1MnExyHEMusVFf12wPYIFFnD+KL5OBIOgQzRulaX kWH6RNTkil9pbYWm6zLJOugdBJkxx0JXL+XBfaqp6a1O1ZgJecKPrIohzs2dQcBR1PeNDlGwtkHk0 hajYtROgChwjKCsC8VSocbBEYhx7J62pRJAl/iJ8litOhL4hJS/FwFSMi9/vDtMp7M6hHBDMSdq6W QEOWdyqCYuSKXI0qg2cUR4bHH1YvEZq/yzTVYmRIUL/UaIO8ZrCxSM/ZYP2DSB8kQ488gW2+FctXb 02s34rjzecPIWzvUpd3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs4B0-0000000H70V-1jMj; Wed, 03 Apr 2024 17:13:30 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs4Aw-0000000H6zX-3OrT for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 17:13:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 62890CE29E6; Wed, 3 Apr 2024 17:13:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 639AFC433F1; Wed, 3 Apr 2024 17:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712164403; bh=iDTAlDyhhR24NhTX+LufgKRCpVJp7F5FVJPBKNDeZXg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tb5w0YDGe4x+imn77oCq7en/5vXnu1PuX2SN6Yqg+ZNVugpAHzKHObawruVxu5sVX IBzzZhKicpNFzkAWWF0aed24aA3Ed99diLIAIjUDDY/ToweyWoiCNH/EJ3ImFBnOYo oYjQq8oSJb4st8TstbqOakzA2cntQfiMmDogL9bEtNnnIsCOoVdfRif8RtEvjghM1Q lzO4XQP/rlgL7DE+klootx5667C7jOoof9fcdk881uoRfpCIAB3vZX1JspBLBu3Sf5 kUoYcuXIlLpN+CA72QAVnK6v/RfUwOzSjuE+H3PxOwtc9NFiyZsePxcZlTx7ronxCS 4W05MzHEeYVdg== Date: Wed, 3 Apr 2024 12:13:21 -0500 From: Rob Herring To: Andrew Jeffery Cc: wim@linux-watchdog.org, linux@roeck-us.net, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, zev@bewilderbeest.net, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dt-bindings: watchdog: aspeed,ast2400-wdt: Convert to DT schema Message-ID: <20240403171321.GA3996007-robh@kernel.org> References: <20240403020439.418788-1-andrew@codeconstruct.com.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240403020439.418788-1-andrew@codeconstruct.com.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_101327_048986_8327AA73 X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 03, 2024 at 12:34:39PM +1030, Andrew Jeffery wrote: > Squash warnings such as: > > ``` > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-galaxy100.dtb: /ahb/apb@1e600000/watchdog@1e785000: failed to match any schema with compatible: ['aspeed,ast2400-wdt'] > ``` > > The schema binding additionally defines the clocks property over the > prose binding to align with use of the node in the DTS files. > > Signed-off-by: Andrew Jeffery > --- > v2: Address feedback from Rob and Zev > > - Rob: https://lore.kernel.org/linux-watchdog/20240402180718.GA358505-robh@kernel.org/ > - Zev: https://lore.kernel.org/linux-watchdog/65722a59-2e94-4616-81e1-835615b0e600@hatter.bewilderbeest.net/ > > v1: https://lore.kernel.org/linux-watchdog/20240402120118.282035-1-andrew@codeconstruct.com.au/ > > .../bindings/watchdog/aspeed,ast2400-wdt.yaml | 142 ++++++++++++++++++ > .../bindings/watchdog/aspeed-wdt.txt | 73 --------- > 2 files changed, 142 insertions(+), 73 deletions(-) > create mode 100644 Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml > delete mode 100644 Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml > new file mode 100644 > index 000000000000..be78a9865584 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml > @@ -0,0 +1,142 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/aspeed,ast2400-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aspeed watchdog timer controllers > + > +maintainers: > + - Andrew Jeffery > + > +properties: > + compatible: > + enum: > + - aspeed,ast2400-wdt > + - aspeed,ast2500-wdt > + - aspeed,ast2600-wdt > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: > You don't need '>' either. I guess it is equivalent here as there are no double newlines. Drop these if you respin, otherwise: Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel