From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA03DCD128A for ; Wed, 3 Apr 2024 18:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=r3lyfx5GhMVRA6hiXevVun9BgCoENGG1d/RKlRz+jfE=; b=PiohzUGeqM0G5K PWNz8/mGh7q8vbl/49l2LVie6SYQQJqRqlBY/ToBur56oGtzIb0uZ8+2A0yl7PDOcYPmiW3Zq0b8F aMbAr0wZJOOvxppkvFmwb0i4J9kWKHzP+jbQ++ndMGCUYHpFuTdm48OPG5WcNY4mySE54JuFWs6Pd 0tzcrHzqvZkAapYTnH/BA0ASC0OIcTiPWw3f6mRau4BssW8x/TwImwoJv+CyLT3fj6gCQs4akjZ96 yAJ6W0RGgo0NgPtSHc/m7gwgphgus/7KsB/1zTZiQyTAUqYRSkz9iV1sFq/xP7Pzb14YXGVNDi2qD Ngp2O0hkdkG8WeM9Zh8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs5JV-0000000HOF9-2aqE; Wed, 03 Apr 2024 18:26:21 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs5JO-0000000HOCC-2zKM for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 18:26:16 +0000 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6ea7f2d093aso82491b3a.3 for ; Wed, 03 Apr 2024 11:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712168772; x=1712773572; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+KM0sALA3G00DhEkgIr0nJ9/xgi6K5DMXyrZsidqXcY=; b=NkOBe2k6N75aIvXtMqn54c9xetiROAWe3NWewv0A5p3QgzadB7t28T1r6wtxt2C6rM MWlVCUHcTyolkj7Al8qhUplC8aXgVS2LoyKZR8OB1zTQxeOTI+WW23r5AeUkCEzzjxWz J0oPdrh1jh1pz4t+gX9K8K9Po0NbHk9RABpL1BG13gWVzgIl1JU/3N88fSKWmGQ2HjmP 3XXbi0IVypjGZFo5sEMX4PDDsk7ZFrS1KeVpxILBFgKRWr8oW0HP8bDXLvRshg6E/t03 APBjdnSV40bzznV0ZpNaaQU6BHguGVGYYUS12G0y0ukFZtM5FsxvlXrGce9W0dAYYSPO xnlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712168772; x=1712773572; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+KM0sALA3G00DhEkgIr0nJ9/xgi6K5DMXyrZsidqXcY=; b=IR14wd2kh886M9/EwWJ4QsrqTfdbFxng1vcXUG1EFYhmkwPWXgR27zc3DAtv9SFP6o 0BXQr7uMeM+mfh9H1ES8qnQ+OXCkMl7AxsFobw3YpGdd0xGIy+qMZubvLtBvOPVvveX9 B1EgHEL+9Y/yDM4q+AKvRlAMpz8lbzEwdgpnwsIy4dngraV1GDKL4vpeG8UcYaJoH2GF jS4095RB+15zlMt8smACyKw/PI4D8HdDnbmuxq4OY+0ssJpGvh+tz+UGc3lfAj/7XWDw 4WxSapzVkoB1zDqtkpF7odP6bnqgOKpKO7/H7rGyWkDLWVAS7yvIdjc7nDVM634RkYKY Q2nw== X-Forwarded-Encrypted: i=1; AJvYcCUdTjOBrz8oJTCkUbdlDJ2Pg9NCrYov4xowyOAFjY+UqKVHMMSCmqDC55qoOibXEE+hu1UyC3VVowXJz3sU+3CsPikWa9zayRG7P/WqLu5vBJSSasc= X-Gm-Message-State: AOJu0YzsY/BTPmIk/Mk/MzI5io8cicWazbDAuF6lx/a0xmXOPzz64t12 ibSm02/A9+7Zg7GNCiCJibN2rRg78wKLANC6A+MFo0qypAqaZc3+ X-Google-Smtp-Source: AGHT+IHyw8jSWtpDO8BrX3kYROr9rl6m4q+INmfSxI61JhQchpPQy8VC9DOn8KqfulZFH4T3VzoTnw== X-Received: by 2002:a05:6a20:a125:b0:1a7:2e6f:e5d3 with SMTP id q37-20020a056a20a12500b001a72e6fe5d3mr590280pzk.3.1712168771615; Wed, 03 Apr 2024 11:26:11 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id kq10-20020a056a004b0a00b006eae3aac040sm10609776pfb.31.2024.04.03.11.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 11:26:11 -0700 (PDT) From: Anand Moon To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] PM / devfreq: exynos: Use Use devm_clk_get_enabled() helpers Date: Wed, 3 Apr 2024 23:45:04 +0530 Message-ID: <20240403181517.5993-1-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_112614_859742_853EEF25 X-CRM114-Status: GOOD ( 18.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). While at it, use dev_err_probe consistently, and use its return value to return the error code. Signed-off-by: Anand Moon --- v2: no changes --- drivers/devfreq/exynos-bus.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 245898f1a88e..153340b6685f 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -160,7 +160,6 @@ static void exynos_bus_exit(struct device *dev) platform_device_unregister(bus->icc_pdev); dev_pm_opp_of_remove_table(dev); - clk_disable_unprepare(bus->clk); dev_pm_opp_put_regulators(bus->opp_token); } @@ -171,7 +170,6 @@ static void exynos_bus_passive_exit(struct device *dev) platform_device_unregister(bus->icc_pdev); dev_pm_opp_of_remove_table(dev); - clk_disable_unprepare(bus->clk); } static int exynos_bus_parent_parse_of(struct device_node *np, @@ -247,23 +245,15 @@ static int exynos_bus_parse_of(struct device_node *np, int ret; /* Get the clock to provide each bus with source clock */ - bus->clk = devm_clk_get(dev, "bus"); - if (IS_ERR(bus->clk)) { - dev_err(dev, "failed to get bus clock\n"); - return PTR_ERR(bus->clk); - } - - ret = clk_prepare_enable(bus->clk); - if (ret < 0) { - dev_err(dev, "failed to get enable clock\n"); - return ret; - } + bus->clk = devm_clk_get_enabled(dev, "bus"); + if (IS_ERR(bus->clk)) + return dev_err_probe(dev, PTR_ERR(bus->clk), "failed to get bus clock\n"); /* Get the freq and voltage from OPP table to scale the bus freq */ ret = dev_pm_opp_of_add_table(dev); if (ret < 0) { dev_err(dev, "failed to get OPP table\n"); - goto err_clk; + return ret; } rate = clk_get_rate(bus->clk); @@ -281,8 +271,6 @@ static int exynos_bus_parse_of(struct device_node *np, err_opp: dev_pm_opp_of_remove_table(dev); -err_clk: - clk_disable_unprepare(bus->clk); return ret; } @@ -453,7 +441,6 @@ static int exynos_bus_probe(struct platform_device *pdev) err: dev_pm_opp_of_remove_table(dev); - clk_disable_unprepare(bus->clk); err_reg: dev_pm_opp_put_regulators(bus->opp_token); -- 2.44.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel