From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D07FCD1292 for ; Thu, 4 Apr 2024 07:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BsvLNtWd5cQdqLXwHeL+vHxZu/3AJ6KOkjkIX4gfd+k=; b=0MnOUYmtsaR8LU IqMVX6XJoDTOzbrc6+BEQzEQPH6tG/6BM07wLvB7CPzFJCe//TFdNDSOG2mTjed3a7+87wlU1BUu0 TVG9g/HtP61IeSdfAJSjX0KvOCFOUjVeDWMgOQ3scjYhyKKWBkVrmWriMHsDyXz2BCF+zjW7I6KfL 5rMjMUKOp5xZAmPtVFfQX42anrSmiq5YmnxfKP1LWcruQ4EODTT7ZnnCPRxuHC77XvtTeeIFI6Qp3 vsktJpEPC8MjzOypKZJPVxA3Szgn1UBSl5cOrXXAwnABd9BB++3g8eJVJFEHjEjnjs/vqSaCdI3yO LdWiDkHs1/AeO3l1VwZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsHmv-00000001gsq-10Pu; Thu, 04 Apr 2024 07:45:33 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsHmq-00000001gql-3MDd for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 07:45:31 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id E93141FA6E; Thu, 4 Apr 2024 09:45:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1712216719; bh=ryvia0nLhKRVPovUMdbprzNdINyicI2Sofph4j5VnBw=; h=From:To:Subject; b=TKKNGcyN4+4pkGR46A9CckWl6rgrQniGTh1sxESxhrGRuQEyFxlHJaMYz+eCh8WPK Dw8Z85s+8uzomgK0jDWqMIY9i79fdHOJGiHgm6OL2LXGllg0db0d27DQKswz9oBPRk L2w/U8xUSVQk99Q5kuS9EVvm1CymD11vijQLeritsb+vLHzDHN+xEozlq3zvT3fvyN pwPtNk/tHXZJsxfAIr5R9jeZ+a9fl4u8T3OxHjYhQ9b714Gh499nHq2Mdk0zbs2l2F wLacfIKRrniWEb+qdqsf3B755taCAYodPhYXjIY0rGWBF1eWPKqsYZEZuPdZrJftF/ jqGyPFKpvOk7A== Date: Thu, 4 Apr 2024 09:45:15 +0200 From: Francesco Dolcini To: Michael Walle Cc: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: ti: k3-j722s-evm: Enable eMMC support Message-ID: <20240404074515.GA5639@francesco-nb> References: <20240403102302.3934932-1-mwalle@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240403102302.3934932-1-mwalle@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_004529_916332_54896873 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Michael, On Wed, Apr 03, 2024 at 12:23:02PM +0200, Michael Walle wrote: > The J722S EVM has an on-board eMMC. Enable the SDHC interface for it. > There is no pinmuxing required because the interface has dedicated pins. > > Signed-off-by: Michael Walle > --- > v2: > - move status="okay" last > --- > arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > index cee3a8661d5e..6b148da2bcdc 100644 > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > @@ -369,6 +369,13 @@ partition@3fc0000 { > > }; > > +&sdhci0 { > + ti,driver-strength-ohm = <50>; According to the latest DTS coding style guidelines this needs to be just before status. https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node Yes, we would need a checker, I know and I agree. At least now we moved out of the tribal knowledge way of working with every maintainer having slightly different expectation on this topic ... one step at a time :-) > + disable-wp; > + bootph-all; > + status = "okay"; > +}; Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel