From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 926A2CD1292 for ; Thu, 4 Apr 2024 16:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ro+yHkCiTmGZqYc0WTDae9i+N5Uos8qTEQ/uAM2bglE=; b=qdxR4/+ai4tHxD hY5v7seFPc37XpMhRXVdml8V82mEBNPWnsnwIlzZUyzGaBWvaX1c/RG97CytQfzHgn2TKPHXUOgt4 tJjceFa5tC9/1yIhp/vwWNerjP4ckXHCuX6ul9X4g43T8Q+5PG30XOo5u07be9sma9XTLzkVW3iu5 7ruroH36rYhYW4aMb+RPL/P7Dw8jgOQVctb6iB7I8HOvsa5pIBWWnI2FcpBtZW1TVvi8eyk5egac6 e7yW+zv0aICVVpRqM6LfJYe+81BFK7YQwbSCTlHkYb6XTpiccWUnxx6jer+JVENMOYeQxtClazRUX VWkV2QiwgYefbkl4pRrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsQEv-00000003WiB-3RBf; Thu, 04 Apr 2024 16:47:01 +0000 Received: from relay.smtp-ext.broadcom.com ([192.19.144.208]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsQEs-00000003Wg5-0NXE; Thu, 04 Apr 2024 16:46:59 +0000 Received: from mail-lvn-it-01.lvn.broadcom.net (mail-lvn-it-01.lvn.broadcom.net [10.36.132.253]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 3F5FFC0000EA; Thu, 4 Apr 2024 09:46:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 3F5FFC0000EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1712249214; bh=DTki/MoV8bztqiawIGvg1tXQhkORgVuj92eKUrpM8ug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X0G3zFuV83tobfV5LOUU/XuvTgMuvyi34UopwzGnlobVdwjektcN5QWNo0T3GTYH3 O0ZX+cYePBGCi4CN8eJi6Ijlm3Rqy9ZA8qEDgCbPBp5o8ObakS7ekIOHJCY/cRS4jG 0gDdleTRzPOhNu29wtefA2+MasOocByqIjA4KzM4= Received: from fainelli-desktop.igp.broadcom.net (fainelli-desktop.dhcp.broadcom.net [10.67.48.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail-lvn-it-01.lvn.broadcom.net (Postfix) with ESMTPSA id 6423318041CAC4; Thu, 4 Apr 2024 09:46:52 -0700 (PDT) From: Florian Fainelli To: bcm-kernel-feedback-list@broadcom.com, Laurent Pinchart , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Florian Fainelli , Dave Stevenson , Naushir Patuck , Conor Dooley , Krzysztof Kozlowski , Nicolas Saenz Julienne , Ray Jui , Rob Herring , Scott Branden , Stefan Wahren Subject: Re: [PATCH v2 2/3] firmware: raspberrypi: Use correct device for DMA mappings Date: Thu, 4 Apr 2024 09:46:53 -0700 Message-Id: <20240404164653.2598364-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240326195807.15163-3-laurent.pinchart@ideasonboard.com> References: <20240326195807.15163-1-laurent.pinchart@ideasonboard.com> <20240326195807.15163-3-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_094658_230498_7856D08F X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Florian Fainelli On Tue, 26 Mar 2024 21:58:06 +0200, Laurent Pinchart wrote: > The buffer used to transfer data over the mailbox interface is mapped > using the client's device. This is incorrect, as the device performing > the DMA transfer is the mailbox itself. Fix it by using the mailbox > controller device instead. > > This requires including the mailbox_controller.h header to dereference > the mbox_chan and mbox_controller structures. The header is not meant to > be included by clients. This could be fixed by extending the client API > with a function to access the controller's device. > > Fixes: 4e3d60656a72 ("ARM: bcm2835: Add the Raspberry Pi firmware driver") > Signed-off-by: Laurent Pinchart > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel