From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14910C67861 for ; Thu, 4 Apr 2024 21:42:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lLPDZ6FEeVaw07dXL2dxcuQ+KO6i5ZL9xVZM1fCtOB4=; b=Ejrsh/4ve/ZLXx ngb5bQuw5D55ZeAsMiDN7MEgduMQbvLpW5zw1LGM4hUBu5clC0bc0W2O6KQfprfWjnDMz1q0+IVo/ HW8xbYGrP/LANf8zSm9EysCmeNz/t88hHr7/g/5ILamoCy+NjYKws/1TYwWj35nDd5zVufR10ftrL AsfkLwDZXPnkFnE/ZfaJip1B9f8RLBNc7fJI6IYi8UA9/0bGjHtVTgNA/VYJ7bCzBMbgOYiXzlkez L6hCLmzxpTA7WEZ7M0tjiqG7M25uZDGJK9NfT7VOKjS8GLTNhQk5QpcCVIqVlfuTFj6FfA3mz96IT MaEti+PAoy882We9VXLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsUqX-00000004MlR-2Exe; Thu, 04 Apr 2024 21:42:09 +0000 Received: from iguana.tulip.relay.mailchannels.net ([23.83.218.253]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsUqU-00000004MkZ-1QAR for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 21:42:07 +0000 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4BB24142190 for ; Thu, 4 Apr 2024 21:41:58 +0000 (UTC) Received: from pdx1-sub0-mail-a264.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E3D7C142376 for ; Thu, 4 Apr 2024 21:41:57 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1712266917; a=rsa-sha256; cv=none; b=XoIMti7MdpmH8dbfAouKu0C1MjPPtbBp96IHF/kzdZwWXk8KFz/VlDqJJhH4vI2eVHVIF4 V2lyLdUoNCvpcgKdBfv3wLcd53QIOhWvaII9+eGUCaQv2rFfNRCGcaeCNv16vjS7BpDaNl hVSoupJCsSzFIedPzCiaX23VWhePmSdSoIwVFzKFyAkEbzS4sqEgGnxOlOcas4dTmaSc2R jvrEAp6p8fm5j9rukpJaR7/bufZDf8QTTZY8TKExH+o1eCn3QGm/e2Jt1kCcslzllr2Hl6 eCra+XZcoVKdPiwXBuyQwISBjyUymi1dF/FVFOS0JSJaevY/6RPkXB43v3R0qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1712266917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oiU215bQMRqMD25CrXr9YpvEHYCDhTpFJaAfQebstxE=; b=97ilUBTD0D9600sfwr0sIY5oxBsLVvxZyvvEFnHyyv3AS+jSQgM3O+tx+j2DqohcFZNSnD 0D2e5XACe1zl1H+Ikx8pvlH8mlSdlx0Rv0LG2UiR+BiYJt5l8adgSUgSWoupIqXows4YQS BvXO1EH/Aa0Yb7lWpL0wf60sHPgltXaEqltFT4tF4nbDND03yE5frN/tjaVgXgMoBSwUk0 Xn2eKF4pMpHOXvV5CiU5K8BkZ5GPp3RECnoC+cBQZBri5sZjFgtCzhwKBAQxNuDcjr0+QN W8orRTMr8JrjKAHUTXKKlk4gZVONGJ1thjN/poMXEiEaVQoPLf4nd2zru76XYg== ARC-Authentication-Results: i=1; rspamd-687b9dd446-qcz2x; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Soft-Plucky: 5524abed29f8625e_1712266918148_3443811063 X-MC-Loop-Signature: 1712266918148:1292658750 X-MC-Ingress-Time: 1712266918148 Received: from pdx1-sub0-mail-a264.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.118.191.224 (trex/6.9.2); Thu, 04 Apr 2024 21:41:58 +0000 Received: from kmjvbox.templeofstupid.com (c-73-222-159-162.hsd1.ca.comcast.net [73.222.159.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a264.dreamhost.com (Postfix) with ESMTPSA id 4V9Znx1jm5zY4 for ; Thu, 4 Apr 2024 14:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1712266917; bh=oiU215bQMRqMD25CrXr9YpvEHYCDhTpFJaAfQebstxE=; h=Date:From:To:Cc:Subject:Content-Type; b=LMIK8Xyl6bHblGCtjWTDQm/b66eFVU/mhAWcAHTczX+sQgZ1d/KhhBYxz6YF+Nkl4 M1dGy/oyIWRXRI7sABKox7pd2poOj0ID/nTA94ZDsFKHdc1NMncUVSndihX3qhEnRz sBnj9sIc/4MY3YVzcKHf62ucff/Y9coWWktaClQ2viyYp+AkHBdZArpAkWE5enIHK1 pOG4qmGndYS0AmrVyjSrQfqcSPJN0KJoQpKGBzS6m2rskWbGPFKH6EFkH9XKsFoSge 2WfajbRLfnG+l4pvGsQQT84OSRQgExQoNe5DHzQ6qPeQUscrC9wGcpCYUHM+lsrFZ7 X9KWR0A5TFUHQ== Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e0103 by kmjvbox.templeofstupid.com (DragonFly Mail Agent v0.12); Thu, 04 Apr 2024 14:41:56 -0700 Date: Thu, 4 Apr 2024 14:41:56 -0700 From: Krister Johansen To: Ali Saidi Cc: catalin.marinas@arm.com, james.morse@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maz@kernel.org, me@davidreaver.com, oliver.upton@linux.dev, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com Subject: Re: [PATCH] KVM: arm64: Limit stage2_apply_range() batch size to smallest block Message-ID: <20240404214156.GF2178@templeofstupid.com> References: <20240404044028.GA1976@templeofstupid.com> <20240404212742.11248-1-alisaidi@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240404212742.11248-1-alisaidi@amazon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_144206_539983_B73AF0FB X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 04, 2024 at 09:27:42PM +0000, Ali Saidi wrote: > > Just a quick followup that I did test Will's patches and didn't find > > that it changed the performance of the workload that I'd been testing. > > IOW, I wasn't able to discern a network performance difference between > > the baseline and those changes. > > That is a bit unexpected that the performance wasn't worse with the patch Will > sent because it should have disabled the range invalidates since they these > invalidates will be getting rid of blocks? Which Graviton were you testing > this on? Sorry I didn't mention it earlier. This was on a Graviton 4 with FEAT_TLBIRANGE. Due to the placement of the test machine and the client the max single flow rate was 5Gbps, and with both the baseline and Will's patches I wasn't able to discern any slowdown there, at least in terms of impact to the adjacent networking traffic. I saw an approx 1% slowdown with multiple flows at 10Gbps, but didn't have a baseline for that test case so was hesitant to offer it as conclusive. I should be clear that I _wasn't_ measuring the the teardown times in this test -- just how the teardown itself impacted the networking performance. -K _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel