From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74854CD1284 for ; Fri, 5 Apr 2024 17:35:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DV49GFf4CX/IMcqU6f0A5K30Nx13diLtUxJwlZIALtA=; b=DlKfgYhs/bfCqoLJcK3eHumtkL iog8rEN4Ekkp397VWp1EDRkRg32nvrAGRmWZBeT73FNbtqClc2tsrPjzMoCED54bWVlNb3jnFlwpF jMvsXmQikMMnL25LA4GygeLOcEdGKpNGq869Undm0wW/v2DkQ2qI7oGpVcyMxmryE2+y983RruYmt L43AKnkWuLQwD5mYAZT/UsA+VdI6jNZiWGNZPtEwiSZwsddn04ZiPq4vd93Eejc7Os2BO3LYXHmQL aJ4CCQSGST7BL3P2lrNfmS6FVHQ6eUl6PMh5HQVKjp/YFUOoE3WD4Vede8HDB9EmQmcmclaGuUQwe BcVWvqHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsnSu-00000008Fqb-2YqU; Fri, 05 Apr 2024 17:35:00 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsmMV-00000007zI9-2U3S for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 16:24:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9F13ACE20AD; Fri, 5 Apr 2024 16:24:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2935FC433C7; Fri, 5 Apr 2024 16:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712334256; bh=6JpRDvCOuHegc46R7erCygMAd1uj2iB5Om6sD8dxs6w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LgzQSD8g6+0ukVg19qWTPxYqtTPJlfP4azdnG0YKeUGXpgUogSoC/jh7iZDyaEwyI n7KZd65j8+X0DFnKSfEAUp1s2gyyNpQQZcuE857C6bIUQ1GsWHsrTviIT3EsYMUt+l SozHICPe1KDgb1Ul7AV1682paZ9MJY961AF+fqJ+eRsnF+ooW5MrRg6yXOhNfZzSMa UGogYM6cWamzWapOQIOTUEwZ/VPu9jJTzw2MpdOhTw3oPI5ETQPHDYrekSGqFMnVHw 0XXiqX0jBf31eR/uoOCIvqc62m6vvhFn8J1yQPU8DjX0ffZPUuWe4R/hit26yKBPCt wx0YrMOhSQWvA== Date: Fri, 5 Apr 2024 17:24:11 +0100 From: Conor Dooley To: Dave Stevenson Cc: git@luigi311.com, linux-media@vger.kernel.org, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org Subject: Re: [PATCH v3 18/25] dt-bindings: media: imx258: Add alternate compatible strings Message-ID: <20240405-affair-cruelly-a7e9d23b597c@spud> References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-19-git@luigi311.com> <20240403-vista-defendant-ebadbaa52059@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_092419_994670_751A239F X-CRM114-Status: GOOD ( 28.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7942871936040161459==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7942871936040161459== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4VSlIssbWGjCqHBw" Content-Disposition: inline --4VSlIssbWGjCqHBw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 05, 2024 at 11:25:50AM +0100, Dave Stevenson wrote: > Hi Conor >=20 > On Wed, 3 Apr 2024 at 17:14, Conor Dooley wrote: > > > > On Wed, Apr 03, 2024 at 09:03:47AM -0600, git@luigi311.com wrote: > > > From: Dave Stevenson > > > > > > There are a number of variants of the imx258 modules that can not > > > be differentiated at runtime, so add compatible strings for the > > > PDAF variant. > > > > > > Signed-off-by: Dave Stevenson > > > Signed-off-by: Luis Garcia > > > --- > > > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 9 +++++++= -- > > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.= yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > > index bee61a443b23..c978abc0cdb3 100644 > > > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > > > @@ -13,11 +13,16 @@ description: |- > > > IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS acti= ve pixel > > > type stacked image sensor with a square pixel array of size 4208 x= 3120. It > > > is programmable through I2C interface. Image data is sent through= MIPI > > > - CSI-2. > > > + CSI-2. The sensor exists in two different models, a standard varia= nt > > > + (IMX258) and a variant with phase detection autofocus (IMX258-PDAF= ). > > > + The camera module does not expose the model through registers, so = the > > > + exact model needs to be specified. > > > > > > properties: > > > compatible: > > > - const: sony,imx258 > > > + enum: > > > + - sony,imx258 > > > + - sony,imx258-pdaf > > > > Does the pdaf variant support all of the features/is it register > > compatible with the regular variant? If it is, the regular variant > > should be a fallback compatible. >=20 > It has the same register set, but certain registers have to be > programmed differently so that the image is corrected for the > partially shielded pixels used for phase detect auto focus (PDAF). > Either compatible will "work" on either variant of the module, but > you'll get weird image artifacts when using the wrong one. To paraphase, a fallback compatible is not suitable. Thanks Dave, Conor. --4VSlIssbWGjCqHBw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZhAlqgAKCRB4tDGHoIJi 0kW8AP9KV3LJt1DLGYbcIRYYQzVjf5OtXnW7AC81UNn0epIypwEAwwW/zJA3Q3J0 t6MuHgfu+Sabt0Z5TRNsffWfpDbtfwI= =6umV -----END PGP SIGNATURE----- --4VSlIssbWGjCqHBw-- --===============7942871936040161459== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7942871936040161459==--