From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Dawei Li <dawei.li@shingroup.cn>
Cc: <will@kernel.org>, <mark.rutland@arm.com>, <yury.norov@gmail.com>,
<linux@rasmusvillemoes.dk>, <xueshuai@linux.alibaba.com>,
<renyu.zj@linux.alibaba.com>, <yangyicong@hisilicon.com>,
<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v3 07/10] perf/hisi_pcie: Avoid placing cpumask on the stack
Date: Fri, 5 Apr 2024 10:54:22 +0100 [thread overview]
Message-ID: <20240405105422.00006352@Huawei.com> (raw)
In-Reply-To: <20240403155950.2068109-8-dawei.li@shingroup.cn>
On Wed, 3 Apr 2024 23:59:47 +0800
Dawei Li <dawei.li@shingroup.cn> wrote:
> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
>
> Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
> the stack.
>
> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-05 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 15:59 [PATCH v3 00/10] perf: Avoid placing cpumask on the stack Dawei Li
2024-04-03 15:59 ` [PATCH v3 01/10] cpumask: add cpumask_any_and_but() Dawei Li
2024-04-03 16:31 ` Yury Norov
2024-04-03 15:59 ` [PATCH v3 02/10] perf/alibaba_uncore_drw: Avoid placing cpumask on the stack Dawei Li
2024-04-08 0:28 ` Shuai Xue
2024-04-03 15:59 ` [PATCH v3 03/10] perf/arm-cmn: " Dawei Li
2024-04-03 15:59 ` [PATCH v3 04/10] perf/arm_cspmu: " Dawei Li
2024-04-03 15:59 ` [PATCH v3 05/10] perf/arm_dsu: " Dawei Li
2024-04-03 15:59 ` [PATCH v3 06/10] perf/dwc_pcie: " Dawei Li
2024-04-08 0:30 ` Shuai Xue
2024-04-03 15:59 ` [PATCH v3 07/10] perf/hisi_pcie: " Dawei Li
2024-04-05 9:54 ` Jonathan Cameron [this message]
2024-04-03 15:59 ` [PATCH v3 08/10] perf/hisi_uncore: " Dawei Li
2024-04-05 9:54 ` Jonathan Cameron
2024-04-03 15:59 ` [PATCH v3 09/10] perf/qcom_l2: " Dawei Li
2024-04-03 15:59 ` [PATCH v3 10/10] perf/thunderx2: " Dawei Li
2024-04-09 16:59 ` [PATCH v3 00/10] perf: " Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405105422.00006352@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andersson@kernel.org \
--cc=dawei.li@shingroup.cn \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mark.rutland@arm.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
--cc=yangyicong@hisilicon.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).