From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D32DCD11C2 for ; Fri, 5 Apr 2024 09:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wB1E0DAOxM4cb3oTMtgFq2Bh9+POcPyWheV+Y55K6N0=; b=bOklxyxPcFT8Ml JxIAUNlSwBsDqcAwHoYyzhTvR+/5M4jUHMHBh0+8Oowzhhc5FK8Wa+R0zt9Y4p4oQHCvpnzvrzz+d VWwkZfBP3Sx9xN207F4oE/5czw1NsJ6trNiU7dEnaPQxviAuG1ZCQNrB4mXg+cyuvVEKexo7tEXUu n/9ICapY728rO22jvog5f7GWnY1KwJJZ2IG+PYPsUqpgD+/i+EfgAFshl0bQaoFObI4dDOJhsRQff XCpfSBlXjKryAzGp/cBc2iiBF3qSGqlwdMaxjiPB+yx96G1mcD0aw00LpiA8XKWzdNFqVflh04Yi2 bHWKntx+IiXT53ZKJmiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsgHp-00000006I3C-1aWp; Fri, 05 Apr 2024 09:55:05 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsgHn-00000006I2Z-1gPP for linux-arm-kernel@bombadil.infradead.org; Fri, 05 Apr 2024 09:55:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=jxtlWvFuRbI1Kb5N0cEx9N11uVngbaU7UEgFI999w0U=; b=d9Fuq/CW9BnotTU0+O7RB0yjj7 H/hzhOm7C/QnEcSZrLYciR+ynvW8sZFh7yHq2xxHa57HXd/rk+IpEKBLhP3tbUuxXzG7jawTXwYcB sEqbmcHi9DblLZW2syMkOalKDnLtuWLHwsHXzhbn2habeIHoCstWKzYSHdzhfcAxT/s1CzZPkGVeH GS/yf91nHpe4FBljQ0HjlUankOKbiG2B3GDmKUxJsGXPEqTD9vEIsk8i7XXuKJl4m+G7h+PDS14ft U/p94AZXSALBOsqWpANcAhQORTTL/yAQtuGK9QGwN99hOpMf8TjUfMq6+pdOwEDw+T3Y6dd/QnS9b rtOL2CgQ==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsgHh-00000005XNb-18lI for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 09:55:01 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4V9v1r3RCBz6J6j6; Fri, 5 Apr 2024 17:53:20 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id C57731400D1; Fri, 5 Apr 2024 17:54:42 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 5 Apr 2024 10:54:42 +0100 Date: Fri, 5 Apr 2024 10:54:41 +0100 From: Jonathan Cameron To: Dawei Li CC: , , , , , , , , , , , Subject: Re: [PATCH v3 08/10] perf/hisi_uncore: Avoid placing cpumask on the stack Message-ID: <20240405105441.00006f59@Huawei.com> In-Reply-To: <20240403155950.2068109-9-dawei.li@shingroup.cn> References: <20240403155950.2068109-1-dawei.li@shingroup.cn> <20240403155950.2068109-9-dawei.li@shingroup.cn> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_105458_753581_73E37190 X-CRM114-Status: UNSURE ( 6.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 3 Apr 2024 23:59:48 +0800 Dawei Li wrote: > In general it's preferable to avoid placing cpumasks on the stack, as > for large values of NR_CPUS these can consume significant amounts of > stack space and make stack overflows more likely. > > Use cpumask_any_and_but() to avoid the need for a temporary cpumask on > the stack. > > Suggested-by: Mark Rutland > Reviewed-by: Mark Rutland > Signed-off-by: Dawei Li Acked-by: Jonathan Cameron _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel