From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 084F3CD11C2 for ; Fri, 5 Apr 2024 19:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=20Rtq0kKQuqWTT6bKP7H+3skgPRetT4R47JuN8YgV0g=; b=ZwrC2Btoe2Ln55 XEFMYGlf1oLt2e3E6VsowI/95f0SrNumBEDM6b99L0cq1g3NuKKEvNmHHfO74wweeJoa6g69R6UQa BUewsqORJn0XQEYf+/79fdzIXi7iIE8wq5xzbrSlsJegiy5RlG8xtO+K2ulp+w1Rm0Y9yxss4B/7V aXe9IqabMt1OiYSA6dcc2gBCReq0FGCUuz2E26zeGK7tRyX+VrDvlhr4TMpYUn8P9dX2S8vPkzbq9 XNJVUOuz1ybU3T3qgTN986czyCBnGgoMbqc00LTFi7iVLMfmUwSnu+lusrH5uj1hlpeGmm43e3BkX tUMbgZ51rrwf2gLwE4Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsosT-00000008Zqt-2qsf; Fri, 05 Apr 2024 19:05:29 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsosP-00000008ZnA-3XFL for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 19:05:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 15D2FCE25C5; Fri, 5 Apr 2024 19:05:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F730C43390; Fri, 5 Apr 2024 19:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712343923; bh=jwxmmxNHFZOm86tID6RkRH1tX1Y9t5Sx2emFDKwZGDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KFpJZj0cFqnA3xtAdQ5A3IihPPozY7ZroM/W+XV7jJOOCFEDG/3vWw8UNyZHXhX9N AsuHMXy/Zp4BLim8k3H/8MNbCKSK9mMAokGnccHV0+9xlYcWx3nV59tRyDzj9RaZ// 7oTk8Dtg1XHW/Jh56MofSkq4xoaoWlUaNmNT2DRaJV2+KlAG3LeKTnOSIvVFRhwgMo obYRr5RWf57V6hvY1AoTHGxl214PUGbGDxdeX+JPNpHq5Opl0fHrXrmgiULQrEFu+n tBO/dQh9+MSTXUrORv2BMN//cK5iRra/Imne44nTbz8u3g/sJVOlxKMbULQGQ4gSMX DWhk58TqTdVSA== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Bjarni Jonasson , "David S. Miller" , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: horatiu.vultur@microchip.com, steen.hegelund@microchip.com, Krzysztof Kozlowski Subject: [RFT PATCH v2 10/10] arm64: dts: microchip: sparx5_pcb135: drop duplicated NOR flash Date: Fri, 5 Apr 2024 21:04:19 +0200 Message-Id: <20240405190419.74162-10-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405190419.74162-1-krzk@kernel.org> References: <20240405190419.74162-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_120526_368947_C585AA6B X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since beginning the DTS extended the SPI0 in two places adding two SPI muxes, each with same SPI NOR flash. Both used exactly the same chip-selects, so this was clearly buggy code. Then in commit d0f482bb06f9 ("arm64: dts: sparx5: Add the Sparx5 switch node") one SPI mux was removed, while keeping the SPI NOR flash node. This still leaves duplicated SPI nodes under same chip select 0, reported by dtc W=1 warnings: sparx5_pcb135_board.dtsi:92.10-96.4: Warning (unique_unit_address_if_enabled): /axi@600000000/spi@600104000/flash@0: duplicate unit-address (also used in node /axi@600000000/spi@600104000/spi@0) Steen Hegelund confirmed that in fact there is a SPI mux, thus remove the duplicated node without the mux. Signed-off-by: Krzysztof Kozlowski --- Not tested on hardware Changes in v2: 1. Remove SPI node without mux. --- arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi | 9 --------- 1 file changed, 9 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi index 20016efb3656..af2f1831f07f 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi @@ -87,15 +87,6 @@ i2cmux_s32: i2cmux-3-pins { }; }; -&spi0 { - status = "okay"; - flash@0 { - compatible = "jedec,spi-nor"; - spi-max-frequency = <8000000>; - reg = <0>; - }; -}; - &spi0 { status = "okay"; spi@0 { -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel