From: Conor Dooley <conor@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Sean Wang" <sean.wang@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 3/3] dt-bindings: pinctrl: mediatek: mt7622: add "base" reg
Date: Mon, 8 Apr 2024 17:59:57 +0100 [thread overview]
Message-ID: <20240408-hydrated-swimmable-26cec8823926@spud> (raw)
In-Reply-To: <20240408090506.21596-3-zajec5@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1172 bytes --]
On Mon, Apr 08, 2024 at 11:05:06AM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Both: MT7622 and MT7629 use two reg spaces: "base" and "eint". It wasn't
> covered by the binding and also example didn't match incomplete binding.
> Fix it.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bindings/pinctrl/mediatek,mt7622-pinctrl.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml
> index a9ab623b2697..eaa65512161a 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml
> @@ -19,10 +19,12 @@ properties:
> - mediatek,mt7629-pinctrl
>
> reg:
> - maxItems: 1
> + minItems: 2
> + maxItems: 2
This should become an items list with descriptions IMO.
> reg-names:
> items:
> + - const: base
> - const: eint
Why isnt the new region appended to the list?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-08 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 9:05 [PATCH 1/3] dt-bindings: pinctrl: mediatek: mt7622: fix array properties Rafał Miłecki
2024-04-08 9:05 ` [PATCH 2/3] dt-bindings: pinctrl: mediatek: mt7622: add "antsel" function Rafał Miłecki
2024-04-10 18:02 ` Rob Herring
2024-04-08 9:05 ` [PATCH 3/3] dt-bindings: pinctrl: mediatek: mt7622: add "base" reg Rafał Miłecki
2024-04-08 16:59 ` Conor Dooley [this message]
2024-04-10 18:01 ` [PATCH 1/3] dt-bindings: pinctrl: mediatek: mt7622: fix array properties Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408-hydrated-swimmable-26cec8823926@spud \
--to=conor@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sean.wang@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox