From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 563BBCD1284 for ; Tue, 9 Apr 2024 12:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z7Dkx2NQj6UmYsq0fBMxZkrym6lnaF2cxuuhaSDnSdY=; b=gghCr44f/tqCB3 7tGE1EvJICKUxt0VgiBmMj62dxQUeNHtvYyzcPLe5f1AE6P/nBwxcOkgv4mWbKZa4zeIkMcLmG1aM LyrF1DnYuu2/Ewbv8uu4/dYHBaVqzczXynT7iLcibM9iDSAkrcDhaPB+T5+U48CZiR4eK3btnXHpY +of6IRbFy0zSMH3rPTmp+OaGoAvZvwPTXLjNGtC9pRE29yF3qiDcwS85kaD6aTHEBcMQC8GuD5B7Q qhIrq0espK9c+Uk5UC+njeuXF9wRZrF8XVEQPIEToPa21B5ZcDjIZesbaBik+vXdU5AyTorOdgjRs 5KWL6yDXtIg1jRpjt7Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruAKl-00000001sQC-1DCm; Tue, 09 Apr 2024 12:12:15 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruAKb-00000001sI6-2b9K for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2024 12:12:10 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 91EBBE0004; Tue, 9 Apr 2024 12:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1712664719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZfWm8vYO3mDEuNQxKWMBm2paN+K8NdDcQizKVDcIoC4=; b=my38CGISljwiJ5IwyCJK8F66IO6v+ZQoKG8dNf48uMYkp6aWgPzFutmbt0GJP2xSYK/Rh3 JoJ2t/QZruB2XuoNFZYqXUDc6qtPUp4rIvI1DzmCi2bZikWmYcXYKkgwd3f2UN3nO7xxIr Ma/RleoaEAPuSsj5A4rI8Y+gWy3Sns0quh7Ybo8dgjGo9Cxt9DRPHs7Exum5rnesjLwAYR kmnZD0ZMLoiE5GM95Atw5sZLGKYDX6xVVWai8iv/ggPqDuohI90RnD7DwDxJTJju27cmHm m88JatRVGUgGG27aqS4R/sNXVBrzXc6j2xkGm1yse3fhIeDkcR9RLbvy/TcF5Q== Date: Tue, 9 Apr 2024 14:11:53 +0200 From: Alexandre Belloni To: Javier Carrasco Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiaxun Yang , Vladimir Zapolskiy , Joel Stanley , Andrew Jeffery , Maxime Coquelin , Alexandre Torgue , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 3/9] dt-bindings: rtc: lpc32xx-rtc: move to trivial-rtc Message-ID: <20240409121153e2941468@mail.local> References: <20240408-rtc_dtschema-v1-0-c447542fc362@gmail.com> <20240408-rtc_dtschema-v1-3-c447542fc362@gmail.com> <6dc808bf-682f-4e91-aac7-7ce6f05a0ab4@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6dc808bf-682f-4e91-aac7-7ce6f05a0ab4@gmail.com> X-GND-Sasl: alexandre.belloni@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_051208_393101_22A45AAA X-CRM114-Status: GOOD ( 28.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/04/2024 10:52:54+0200, Javier Carrasco wrote: > On 4/9/24 09:34, Krzysztof Kozlowski wrote: > > On 08/04/2024 17:53, Javier Carrasco wrote: > >> This RTC requires a compatible, a reg and a single interrupt, > >> which makes it suitable for a direct conversion into trivial-rtc. > >> > >> Signed-off-by: Javier Carrasco > >> --- > >> Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 --------------- > >> Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++ > >> 2 files changed, 2 insertions(+), 15 deletions(-) > > > > This one no... and if you tested DTS you would see errors, although you > > need to test specific lpc config, not multi_v7. > > > > It does not look like you tested the DTS against bindings. Please run > > `make dtbs_check W=1` (see > > Documentation/devicetree/bindings/writing-schema.rst or > > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > > for instructions). > > > > Anyway, you *must* check all DTS before moving anything to trivial. > > > > Does it mean all other bindings were not checked against DTS at all? > > > > Best regards, > > Krzysztof > > > Hi, > > I did check the conversion against nxp/lpc/lpc3250-phy3250.dts, which > throws a message about the 'clocks' property. > > That property is not documented in the original binding, and even though > it could be missing, I could not find any function to get a clock (i.e. > any form of clk_get()) in rtc-lpc32xx.c, which is the only file where > the compatible can be found. > > Is therefore the property not useless in the dts? My apologies if I am > missing something here. The bindings doesn't document the driver but the hardware. In this case, the only input clock seems to be a 32kHz crystal. > > Thanks and best regards, > Javier Carrasco -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel